From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: crope@iki.fi, mchehab@kernel.org, ezequiel@vanguardiasur.com.ar,
royale@zerezo.com, sean@mess.org, klimov.linux@gmail.com,
hverkuil@xs4all.nl, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] [media] usb: constify usb_device_id
Date: Sun, 13 Aug 2017 15:23:08 +0300 [thread overview]
Message-ID: <6110957.VAtsH2oBFn@avalon> (raw)
In-Reply-To: <1502614485-2150-2-git-send-email-arvind.yadav.cs@gmail.com>
Hi Arvind,
Thank you for the patch.
On Sunday 13 Aug 2017 14:24:43 Arvind Yadav wrote:
> usb_device_id are not supposed to change at runtime. All functions
> working with usb_device_id provided by <linux/usb.h> work with
> const usb_device_id. So mark the non-const structs as const.
>
> 'drivers/media/usb/b2c2/flexcop-usb.c' Fix checkpatch.pl error:
> ERROR: space prohibited before open square bracket '['.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/media/usb/airspy/airspy.c | 2 +-
> drivers/media/usb/as102/as102_usb_drv.c | 2 +-
> drivers/media/usb/b2c2/flexcop-usb.c | 2 +-
> drivers/media/usb/cpia2/cpia2_usb.c | 2 +-
> drivers/media/usb/dvb-usb-v2/az6007.c | 2 +-
> drivers/media/usb/hackrf/hackrf.c | 2 +-
> drivers/media/usb/hdpvr/hdpvr-core.c | 2 +-
> drivers/media/usb/msi2500/msi2500.c | 2 +-
> drivers/media/usb/s2255/s2255drv.c | 2 +-
> drivers/media/usb/stk1160/stk1160-core.c | 2 +-
> drivers/media/usb/stkwebcam/stk-webcam.c | 2 +-
> drivers/media/usb/tm6000/tm6000-cards.c | 2 +-
> drivers/media/usb/ttusb-budget/dvb-ttusb-budget.c | 2 +-
> drivers/media/usb/ttusb-dec/ttusb_dec.c | 2 +-
> drivers/media/usb/usbtv/usbtv-core.c | 2 +-
> drivers/media/usb/uvc/uvc_driver.c | 2 +-
For the UVC driver,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> drivers/media/usb/zr364xx/zr364xx.c | 2 +-
> 17 files changed, 17 insertions(+), 17 deletions(-)
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2017-08-13 12:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-13 8:54 [PATCH 0/3] constify media usb_device_id Arvind Yadav
2017-08-13 8:54 ` [PATCH 1/3] [media] usb: constify usb_device_id Arvind Yadav
2017-08-13 12:23 ` Laurent Pinchart [this message]
2017-08-13 8:54 ` [PATCH 2/3] [media] rc: " Arvind Yadav
2017-08-15 11:45 ` Sean Young
2017-08-13 8:54 ` [PATCH 3/3] [media] radio: " Arvind Yadav
2017-08-21 10:03 ` Alexey Klimov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6110957.VAtsH2oBFn@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=crope@iki.fi \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=hverkuil@xs4all.nl \
--cc=klimov.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=royale@zerezo.com \
--cc=sean@mess.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.