From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Rob Clark <rob.clark@linaro.org>
Cc: patches@linaro.org, daniel.vetter@ffwll.ch,
dri-devel@lists.freedesktop.org, bskeggs@redhat.com,
alexander.deucher@amd.com, Rob Clark <rob@ti.com>,
alan@linux.intel.com
Subject: Re: [PATCH 0/9] cleanup: remove legacy connector property functions
Date: Wed, 17 Oct 2012 12:52:32 +0200 [thread overview]
Message-ID: <6113328.p0sPAbNccH@avalon> (raw)
In-Reply-To: <1350007562-22323-1-git-send-email-rob.clark@linaro.org>
Hi Rob,
Thanks for the patches. They look good to me, except for the empty commit
messages and the odd alignment. For instance, I would have replaced
- drm_connector_property_set_value(connector,
+ drm_object_property_set_value(&connector->base,
dpms_property,
DRM_MODE_DPMS_ON);
with
- drm_connector_property_set_value(connector,
- dpms_property,
- DRM_MODE_DPMS_ON);
+ drm_object_property_set_value(&connector->base,
+ dpms_property,
+ DRM_MODE_DPMS_ON);
Feel free to ignore the alignment issue if you wish.
Other than that,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
and
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
for the shmob patch.
On Thursday 11 October 2012 21:05:53 Rob Clark wrote:
> From: Rob Clark <rob@ti.com>
>
> It was suggested by Laurent Pinchart to clean up the legacy connector
> property functions, as they are no longer needed. This patchset
> replaces references to and remove the connector property fxns, which
> have been superseded with the more general object property fxns:
>
> + drm_connector_attach_property -> drm_object_attach_property
> + drm_connector_property_set_value -> drm_object_property_set_value
> + drm_connector_property_get_value -> drm_object_property_get_value
>
> Rob Clark (9):
> drm/i915: drm_connector_property -> drm_object_property
> drm/gma500: drm_connector_property -> drm_object_property
> drm/nouveau: drm_connector_property -> drm_object_property
> drm/radeon: drm_connector_property -> drm_object_property
> drm/shmob: drm_connector_property -> drm_object_property
> drm/udl: drm_connector_property -> drm_object_property
> drm/vmwgfx: drm_connector_property -> drm_object_property
> drm/i2c: drm_connector_property -> drm_object_property
> drm: remove legacy drm_connector_property fxns
>
> drivers/gpu/drm/drm_crtc.c | 31 +++----------
> drivers/gpu/drm/drm_fb_helper.c | 2 +-
> drivers/gpu/drm/drm_sysfs.c | 6 +--
> drivers/gpu/drm/gma500/cdv_device.c | 4 +-
> drivers/gpu/drm/gma500/cdv_intel_dp.c | 2 +-
> drivers/gpu/drm/gma500/cdv_intel_hdmi.c | 6 +--
> drivers/gpu/drm/gma500/cdv_intel_lvds.c | 10 ++---
> drivers/gpu/drm/gma500/mdfld_dsi_output.c | 10 ++---
> drivers/gpu/drm/gma500/mdfld_intel_display.c | 2 +-
> drivers/gpu/drm/gma500/oaktrail_crtc.c | 2 +-
> drivers/gpu/drm/gma500/oaktrail_lvds.c | 8 ++--
> drivers/gpu/drm/gma500/psb_intel_lvds.c | 10 ++---
> drivers/gpu/drm/gma500/psb_intel_sdvo.c | 24 +++++-----
> drivers/gpu/drm/i2c/ch7006_drv.c | 20 ++++-----
> drivers/gpu/drm/i915/intel_display.c | 2 +-
> drivers/gpu/drm/i915/intel_dp.c | 2 +-
> drivers/gpu/drm/i915/intel_hdmi.c | 2 +-
> drivers/gpu/drm/i915/intel_lvds.c | 2 +-
> drivers/gpu/drm/i915/intel_modes.c | 4 +-
> drivers/gpu/drm/i915/intel_sdvo.c | 24 +++++-----
> drivers/gpu/drm/i915/intel_tv.c | 14 +++---
> drivers/gpu/drm/nouveau/nouveau_connector.c | 22 ++++-----
> drivers/gpu/drm/nouveau/nv17_tv.c | 16 +++----
> drivers/gpu/drm/radeon/radeon_connectors.c | 62 +++++++++++------------
> drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 2 +-
> drivers/gpu/drm/udl/udl_connector.c | 2 +-
> drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c | 2 +-
> drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 2 +-
> include/drm/drm_crtc.h | 8 ----
> 29 files changed, 137 insertions(+), 166 deletions(-)
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2012-10-17 10:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 2:05 [PATCH 0/9] cleanup: remove legacy connector property functions Rob Clark
2012-10-12 2:05 ` [PATCH 1/9] drm/i915: drm_connector_property -> drm_object_property Rob Clark
2012-10-15 6:59 ` Jani Nikula
2012-11-21 16:42 ` Daniel Vetter
2012-11-21 21:13 ` Daniel Vetter
2012-10-12 2:05 ` [PATCH 2/9] drm/gma500: " Rob Clark
2012-10-12 2:05 ` [PATCH 3/9] drm/nouveau: " Rob Clark
2012-10-12 2:05 ` [PATCH 4/9] drm/radeon: " Rob Clark
2012-10-12 2:05 ` [PATCH 5/9] drm/shmob: " Rob Clark
2012-10-12 2:05 ` [PATCH 6/9] drm/udl: " Rob Clark
2012-10-12 2:06 ` [PATCH 7/9] drm/vmwgfx: " Rob Clark
2012-10-12 2:06 ` [PATCH 8/9] drm/i2c: " Rob Clark
2012-10-12 2:06 ` [PATCH 9/9] drm: remove legacy drm_connector_property fxns Rob Clark
2012-10-15 7:04 ` Jani Nikula
2012-10-17 10:52 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6113328.p0sPAbNccH@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=alan@linux.intel.com \
--cc=alexander.deucher@amd.com \
--cc=bskeggs@redhat.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=patches@linaro.org \
--cc=rob.clark@linaro.org \
--cc=rob@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.