From: Tomasz Figa <tomasz.figa@gmail.com>
To: linux-samsung-soc@vger.kernel.org
Cc: s.nawrocki@samsung.com
Subject: s5p-fimc VIDIOC_STREAMOFF bug
Date: Thu, 19 Apr 2012 23:45:02 +0200 [thread overview]
Message-ID: <6126533.0OoG4qIlQU@flatron> (raw)
Hi,
I have been working on adapting s5p-fimc driver for s3c6410 and everything
seems to be working just fine after some minor changes (except minor loss
of functionality - only codec path is supported, but for most use cases it
does not matter).
However I think that I have spotted a bug in capture stop / capture suspend
handling. In fimc_capture_state_cleanup() the ST_CAPT_SUSPENDED status bit
of fimc->state field is being set regardless of suspend parameter, which
confuses the driver that FIMC is suspended and might not accept buffers
into active queue and so the driver will never start the capture process
unless the device gets closed and reopened (because of the condition
checking the count of active buffers).
In my fork for s3c6410 I have moved the set_bit call into
fimc_capture_suspend(), so the bit gets set only when the device gets
suspended. This seems to solve the problem and I do not see any issues that
this could introduce, so it might be a good solution.
Let me know if I am wrong in anything I have written.
Best regards,
Tomasz Figa
next reply other threads:[~2012-04-19 21:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-19 21:45 Tomasz Figa [this message]
2012-04-20 18:24 ` s5p-fimc VIDIOC_STREAMOFF bug Sylwester Nawrocki
2012-04-21 15:22 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6126533.0OoG4qIlQU@flatron \
--to=tomasz.figa@gmail.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.