From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCHv2 38/45] drm: omapdrm: omap_plane_setup() cannot fail, use WARN Date: Sat, 06 Jun 2015 06:14:37 +0300 Message-ID: <6128357.FEp926egWH@avalon> References: <1433408582-9828-1-git-send-email-tomi.valkeinen@ti.com> <1433408582-9828-39-git-send-email-tomi.valkeinen@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [185.26.127.97]) by gabe.freedesktop.org (Postfix) with ESMTP id 99A226E543 for ; Fri, 5 Jun 2015 23:24:45 -0700 (PDT) In-Reply-To: <1433408582-9828-39-git-send-email-tomi.valkeinen@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Tomi Valkeinen Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgVG9taSwKClRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoLgoKT24gVGh1cnNkYXkgMDQgSnVuZSAy MDE1IDEyOjAyOjU1IFRvbWkgVmFsa2VpbmVuIHdyb3RlOgo+IFdpdGggYXRvbWljIG1vZGVzZXR0 aW5nLCBvbWFwX3BsYW5lX3NldHVwKCkncyByZXR1cm4gdmFsdWUgaXMgaWdub3JlZCBhcwo+IHRo ZSBmdW5jdGlvbnMgdXNpbmcgaXQgY2Fubm90IGZhaWwuIGRpc3BjX292bF9zZXR1cCgpLCBjYWxs ZWQgYnkKPiBvbWFwX3BsYW5lX3NldHVwKCksIGNhbiBmYWlsIChidXQgc2hvdWxkbid0KS4KPiAK PiBJbnN0ZWFkIG9mIHJldHVybmluZyBhbiBlcnJvciBmcm9tIG9tYXBfcGxhbmVfc2V0dXAoKSB3 aGljaCBnZXRzCj4gaWdub3JlZCwgcmV0dXJuIHZvaWQgYW5kIHVzZSBXQVJOIGlmIGRpc3BjX292 bF9zZXR1cCgpIGZhaWxzLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFRvbWkgVmFsa2VpbmVuIDx0b21p LnZhbGtlaW5lbkB0aS5jb20+CgpBY2tlZC1ieTogTGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5w aW5jaGFydEBpZGVhc29uYm9hcmQuY29tPgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL29tYXBk cm0vb21hcF9wbGFuZS5jIHwgMTMgKysrKy0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNCBp bnNlcnRpb25zKCspLCA5IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vb21hcGRybS9vbWFwX3BsYW5lLmMKPiBiL2RyaXZlcnMvZ3B1L2RybS9vbWFwZHJtL29t YXBfcGxhbmUuYyBpbmRleCA0NDg3MDc2Njk2OTAuLmE4ZTYxN2Y5ZjJhZgo+IDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9vbWFwZHJtL29tYXBfcGxhbmUuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9vbWFwZHJtL29tYXBfcGxhbmUuYwo+IEBAIC01OCwxMiArNTgsMTEgQEAgdG9fb21h cF9wbGFuZV9zdGF0ZShzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpzdGF0ZSkKPiAgCXJldHVybiBj b250YWluZXJfb2Yoc3RhdGUsIHN0cnVjdCBvbWFwX3BsYW5lX3N0YXRlLCBiYXNlKTsKPiAgfQo+ IAo+IC1zdGF0aWMgaW50IG9tYXBfcGxhbmVfc2V0dXAoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUp Cj4gK3N0YXRpYyB2b2lkIG9tYXBfcGxhbmVfc2V0dXAoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUp Cj4gIHsKPiAgCXN0cnVjdCBvbWFwX3BsYW5lICpvbWFwX3BsYW5lID0gdG9fb21hcF9wbGFuZShw bGFuZSk7Cj4gIAlzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpzdGF0ZSA9IHBsYW5lLT5zdGF0ZTsK PiAgCXN0cnVjdCBvbWFwX3BsYW5lX3N0YXRlICpvbWFwX3N0YXRlID0gdG9fb21hcF9wbGFuZV9z dGF0ZShzdGF0ZSk7Cj4gLQlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gcGxhbmUtPmRldjsKPiAg CXN0cnVjdCBvbWFwX292ZXJsYXlfaW5mbyBpbmZvOwo+ICAJc3RydWN0IG9tYXBfZHJtX3dpbmRv dyB3aW47Cj4gIAlpbnQgcmV0Owo+IEBAIC03Miw3ICs3MSw3IEBAIHN0YXRpYyBpbnQgb21hcF9w bGFuZV9zZXR1cChzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSkKPiAKPiAgCWlmICghc3RhdGUtPmNy dGMpIHsKPiAgCQlkaXNwY19vdmxfZW5hYmxlKG9tYXBfcGxhbmUtPmlkLCBmYWxzZSk7Cj4gLQkJ cmV0dXJuIDA7Cj4gKwkJcmV0dXJuOwo+ICAJfQo+IAo+ICAJbWVtc2V0KCZpbmZvLCAwLCBzaXpl b2YoaW5mbykpOwo+IEBAIC0xMjMsMTQgKzEyMiwxMCBAQCBzdGF0aWMgaW50IG9tYXBfcGxhbmVf c2V0dXAoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUpCj4gIAkvKiBhbmQgZmluYWxseSwgdXBkYXRl IG9tYXBkc3M6ICovCj4gIAlyZXQgPSBkaXNwY19vdmxfc2V0dXAob21hcF9wbGFuZS0+aWQsICZp bmZvLCBmYWxzZSwKPiAgCQkJICAgICAgb21hcF9jcnRjX3RpbWluZ3Moc3RhdGUtPmNydGMpLCBm YWxzZSk7Cj4gLQlpZiAocmV0KSB7Cj4gLQkJZGV2X2VycihkZXYtPmRldiwgImRpc3BjX292bF9z ZXR1cCBmYWlsZWQ6ICVkXG4iLCByZXQpOwo+IC0JCXJldHVybiByZXQ7Cj4gLQl9Cj4gKwlpZiAo V0FSTl9PTihyZXQpKQo+ICsJCXJldHVybjsKPiAKPiAgCWRpc3BjX292bF9lbmFibGUob21hcF9w bGFuZS0+aWQsIHRydWUpOwo+IC0KPiAtCXJldHVybiAwOwo+ICB9Cj4gCj4gIHN0YXRpYyBpbnQg b21hcF9wbGFuZV9wcmVwYXJlX2ZiKHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAoKLS0gClJlZ2Fy ZHMsCgpMYXVyZW50IFBpbmNoYXJ0CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2RyaS1kZXZlbAo=