All of lore.kernel.org
 help / color / mirror / Atom feed
From: bluez.test.bot@gmail.com
To: linux-bluetooth@vger.kernel.org, dmitry.baryshkov@linaro.org
Subject: RE: create power sequencing subsystem
Date: Sun, 29 Aug 2021 07:02:36 -0700 (PDT)	[thread overview]
Message-ID: <612b937c.1c69fb81.2476a.ff6f@mx.google.com> (raw)
In-Reply-To: <20210829131305.534417-2-dmitry.baryshkov@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 15822 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=538865

---Test result---

Test Summary:
CheckPatch                    FAIL      10.08 seconds
GitLint                       FAIL      1.29 seconds
BuildKernel                   PASS      513.89 seconds
TestRunner: Setup             PASS      340.37 seconds
TestRunner: l2cap-tester      PASS      2.58 seconds
TestRunner: bnep-tester       PASS      1.92 seconds
TestRunner: mgmt-tester       PASS      30.13 seconds
TestRunner: rfcomm-tester     PASS      2.11 seconds
TestRunner: sco-tester        PASS      2.03 seconds
TestRunner: smp-tester        FAIL      2.12 seconds
TestRunner: userchan-tester   PASS      1.94 seconds

Details
##############################
Test: CheckPatch - FAIL - 10.08 seconds
Run checkpatch.pl script with rule in .checkpatch.conf
power: add power sequencer subsystem
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#31: 
new file mode 100644

WARNING: please write a paragraph that describes the config symbol fully
#37: FILE: drivers/power/pwrseq/Kconfig:2:
+menuconfig PWRSEQ

ERROR: "foo * bar" should be "foo *bar"
#169: FILE: drivers/power/pwrseq/core.c:105:
+struct pwrseq * __pwrseq_get(struct device *dev, const char *id, bool optional)

ERROR: "foo * bar" should be "foo *bar"
#192: FILE: drivers/power/pwrseq/core.c:128:
+struct pwrseq * pwrseq_get(struct device *dev, const char *id)

ERROR: "foo * bar" should be "foo *bar"
#205: FILE: drivers/power/pwrseq/core.c:141:
+struct pwrseq * devm_pwrseq_get(struct device *dev, const char *id)

ERROR: "foo * bar" should be "foo *bar"
#225: FILE: drivers/power/pwrseq/core.c:161:
+struct pwrseq * pwrseq_get_optional(struct device *dev, const char *id)

ERROR: "foo * bar" should be "foo *bar"
#231: FILE: drivers/power/pwrseq/core.c:167:
+struct pwrseq * devm_pwrseq_get_optional(struct device *dev, const char *id)

WARNING: line length of 114 exceeds 100 columns
#297: FILE: drivers/power/pwrseq/core.c:233:
+struct pwrseq *__pwrseq_create(struct device *dev, struct module *owner, const struct pwrseq_ops *ops, void *data)

WARNING: line length of 119 exceeds 100 columns
#367: FILE: drivers/power/pwrseq/core.c:303:
+struct pwrseq *__devm_pwrseq_create(struct device *dev, struct module *owner, const struct pwrseq_ops *ops, void *data)

WARNING: ENOSYS means 'invalid syscall nr' and nothing else
#514: FILE: include/linux/pwrseq/consumer.h:32:
+	return ERR_PTR(-ENOSYS);

WARNING: ENOSYS means 'invalid syscall nr' and nothing else
#520: FILE: include/linux/pwrseq/consumer.h:38:
+	return ERR_PTR(-ENOSYS);

WARNING: ENOSYS means 'invalid syscall nr' and nothing else
#541: FILE: include/linux/pwrseq/consumer.h:59:
+	return -ENOSYS;

WARNING: ENOSYS means 'invalid syscall nr' and nothing else
#546: FILE: include/linux/pwrseq/consumer.h:64:
+	return -ENOSYS;

WARNING: line length of 115 exceeds 100 columns
#605: FILE: include/linux/pwrseq/driver.h:29:
+struct pwrseq *__pwrseq_create(struct device *dev, struct module *owner, const struct pwrseq_ops *ops, void *data);

WARNING: line length of 120 exceeds 100 columns
#606: FILE: include/linux/pwrseq/driver.h:30:
+struct pwrseq *__devm_pwrseq_create(struct device *dev, struct module *owner, const struct pwrseq_ops *ops, void *data);

total: 5 errors, 10 warnings, 600 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] power: add power sequencer subsystem" has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

pwrseq: port MMC's pwrseq drivers to new pwrseq subsystem
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#12: 
rename from Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml

WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst

WARNING: ENOSYS means 'invalid syscall nr' and nothing else
#908: FILE: drivers/power/pwrseq/pwrseq_simple.c:133:
+	    PTR_ERR(pwrseq_simple->reset_gpios) != -ENOSYS) {

total: 0 errors, 3 warnings, 467 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] pwrseq: port MMC's pwrseq drivers to new pwrseq subsystem" has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

mmc: core: switch to new pwrseq subsystem
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#126: 
deleted file mode 100644

total: 0 errors, 1 warnings, 109 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] mmc: core: switch to new pwrseq subsystem" has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

pwrseq: add support for QCA BT+WiFi power sequencer
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#54: 
new file mode 100644

WARNING: Missing a blank line after declarations
#168: FILE: drivers/power/pwrseq/pwrseq_qca.c:110:
+		bool sw_ctrl_state = gpiod_get_value_cansleep(qca_one->common->sw_ctrl);
+		dev_dbg(&pwrseq->dev, "SW_CTRL is %d", sw_ctrl_state);

WARNING: Missing a blank line after declarations
#197: FILE: drivers/power/pwrseq/pwrseq_qca.c:139:
+		bool sw_ctrl_state = gpiod_get_value_cansleep(qca_one->common->sw_ctrl);
+		dev_dbg(&pwrseq->dev, "SW_CTRL is %d", sw_ctrl_state);

WARNING: line length of 107 exceeds 100 columns
#282: FILE: drivers/power/pwrseq/pwrseq_qca.c:224:
+	pwrseq_qca = devm_kzalloc(dev, struct_size(pwrseq_qca, common.vregs, data->num_vregs), GFP_KERNEL);

WARNING: line length of 106 exceeds 100 columns
#299: FILE: drivers/power/pwrseq/pwrseq_qca.c:241:
+			return dev_err_probe(dev, PTR_ERR(gpiod), "failed to acquire WIFI enable GPIO\n");

WARNING: line length of 104 exceeds 100 columns
#307: FILE: drivers/power/pwrseq/pwrseq_qca.c:249:
+			return dev_err_probe(dev, PTR_ERR(gpiod), "failed to acquire BT enable GPIO\n");

WARNING: line length of 106 exceeds 100 columns
#314: FILE: drivers/power/pwrseq/pwrseq_qca.c:256:
+	/* If we have no control over device's enablement, make sure that sleep clock is always running */

WARNING: line length of 102 exceeds 100 columns
#327: FILE: drivers/power/pwrseq/pwrseq_qca.c:269:
+		ret = devm_add_action_or_reset(dev, pwrseq_qca_unprepare_susclk, &pwrseq_qca->common);

WARNING: DT compatible string "qcom,qca6174-pwrseq" appears un-documented -- check ./Documentation/devicetree/bindings/
#409: FILE: drivers/power/pwrseq/pwrseq_qca.c:351:
+	{ .compatible = "qcom,qca6174-pwrseq", },

WARNING: DT compatible string "qcom,qca6390-pwrseq" appears un-documented -- check ./Documentation/devicetree/bindings/
#410: FILE: drivers/power/pwrseq/pwrseq_qca.c:352:
+	{ .compatible = "qcom,qca6390-pwrseq", .data = &qca_soc_data_qca6390 },

WARNING: DT compatible string "qcom,qca9377-pwrseq" appears un-documented -- check ./Documentation/devicetree/bindings/
#411: FILE: drivers/power/pwrseq/pwrseq_qca.c:353:
+	{ .compatible = "qcom,qca9377-pwrseq" },

WARNING: DT compatible string "qcom,wcn3990-pwrseq" appears un-documented -- check ./Documentation/devicetree/bindings/
#412: FILE: drivers/power/pwrseq/pwrseq_qca.c:354:
+	{ .compatible = "qcom,wcn3990-pwrseq", .data = &qca_soc_data_wcn3990 },

WARNING: DT compatible string "qcom,wcn3991-pwrseq" appears un-documented -- check ./Documentation/devicetree/bindings/
#413: FILE: drivers/power/pwrseq/pwrseq_qca.c:355:
+	{ .compatible = "qcom,wcn3991-pwrseq", .data = &qca_soc_data_wcn3990 },

WARNING: DT compatible string "qcom,wcn3998-pwrseq" appears un-documented -- check ./Documentation/devicetree/bindings/
#414: FILE: drivers/power/pwrseq/pwrseq_qca.c:356:
+	{ .compatible = "qcom,wcn3998-pwrseq", .data = &qca_soc_data_wcn3998 },

WARNING: DT compatible string "qcom,wcn6750-pwrseq" appears un-documented -- check ./Documentation/devicetree/bindings/
#415: FILE: drivers/power/pwrseq/pwrseq_qca.c:357:
+	{ .compatible = "qcom,wcn6750-pwrseq", .data = &qca_soc_data_wcn6750 },

total: 0 errors, 15 warnings, 397 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] pwrseq: add support for QCA BT+WiFi power sequencer" has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

pwrseq: add fallback support
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#48: 
new file mode 100644

total: 0 errors, 1 warnings, 134 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] pwrseq: add fallback support" has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

pwrseq: pwrseq_qca: implement fallback support
ERROR: "foo * bar" should be "foo *bar"
#66: FILE: drivers/power/pwrseq/pwrseq_qca.c:403:
+static struct pwrseq * pwrseq_qca_fallback_get(struct device *dev)

WARNING: line length of 103 exceeds 100 columns
#82: FILE: drivers/power/pwrseq/pwrseq_qca.c:419:
+	fallback = devm_kzalloc(dev, struct_size(fallback, common.vregs, data->num_vregs), GFP_KERNEL);

WARNING: line length of 110 exceeds 100 columns
#95: FILE: drivers/power/pwrseq/pwrseq_qca.c:432:
+			return ERR_PTR(dev_err_probe(dev, PTR_ERR(gpiod), "failed to acquire enable GPIO\n"));

WARNING: line length of 106 exceeds 100 columns
#99: FILE: drivers/power/pwrseq/pwrseq_qca.c:436:
+	/* If we have no control over device's enablement, make sure that sleep clock is always running */

ERROR: "foo * bar" should be "foo *bar"
#119: FILE: drivers/power/pwrseq/pwrseq_qca.c:456:
+static struct pwrseq * pwrseq_qca_fallback_get_bt(struct device *dev, const char *id)

ERROR: "foo * bar" should be "foo *bar"
#127: FILE: drivers/power/pwrseq/pwrseq_qca.c:464:
+static struct pwrseq * pwrseq_qca_fallback_get_wifi(struct device *dev, const char *id)

total: 3 errors, 3 warnings, 161 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] pwrseq: pwrseq_qca: implement fallback support" has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Bluetooth: hci_qca: switch to using pwrseq
WARNING: Missing commit description - Add an appropriate one

total: 0 errors, 1 warnings, 425 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] Bluetooth: hci_qca: switch to using pwrseq" has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

arm64: dts: qcom: sdm845-db845c: switch bt+wifi to qca power sequencer
WARNING: DT compatible string "qcom,wcn3990-pwrseq" appears un-documented -- check ./Documentation/devicetree/bindings/
#67: FILE: arch/arm64/boot/dts/qcom/sdm845.dtsi:1055:
+		compatible = "qcom,wcn3990-pwrseq";

total: 0 errors, 1 warnings, 51 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] arm64: dts: qcom: sdm845-db845c: switch bt+wifi to qca power" has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

arm64: dts: qcom: qrb5165-rb5: add bluetooth support
WARNING: DT compatible string "qcom,qca6390-pwrseq" appears un-documented -- check ./Documentation/devicetree/bindings/
#29: FILE: arch/arm64/boot/dts/qcom/qrb5165-rb5.dts:103:
+		compatible = "qcom,qca6390-pwrseq";

total: 0 errors, 1 warnings, 74 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] arm64: dts: qcom: qrb5165-rb5: add bluetooth support" has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

WIP: arm64: dts: qcom: qrb5165-rb5: add bus-pwrseq property to pcie0
WARNING: Missing commit description - Add an appropriate one

total: 0 errors, 1 warnings, 7 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] WIP: arm64: dts: qcom: qrb5165-rb5: add bus-pwrseq property" has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


##############################
Test: GitLint - FAIL - 1.29 seconds
Run gitlint with rule in .gitlint
arm64: dts: qcom: sdm845-db845c: add second channel to qca power sequencer
1: T1 Title exceeds max length (74>72): "arm64: dts: qcom: sdm845-db845c: add second channel to qca power sequencer"

WIP: PCI: qcom: use pwrseq to power up bus devices
1: T5 Title contains the word 'WIP' (case-insensitive): "WIP: PCI: qcom: use pwrseq to power up bus devices"

WIP: arm64: dts: qcom: qrb5165-rb5: add bus-pwrseq property to pcie0
1: T5 Title contains the word 'WIP' (case-insensitive): "WIP: arm64: dts: qcom: qrb5165-rb5: add bus-pwrseq property to pcie0"


##############################
Test: BuildKernel - PASS - 513.89 seconds
Build Kernel with minimal configuration supports Bluetooth


##############################
Test: TestRunner: Setup - PASS - 340.37 seconds
Setup environment for running Test Runner


##############################
Test: TestRunner: l2cap-tester - PASS - 2.58 seconds
Run test-runner with l2cap-tester
Total: 40, Passed: 40 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: bnep-tester - PASS - 1.92 seconds
Run test-runner with bnep-tester
Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: mgmt-tester - PASS - 30.13 seconds
Run test-runner with mgmt-tester
Total: 452, Passed: 449 (99.3%), Failed: 0, Not Run: 3

##############################
Test: TestRunner: rfcomm-tester - PASS - 2.11 seconds
Run test-runner with rfcomm-tester
Total: 9, Passed: 9 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: sco-tester - PASS - 2.03 seconds
Run test-runner with sco-tester
Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: smp-tester - FAIL - 2.12 seconds
Run test-runner with smp-tester
Total: 8, Passed: 7 (87.5%), Failed: 1, Not Run: 0

Failed Test Cases
SMP Client - SC Request 2                            Failed       0.020 seconds

##############################
Test: TestRunner: userchan-tester - PASS - 1.94 seconds
Run test-runner with userchan-tester
Total: 3, Passed: 3 (100.0%), Failed: 0, Not Run: 0



---
Regards,
Linux Bluetooth


[-- Attachment #2: l2cap-tester.log --]
[-- Type: application/octet-stream, Size: 44386 bytes --]

[-- Attachment #3: bnep-tester.log --]
[-- Type: application/octet-stream, Size: 3591 bytes --]

[-- Attachment #4: mgmt-tester.log --]
[-- Type: application/octet-stream, Size: 622241 bytes --]

[-- Attachment #5: rfcomm-tester.log --]
[-- Type: application/octet-stream, Size: 11713 bytes --]

[-- Attachment #6: sco-tester.log --]
[-- Type: application/octet-stream, Size: 9948 bytes --]

[-- Attachment #7: smp-tester.log --]
[-- Type: application/octet-stream, Size: 11741 bytes --]

[-- Attachment #8: userchan-tester.log --]
[-- Type: application/octet-stream, Size: 5490 bytes --]

  reply	other threads:[~2021-08-29 14:02 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-29 13:12 [RFC v2 00/13] create power sequencing subsystem Dmitry Baryshkov
2021-08-29 13:12 ` Dmitry Baryshkov
2021-08-29 13:12 ` [RFC v2 01/13] power: add power sequencer subsystem Dmitry Baryshkov
2021-08-29 13:12   ` Dmitry Baryshkov
2021-08-29 14:02   ` bluez.test.bot [this message]
2021-08-29 15:16   ` kernel test robot
2021-09-10 10:02   ` Ulf Hansson
2021-09-10 10:02     ` Ulf Hansson
2021-09-13 12:32     ` Dmitry Baryshkov
2021-09-13 12:32       ` Dmitry Baryshkov
2021-09-13 13:42       ` Ulf Hansson
2021-09-13 13:42         ` Ulf Hansson
2021-08-29 13:12 ` [RFC v2 02/13] pwrseq: port MMC's pwrseq drivers to new pwrseq subsystem Dmitry Baryshkov
2021-08-29 13:12   ` Dmitry Baryshkov
2021-08-29 13:12 ` [RFC v2 03/13] mmc: core: switch " Dmitry Baryshkov
2021-08-29 13:12   ` Dmitry Baryshkov
2021-08-29 13:12 ` [RFC v2 04/13] pwrseq: add support for QCA BT+WiFi power sequencer Dmitry Baryshkov
2021-08-29 13:12   ` Dmitry Baryshkov
2021-08-30 22:29   ` kernel test robot
2021-08-29 13:12 ` [RFC v2 05/13] pwrseq: add fallback support Dmitry Baryshkov
2021-08-29 13:12   ` Dmitry Baryshkov
2021-08-29 13:12 ` [RFC v2 06/13] pwrseq: pwrseq_qca: implement " Dmitry Baryshkov
2021-08-29 13:12   ` Dmitry Baryshkov
2021-08-29 13:12 ` [RFC v2 07/13] Bluetooth: hci_qca: switch to using pwrseq Dmitry Baryshkov
2021-08-29 13:12   ` Dmitry Baryshkov
2021-08-29 13:13 ` [RFC v2 08/13] ath10k: add support for pwrseq sequencing Dmitry Baryshkov
2021-08-29 13:13   ` Dmitry Baryshkov
2021-08-29 13:13 ` [RFC v2 09/13] arm64: dts: qcom: sdm845-db845c: switch bt+wifi to qca power sequencer Dmitry Baryshkov
2021-08-29 13:13   ` Dmitry Baryshkov
2021-08-29 13:13 ` [RFC v2 10/13] arm64: dts: qcom: qrb5165-rb5: add bluetooth support Dmitry Baryshkov
2021-08-29 13:13   ` Dmitry Baryshkov
2021-08-29 13:13 ` [RFC v2 11/13] arm64: dts: qcom: sdm845-db845c: add second channel to qca power sequencer Dmitry Baryshkov
2021-08-29 13:13   ` Dmitry Baryshkov
2021-08-29 13:13 ` [RFC v2 12/13] WIP: PCI: qcom: use pwrseq to power up bus devices Dmitry Baryshkov
2021-08-29 13:13   ` Dmitry Baryshkov
2021-08-29 13:13 ` [RFC v2 13/13] WIP: arm64: dts: qcom: qrb5165-rb5: add bus-pwrseq property to pcie0 Dmitry Baryshkov
2021-08-29 13:13   ` Dmitry Baryshkov
2021-09-13 23:39 ` [RFC v2 00/13] create power sequencing subsystem Steev Klimaszewski
2021-09-13 23:39   ` Steev Klimaszewski
2021-10-06  3:49   ` Dmitry Baryshkov
2021-10-06  3:49     ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=612b937c.1c69fb81.2476a.ff6f@mx.google.com \
    --to=bluez.test.bot@gmail.com \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.