From: Felipe Contreras <felipe.contreras@gmail.com>
To: Hamza Mahfooz <someguy@effective-light.com>, git@vger.kernel.org
Cc: Hamza Mahfooz <someguy@effective-light.com>
Subject: RE: [PATCH] pretty: colorize pattern matches in commit messages
Date: Wed, 01 Sep 2021 12:17:45 -0500 [thread overview]
Message-ID: <612fb5b96b69a_35b832088a@natae.notmuch> (raw)
In-Reply-To: <20210901121616.2109658-1-someguy@effective-light.com>
Hamza Mahfooz wrote:
> Currently, for example when
>
> git log --grep=pattern
>
> is executed, the outputted commits that are matched by the pattern do not
> have the relevant substring matches highlighted.
>
> Signed-off-by: Hamza Mahfooz <someguy@effective-light.com>
> ---
> pretty.c | 109 +++++++++++++++++++++++++++++++++++++++++++++++++------
Can you add some tests?
--
Felipe Contreras
next prev parent reply other threads:[~2021-09-01 17:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 12:16 [PATCH] pretty: colorize pattern matches in commit messages Hamza Mahfooz
2021-09-01 17:17 ` Felipe Contreras [this message]
2021-09-01 23:26 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2021-09-05 12:05 Hamza Mahfooz
2021-09-05 18:01 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=612fb5b96b69a_35b832088a@natae.notmuch \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=someguy@effective-light.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.