All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
To: Luca Ceresoli <luca.ceresoli@bootlin.com>,
	Mark Brown <broonie@kernel.org>
Cc: kernel@collabora.com, linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: dapm-graph: set fill colour of turned on nodes
Date: Mon, 24 Feb 2025 17:09:36 +0100	[thread overview]
Message-ID: <6130937.lOV4Wx5bFT@workhorse> (raw)
In-Reply-To: <3d15fd23-3756-4a17-a447-b5ccb2c564df@sirena.org.uk>

On Monday, 24 February 2025 16:42:08 Central European Standard Time Mark Brown 
wrote:
> On Mon, Feb 24, 2025 at 04:33:11PM +0100, Luca Ceresoli wrote:
> > Hello Nicolas,
> > 
> > +Cc: Mark Brown
> > 
> > On Fri, 21 Feb 2025 21:39:32 +0100
> > 
> > Nicolas Frattaroli <nicolas.frattaroli@collabora.com> wrote:
> > > Some tools like KGraphViewer interpret the "ON" nodes not having an
> > > explicitly set fill colour as them being entirely black, which obscures
> > > the text on them and looks funny. In fact, I thought they were off for
> > > the longest time. Comparing to the output of the `dot` tool, I assume
> > > they are supposed to be white.
> 
> As documented in submitting-patches.rst please send patches to the
> maintainers for the code you would like to change.  The normal kernel
> workflow is that people apply patches from their inboxes, if they aren't
> copied they are likely to not see the patch at all and it is much more
> difficult to apply patches.

Hi Mark,

I used b4 to submit the patch, which runs get-maintainer when I run b4 prep --
auto-to-cc. You can see that even running get_maintainer manually for this 
file, you're not one of the recipients:

 ./scripts/get_maintainer.pl -f tools/sound/dapm-graph
 Luca Ceresoli <luca.ceresoli@bootlin.com> (maintainer:SOUND - SOC LAYER / 
dapm-graph)
 linux-sound@vger.kernel.org (open list:SOUND - SOC LAYER / dapm-graph)
 linux-kernel@vger.kernel.org (open list)

It looks like you're not listed as a maintainer of this file or a parent tree 
in the MAINTAINERS file, which would explain the discrepancy.

Regards,
Nicolas Frattaroli



  reply	other threads:[~2025-02-24 16:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-21 20:39 [PATCH] ASoC: dapm-graph: set fill colour of turned on nodes Nicolas Frattaroli
2025-02-24 15:33 ` Luca Ceresoli
2025-02-24 15:42   ` Mark Brown
2025-02-24 16:09     ` Nicolas Frattaroli [this message]
2025-02-24 16:21       ` Mark Brown
2025-02-25 13:38 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6130937.lOV4Wx5bFT@workhorse \
    --to=nicolas.frattaroli@collabora.com \
    --cc=broonie@kernel.org \
    --cc=kernel@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=luca.ceresoli@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.