From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, nelio.laranjeiro@6wind.com
Subject: Re: [PATCH] scripts: add check for net driver names without net prefix
Date: Wed, 06 Jul 2016 11:10:48 +0200 [thread overview]
Message-ID: <6142444.k3HLHFvhXo@xps13> (raw)
In-Reply-To: <1467729650-925-1-git-send-email-bruce.richardson@intel.com>
2016-07-05 15:40, Bruce Richardson:
> +# check headline label for net/ prefix if needed
> +bad=$(echo "$headlines" | grep -E --color=always \
> + -e "^($(ls drivers/net | grep -v Makefile | tr '\n' '|')):" \
> + | sed 's,^,\t,')
> +[ -z "$bad" ] || printf "Headline missing 'net/' prefix:\n$bad\n"
This check is definitely a good idea.
We need the same thing for crypto.
Few nits:
- -E is not needed for this regex
- "/base:" cases are not handled because of the colon at the end
of the regex.
- patches touching several drivers are not handled. Examples:
"mlx:" -> "net/mlx:"
"drivers/net:" -> "net:"
By the way, I am looking at an idea, that Nelio sent me, based on
modified files. It can complete this check.
next prev parent reply other threads:[~2016-07-06 9:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 14:40 [PATCH] scripts: add check for net driver names without net prefix Bruce Richardson
2016-07-06 9:10 ` Thomas Monjalon [this message]
2016-07-06 9:25 ` Bruce Richardson
2016-07-06 9:46 ` Thomas Monjalon
2016-07-06 10:28 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6142444.k3HLHFvhXo@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.