From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D551C169C4 for ; Sun, 3 Feb 2019 19:42:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5673C21773 for ; Sun, 3 Feb 2019 19:42:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MsPgRUlO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727807AbfBCTmN (ORCPT ); Sun, 3 Feb 2019 14:42:13 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:38971 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726577AbfBCTmM (ORCPT ); Sun, 3 Feb 2019 14:42:12 -0500 Received: by mail-wm1-f66.google.com with SMTP id y8so11170006wmi.4 for ; Sun, 03 Feb 2019 11:42:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=15PhP6yfgdNDOW0ZFT5aTWRtXSvC7sv6NUGSQPjf7J8=; b=MsPgRUlOqtwIZZV4lUvx3lkAY+mY69LpJMJDlSU68NwgBw6pjyvjwJTfq1BSJF67Y+ p0GHErmXyaJ5Y1y8vpFdMu4f/P7fXumBw3melWXtfT2EamV6YOzb9kGxDdhM5MM8Lo+K bkGKVMCpkwm4fWfcECkTV601OW6wPIFxCNFGB3Voa5Nzx424JEei+ECr0lbujKJZTxCS XB/2NT3TjPw1+f2BwyXOQj3BN0NZLQWv1+nCqQHa6Wq1nqNgSpUosnv09DT0zHxvgMbB T17b/SVXpDpHHz24iCpkly/wZGfn/bGmpe7fpaQG0bCZxTMNxfvo0j/+PhMDw6fWzGwc RZnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=15PhP6yfgdNDOW0ZFT5aTWRtXSvC7sv6NUGSQPjf7J8=; b=bQnohBaBZghnHs/9TVNEV9D6Ng3K6V37j8j8AF4qJrSWybsTh8ulTAnb4ZW9nqLB/k TVWj2j6wl7LTWT66Whhr8GiTZzgrvMPg86cTWO+ZfSUFmzlLKWBrnK7ALMhgQr80K7pD XHl3gMVvgy91Ka/lYpmJc6M1NXYwP81Y+Iaff7eqPS3iV/FvuAPy7ln/spNGbpDgYjvj 8penttN/1X3JzbP1si9VSQc8Kgq+1d6sldb8vd5bOG/przZ/ED3HER/QR50ItXHTq9lG 8QkFgvA7DC7bOcgMGWQ61aswRdCzrQrxeyMCVyTsu0V6PdWjJamSvg7lhpWTyOQ/DUg6 iCbQ== X-Gm-Message-State: AHQUAuZk6iWb0aqRhH3ce0lQGt1V81oFTjFohqPMf+mwyv/oKDWcA1bi baQBuibcjvRPf3MnIUhaHN464WK8 X-Google-Smtp-Source: AHgI3IYyhKDIoFNZBVhmgPe/lcObgOsk3qDFlV7J6e5Y/mQW/8PT2ecOtZZus7aR+YEZf9/E0hBmsw== X-Received: by 2002:a1c:a401:: with SMTP id n1mr11081077wme.101.1549222930730; Sun, 03 Feb 2019 11:42:10 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:b082:4f91:1c1c:ad3? (p200300EA8BF1E200B0824F911C1C0AD3.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:b082:4f91:1c1c:ad3]) by smtp.googlemail.com with ESMTPSA id b12sm5320465wmj.3.2019.02.03.11.42.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 03 Feb 2019 11:42:10 -0800 (PST) Subject: Re: [PATCH 1/4 net-next] net: phy: aquantia: shorten name space prefix to aqr_ To: Andrew Lunn Cc: Florian Fainelli , David Miller , "netdev@vger.kernel.org" References: <08812313-471b-79c2-f667-bace78acf0fe@gmail.com> <20190203193847.GD27045@lunn.ch> From: Heiner Kallweit Message-ID: <614dcb79-e824-ec33-868f-80718138c0be@gmail.com> Date: Sun, 3 Feb 2019 20:42:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <20190203193847.GD27045@lunn.ch> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 03.02.2019 20:38, Andrew Lunn wrote: > On Sun, Feb 03, 2019 at 08:33:13PM +0100, Heiner Kallweit wrote: >> From: Andrew Lunn >> aquantia_ as a name space prefix is rather long, resulting in lots of >> lines needing wrapping, reducing readability. Use the prefix aqr_ >> instead, which fits with the vendor naming there devices aqr107, for >> example. >> >> Signed-off-by: Andrew Lunn > > Hi Heiner > > You need to add your signed-off-by here. Anybody who handles the patch > on its way into the kernel needs to add a SOB. > > Andrew > Each day you learn something new .. I was under the impression that I have to do this in case of changes only. And this patch I forwarded as is. Let me know whether you have other review comments. Then I bundle the changes in a v2. Heiner