From: Thomas Monjalon <thomas@monjalon.net>
To: Jiayu Hu <jiayu.hu@intel.com>
Cc: dev@dpdk.org, Shahaf Shuler <shahafs@mellanox.com>,
"wenzhuo.lu@intel.com" <wenzhuo.lu@intel.com>,
"lei.a.yao@intel.com" <lei.a.yao@intel.com>
Subject: Re: [PATCH] app/testpmd: fix failing to enable SW checksum calculation
Date: Wed, 31 Jan 2018 23:34:06 +0100 [thread overview]
Message-ID: <6151298.L9tu3aqMsX@xps> (raw)
In-Reply-To: <VI1PR05MB3149C2ADA54FF3A77BFADA0AC3E10@VI1PR05MB3149.eurprd05.prod.outlook.com>
25/01/2018 07:54, Shahaf Shuler:
> Hi Jiayu Hu,
>
> Good fix, thanks.
>
> Thursday, January 25, 2018 4:14 AM, Jiayu Hu:
> > In current design, we can't enable SW checksum calculation for the devices
> > which don't have checksum offloading abilities via the command "csum set
> > ip|tcp|udp|sctp|outer-ip sw <port_id>".
> > But SW checksum calculation shouldn't depend on HW offloading abilities.
> > This patch is to fix this issue.
> >
> > Fixes: 3926dd2b6668 ("app/testpmd: enforce offload capabilities check")
> > Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
>
> Reviewed-by: Shahaf Shuler <shahafs@mellanox.com>
Applied, thanks
prev parent reply other threads:[~2018-01-31 22:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-25 2:13 [PATCH] app/testpmd: fix failing to enable SW checksum calculation Jiayu Hu
2018-01-25 2:58 ` Lu, Wenzhuo
2018-01-25 3:04 ` Hu, Jiayu
2018-01-25 3:06 ` Hu, Jiayu
2018-01-25 6:54 ` Shahaf Shuler
2018-01-31 22:34 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6151298.L9tu3aqMsX@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=lei.a.yao@intel.com \
--cc=shahafs@mellanox.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.