From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51078C54ED1 for ; Sat, 28 Jun 2025 07:40:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Message-ID:References:In-Reply-To:Subject:Cc:To:From:Date: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KUeXxBgI+7h5XEjRKpIzjri6sBUGSDAMqhl1PZvOn60=; b=tMix8iJcKi1ZEkA1Uy5UMTeg7z TdXlK6+57jUv16M+vtOf0o7MdHuYM+m0o8BwXbCAuHWFGJk9ZHJSHHydJTgxqn4prkL7CnskLzpP4 M8vE6EH2hlcGSe4De3M2qnfZSho5Gc96W2mHlZU87b+lhpxxy+kzsy9bO4nxqbrdNmWyIbvaQ/3R7 xsnuSE7TCYNWofrWEmVO9pb6+zC8r9aO9+czRSWPs+wqcSmixELYXo+O/3iFZGtKNpn24F9SM58gn X+IEFK4DKx04MMFZREyGMhcFcHnWNwgJKsWKlOCpgx77+SqSAvrimdT47nsogN767HkG1RLMDKrdQ EGo/jmLA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uVQB3-0000000GVzv-4APa; Sat, 28 Jun 2025 07:40:45 +0000 Received: from layka.disroot.org ([178.21.23.139]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uVPqa-0000000GUcL-1kjX for linux-arm-kernel@lists.infradead.org; Sat, 28 Jun 2025 07:19:38 +0000 Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id A586022FBD; Sat, 28 Jun 2025 09:19:33 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 2MsP83fmh9-E; Sat, 28 Jun 2025 09:19:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1751095172; bh=pKfvDVcRcDhp3Z+v2Y4AKpYYPrwP+zM1RXX1clGD2PA=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=AHra/kG8lut6uMn824OiAVCfnpcGcfiwN1zUENBkuttxyKLbi17bOjzAFlRGysU/f GrdMxS4Wu80qL8PMjDpUYie6Ywj/GIL4cJ35JzMQRPPOJC3uphQdv9SROGbPYUIuvb TCaZalOFImycAldXu4ObbHJR4Lqrw5XzTiiPqHytVYfjEDQkgUuUNoJbk8JWgMjtYX wcQ4Zxv2FQ60w/5GNyp9sXm53vK1u1t+BSg05+0uXZv/ZoxUwa3Y6rPL/MSW8HVNEq yAV74Ar8TucIuJ4ouuTNi0VU7u0MyAzr8St595cFuzfax309WRIr0pvk80g695kZTQ nQHr+5NfHceqg== MIME-Version: 1.0 Date: Sat, 28 Jun 2025 07:19:32 +0000 From: Kaustabh Chakraborty To: Rob Herring Cc: Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/6] dt-bindings: soc: samsung: exynos-pmu: allow mipi-phy subnode In-Reply-To: <20250627214258.GA189284-robh@kernel.org> References: <20250627-exynos7870-drm-dts-v2-0-d4a59207390d@disroot.org> <20250627-exynos7870-drm-dts-v2-2-d4a59207390d@disroot.org> <20250627214258.GA189284-robh@kernel.org> Message-ID: <6151f833d5a06369cd3dce5d2b2aca9f@disroot.org> X-Sender: kauschluss@disroot.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250628_001936_865103_619D9637 X-CRM114-Status: GOOD ( 11.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2025-06-27 21:42, Rob Herring wrote: > On Fri, Jun 27, 2025 at 01:43:25AM +0530, Kaustabh Chakraborty wrote: >> Add Exynos7870's PMU compatible to the list of nodes which allow a >> MIPI >> PHY driver. >> >> Signed-off-by: Kaustabh Chakraborty >> --- >> Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git >> a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml >> b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml >> index >> f0fb24156da9b8980dcfd5339ae75f12a71cf6d6..45acd6a03d761a833cec435302e5190fb50f7a23 >> 100644 >> --- a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml >> +++ b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml >> @@ -172,6 +172,7 @@ allOf: >> - samsung,exynos5250-pmu >> - samsung,exynos5420-pmu >> - samsung,exynos5433-pmu >> + - samsung,exynos7870-pmu > > Don't you need to add this to 'compatible' and under 'select'? compatible: [1] samsung,exynos7-pmu is under select. 7870 has a fallback on 7. Do you think samsung,exynos7-pmu should've been added in this patch instead? [1] https://elixir.bootlin.com/linux/v6.16-rc3/source/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml#L56 > >> then: >> properties: >> mipi-phy: true >> >> -- >> 2.49.0 >>