From: Thomas Monjalon <thomas@monjalon.net>
To: drc@linux.vnet.ibm.com
Cc: dev@dpdk.org, stable@dpdk.org, david.marchand@redhat.com,
Thinh Tran <thinhtr@linux.vnet.ibm.com>
Subject: Re: [dpdk-dev] [PATCH v3] eal/ppc64: improve rte_rdtsc() with __ppc_get_timebase()
Date: Fri, 17 Apr 2020 00:35:23 +0200 [thread overview]
Message-ID: <6156306.e8TTKsaY2g@thomas> (raw)
In-Reply-To: <20200325001356.147049-1-thinhtr@linux.vnet.ibm.com>
Any review please?
25/03/2020 01:13, Thinh Tran:
> __ppc_get_timebase() reads and returns the current value of the Time
> Base Register. It's more efficient as it uses the processor’s time
> base facility directly
>
> the DPDK on FreeBSD currently is not supported on Powerpc64, it should
> be safe to include the sys/platform/ppc.h
>
>
> Signed-off-by: Thinh Tran <thinhtr@linux.vnet.ibm.com>
> ---
> .../common/include/arch/ppc_64/rte_cycles.h | 28 ++-----------------
> 1 file changed, 2 insertions(+), 26 deletions(-)
>
> diff --git a/lib/librte_eal/common/include/arch/ppc_64/rte_cycles.h b/lib/librte_eal/common/include/arch/ppc_64/rte_cycles.h
> index 8f2e98642..871f9b6e4 100644
> --- a/lib/librte_eal/common/include/arch/ppc_64/rte_cycles.h
> +++ b/lib/librte_eal/common/include/arch/ppc_64/rte_cycles.h
> @@ -14,6 +14,7 @@ extern "C" {
>
> #include <rte_byteorder.h>
> #include <rte_common.h>
> +#include <sys/platform/ppc.h>
>
> /**
> * Read the time base register.
> @@ -24,32 +25,7 @@ extern "C" {
> static inline uint64_t
> rte_rdtsc(void)
> {
> - union {
> - uint64_t tsc_64;
> - RTE_STD_C11
> - struct {
> -#if RTE_BYTE_ORDER == RTE_BIG_ENDIAN
> - uint32_t hi_32;
> - uint32_t lo_32;
> -#else
> - uint32_t lo_32;
> - uint32_t hi_32;
> -#endif
> - };
> - } tsc;
> - uint32_t tmp;
> -
> - asm volatile(
> - "0:\n"
> - "mftbu %[hi32]\n"
> - "mftb %[lo32]\n"
> - "mftbu %[tmp]\n"
> - "cmpw %[tmp],%[hi32]\n"
> - "bne 0b\n"
> - : [hi32] "=r"(tsc.hi_32), [lo32] "=r"(tsc.lo_32),
> - [tmp] "=r"(tmp)
> - );
> - return tsc.tsc_64;
> + return __ppc_get_timebase();
> }
>
> static inline uint64_t
next prev parent reply other threads:[~2020-04-16 22:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 0:13 [dpdk-dev] [PATCH v3] eal/ppc64: improve rte_rdtsc() with __ppc_get_timebase() Thinh Tran
2020-04-16 22:35 ` Thomas Monjalon [this message]
2020-04-20 16:42 ` David Christensen
2020-04-21 16:17 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6156306.e8TTKsaY2g@thomas \
--to=thomas@monjalon.net \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=stable@dpdk.org \
--cc=thinhtr@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.