From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 259FEC54E4A for ; Fri, 8 Mar 2024 08:22:16 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 67B218801A; Fri, 8 Mar 2024 09:22:14 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="PQElCb4H"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B5DA48801E; Fri, 8 Mar 2024 09:22:13 +0100 (CET) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3C78A87666 for ; Fri, 8 Mar 2024 09:22:11 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rogerq@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 01AA061CF1; Fri, 8 Mar 2024 08:22:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D46CC433C7; Fri, 8 Mar 2024 08:22:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709886128; bh=4Q+btWmsty/+BRBQ+qjKcIjRFvGN/K411w2iZhyt9jg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=PQElCb4Hlr7p/GEI61YYHLagLl0+iGy5qYNVFbNYt1GqlqQKoXCnodp9B+egG0ngr OfKebP6Sku5Na4Uui71S2+r/S19ZJwhC+QXLrNh3Ve1JBvL2u/1uAc2mSGpwr6nQMQ 3g4hkeMQoQJ3/PZsJjbyp9CJb9ErPVcZT36kRDvqMId+2iPHsrJ21hfkprzExUzmA2 AsgfXVsRBvsoQE7e2727YohJZAUFao3we3npn8YDPxmqRb7TTgPINikQFzNl4KRVpL e3B3/3x5OzaNGNikCgjHz1wb2J4E72uZvDC14p0FYfVxwavX0PyMFLZh6eN1WhJh+5 EQppgOwZP/7oA== Message-ID: <615aa2aa-6d02-439b-a091-1bc8fc38495f@kernel.org> Date: Fri, 8 Mar 2024 10:22:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/5] net: mdio-uclass: probe generic Ethernet PHY driver & Fix Beagleplay Ethernet Content-Language: en-US To: Joe Hershberger , Ramon Fried , Tom Rini , Nishanth Menon , Robert Nelson , Wadim Egorov , Marcel Ziswiler , Simon Glass Cc: srk@ti.com, s-vadapalli@ti.com, vigneshr@ti.com, r-gunasekaran@ti.com, danishanwar@ti.com, u-boot@lists.denx.de References: <20240305-for-2024-07-beagleplay-eth-v1-0-e1294a575cc1@kernel.org> From: Roger Quadros In-Reply-To: <20240305-for-2024-07-beagleplay-eth-v1-0-e1294a575cc1@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 05/03/2024 15:24, Roger Quadros wrote: > Currently, the GPIO Reset Device Tree properties of the > PHY node are ignored when the PHY is probed via mdio-uclass driver [1]. > > To resolve this, for each child of the MDIO bus node, bind and probe > the generic Ethernet PHY driver if CONFIG_DM_ETH_PHY is enabled. > > This should now show the generic_phy_driver in "dm tree" > and also apply the GPIO reset before the MDIO bus driver scans the bus > for the PHYs. > > ethernet 0 [ + ] am65_cpsw_nuss_port | |-- ethernet@8000000port@1 > bootdev 3 [ ] eth_bootdev | | `-- port@1.bootdev > mdio 0 [ + ] cpsw_mdio | `-- mdio@f00 > eth_phy_ge 0 [ + ] eth_phy_generic_drv | |-- ethernet-phy@0 > eth_phy_ge 1 [ + ] eth_phy_generic_drv | `-- ethernet-phy@1 > > To test this on Beagleplay, the following series is required > > [1] Switch am65-cpsw to DM MDIO > https://lore.kernel.org/all/20240228-for-2024-07-am65-cpsw-mdio-v2-0-f74f972eafeb@kernel.org/ > > The last 3 patches are marked [not-for-merge]. They are to show how the > whole solution can work to fix Ethernet on Beagleplay, which has been broken > so far. Those DT patches will be sent once the device tree changes are merged > into Linux tree. > > Signed-off-by: Roger Quadros Some CI tests failed. I will fix and send v2. https://github.com/u-boot/u-boot/pull/495 > --- > Roger Quadros (5): > net: mdio-uclass: Bind and probe generic Ethernet PHY driver > configs/am62x_beagleplay_a53_defconfig: enable DM_ETH_PHY > [not-for-merge] arm: dts: k3-am62*: sync with linux-next-20240229 > [not-for-merge] k3-am625-beagleplay-u-boot: get CPSW Ethernet to work > [not-for-merge] arm: dts: k3-am625-beagleplay: Fix Ethernet PHY reset GPIO > > arch/arm/dts/k3-am62-main.dtsi | 126 ++++++++++++++--- > arch/arm/dts/k3-am62-mcu.dtsi | 4 +- > arch/arm/dts/k3-am62-phycore-som.dtsi | 5 +- > arch/arm/dts/k3-am62-thermal.dtsi | 5 +- > arch/arm/dts/k3-am62-verdin-dev.dtsi | 4 +- > arch/arm/dts/k3-am62-verdin-wifi.dtsi | 1 - > arch/arm/dts/k3-am62-verdin.dtsi | 76 +++++++--- > arch/arm/dts/k3-am62-wakeup.dtsi | 38 +++-- > arch/arm/dts/k3-am62.dtsi | 4 +- > arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 63 +++++++++ > arch/arm/dts/k3-am625-beagleplay.dts | 66 ++++----- > arch/arm/dts/k3-am625-phyboard-lyra-rdk.dts | 104 +++++++++++++- > arch/arm/dts/k3-am625-sk.dts | 4 +- > arch/arm/dts/k3-am625.dtsi | 4 +- > arch/arm/dts/k3-am62a-main.dtsi | 201 +++++++++++++++++++++++++-- > arch/arm/dts/k3-am62a-mcu.dtsi | 4 +- > arch/arm/dts/k3-am62a-thermal.dtsi | 5 +- > arch/arm/dts/k3-am62a-wakeup.dtsi | 4 +- > arch/arm/dts/k3-am62a.dtsi | 4 +- > arch/arm/dts/k3-am62a7-sk.dts | 162 ++++++++++++++++++++- > arch/arm/dts/k3-am62a7.dtsi | 4 +- > arch/arm/dts/k3-am62x-sk-common.dtsi | 24 +++- > configs/am62x_beagleplay_a53_defconfig | 2 +- > net/mdio-uclass.c | 41 ++++++ > 24 files changed, 825 insertions(+), 130 deletions(-) > --- > base-commit: 84f5bb0be0ec9fbf98f8f3317b578dfc114cf44e > change-id: 20240305-for-2024-07-beagleplay-eth-f82a51197937 > > Best regards, -- cheers, -roger