From: Thomas Monjalon <thomas@monjalon.net>
To: Santosh Shukla <santosh.shukla@caviumnetworks.com>
Cc: dev@dpdk.org, olivier.matz@6wind.com,
jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com
Subject: Re: [PATCH v1 1/2] mempool/octeontx: move mbox from event to mempool
Date: Mon, 23 Oct 2017 16:50:27 +0200 [thread overview]
Message-ID: <6160278.vMk2a8irLz@xps> (raw)
In-Reply-To: <20171016134247.5431-1-santosh.shukla@caviumnetworks.com>
16/10/2017 15:42, Santosh Shukla:
> Octeontx mempool pmd need mailbox for pool setup.
> That mailbox was defined at drivers/event/octeontx.
> So mempool has dependency on event/octeontx driver and
> commit:8700239f7767 has added make rule which makes sure event/*
> get build before mempool, but this rule introduces
> cyclic dependency and may create problem to future
> feature addition in drivers/Makefile.
>
> Same problem noticed and reported in below thread:
> http://dpdk.org/ml/archives/dev/2017-October/079187.html
>
> The patch solves problem by moving mbox definition from
> drivers/event/octeontx to drivers/mempool/octeontx.
> Moving mbox files involves below changes:
>
> * Renamed ssovf_mbox.[ch] --> octeontx_mbox.[ch]
> * Renamed ssovf_probe.c --> octeontx_ssovf.c
> * Introduced pool logger file.
> * Moved API from rte_pmd_octeontx_ssovf_version.map to
> rte_mempool_octeontx_version.map.
> * Respective Makefile changes done in
> drivers/event/octeontx/Makefile and drivers/mempool/octeontx/Makefile.
>
> Fixes: 8700239f7767 ("mempool/octeontx: add build and log infrastructure")
>
> Reported-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
There is a 32-bit compilation issues:
- fpavf_log_dbg("buffer exist in pool cnt %ld\n", cnt);
+ fpavf_log_dbg("buffer exist in pool cnt %" PRId64 "\n", cnt);
Fixed when applying
prev parent reply other threads:[~2017-10-23 14:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 13:42 [PATCH v1 1/2] mempool/octeontx: move mbox from event to mempool Santosh Shukla
2017-10-16 13:42 ` [PATCH v1 2/2] event/octeontx: bump library version Santosh Shukla
2017-10-17 9:50 ` Hemant Agrawal
2017-10-23 14:38 ` Thomas Monjalon
2017-10-17 9:49 ` [PATCH v1 1/2] mempool/octeontx: move mbox from event to mempool Hemant Agrawal
2017-10-21 9:51 ` Jerin Jacob
2017-10-18 4:46 ` Pavan Nikhilesh Bhagavatula
2017-10-23 14:50 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6160278.vMk2a8irLz@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=olivier.matz@6wind.com \
--cc=santosh.shukla@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.