From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 959B6C54EDA for ; Fri, 23 May 2025 17:23:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YyZd0V/FHHWykpkrZ9V+C+BRfQMkpFGGPMdVwDTIjwM=; b=UcgzPO6xkSyfU5 iAaX5uuUCW1eGBbCoHEB1PR0bSMiZ8N00NoMAqsGPoiKbAxUU3T+hvvM8JvC/UhElzXfv3cjskuM0 f5PZho0xfMhziNdVFF9SPnpHaWMRqlg6kE629eswjX2UfoRsHLSNkLyFfYfQzRd1r76msBMj/s28/ hii+Ngwk53wO7qxniP9+5J+VHvlusISOVwwB4lgJABTykQJoUgcwJTS2F491LfYYcS2sbKImT6gNJ da01CYCMhZQjxtagbICMjOv32oNPNAYEWTN9U5In2P/i42fwvjHDnkaVfw7KAQovUp8cai9w5eJA2 7pv2SXEwj91mFgeqwEZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uIW7Z-00000004X1p-1DXZ; Fri, 23 May 2025 17:23:49 +0000 Received: from out-174.mta1.migadu.com ([2001:41d0:203:375::ae]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uIW0U-00000004VlD-1zh6; Fri, 23 May 2025 17:16:32 +0000 Message-ID: <61627296-6f94-45ea-9410-ed0ea2251870@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1748020578; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NwSnBgPFez8PLTovNHh7DO/HqAHVQL0w4mtppSLYja0=; b=p4ygCmn0/SgSUw/j+FUlcInOw5bcP3qQpAP+WTRtVHCq8zqDVxfsG3vreS7WCBAJhRjcTY CNS0wuI2Zor/NqLA6i4HP+ByVNwTy/KZWyPRvH4hhejZLNvTG/9jo7xnLQXl37V2+/wL9Q eok6kr9D3cEhlTaruAu9Wmz5VZIJWYI= Date: Fri, 23 May 2025 10:16:11 -0700 MIME-Version: 1.0 Subject: Re: [PATCH v3 9/9] RISC-V: KVM: Upgrade the supported SBI version to 3.0 To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Anup Patel , Will Deacon , Mark Rutland , Paul Walmsley , Palmer Dabbelt , Mayuresh Chitale Cc: linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Palmer Dabbelt , kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv References: <20250522-pmu_event_info-v3-0-f7bba7fd9cfe@rivosinc.com> <20250522-pmu_event_info-v3-9-f7bba7fd9cfe@rivosinc.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Atish Patra In-Reply-To: X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250523_101630_641527_0C89884E X-CRM114-Status: GOOD ( 12.42 ) X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+kvm-riscv=archiver.kernel.org@lists.infradead.org Ck9uIDUvMjMvMjUgNjozMSBBTSwgUmFkaW0gS3LEjW3DocWZIHdyb3RlOgo+IDIwMjUtMDUtMjJU MTI6MDM6NDMtMDc6MDAsIEF0aXNoIFBhdHJhIDxhdGlzaHBAcml2b3NpbmMuY29tPjoKPj4gVXBn cmFkZSB0aGUgU0JJIHZlcnNpb24gdG8gdjMuMCBzbyB0aGF0IGNvcnJlc3BvbmRpbmcgZmVhdHVy ZXMKPj4gY2FuIGJlIGVuYWJsZWQgaW4gdGhlIGd1ZXN0Lgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBB dGlzaCBQYXRyYSA8YXRpc2hwQHJpdm9zaW5jLmNvbT4KPj4gLS0tCj4+IGRpZmYgLS1naXQgYS9h cmNoL3Jpc2N2L2luY2x1ZGUvYXNtL2t2bV92Y3B1X3NiaS5oIGIvYXJjaC9yaXNjdi9pbmNsdWRl L2FzbS9rdm1fdmNwdV9zYmkuaAo+PiAtI2RlZmluZSBLVk1fU0JJX1ZFUlNJT05fTUFKT1IgMgo+ PiArI2RlZmluZSBLVk1fU0JJX1ZFUlNJT05fTUFKT1IgMwo+IEkgdGhpbmsgaXQncyB0aW1lIHRv IGFkZCB2ZXJzaW9uaW5nIHRvIEtWTSBTQkkgaW1wbGVtZW50YXRpb24uCj4gVXNlcnNwYWNlIHNo b3VsZCBiZSBhYmxlIHRvIHNlbGVjdCB0aGUgZGVzaXJlZCBTQkkgdmVyc2lvbiBhbmQgS1ZNIHdv dWxkCj4gdGVsbCB0aGUgZ3Vlc3QgdGhhdCBuZXdlciBmZWF0dXJlcyBhcmUgbm90IHN1cHBvcnRl ZC4KCldlIGNhbiBhY2hpZXZlIHRoYXQgdGhyb3VnaCBvbmVyZWcgaW50ZXJmYWNlIGJ5IGRpc2Fi bGluZyBpbmRpdmlkdWFsIFNCSSAKZXh0ZW5zaW9ucy4KV2UgY2FuIGV4dGVuZCB0aGUgZXhpc3Rp bmcgb25lcmVnIGludGVyZmFjZSB0byBkaXNhYmxlIGEgc3BlY2lmaWMgU0JJIAp2ZXJzaW9uIGRp cmVjdGx5Cmluc3RlYWQgb2YgaW5kaXZpZHVhbCBvbmVzIHRvIHNhdmUgdGhvc2UgSU9DVEwgYXMg d2VsbC4KCj4gV2UgY291bGQgc29tZXdoYXQgZ2V0IGF3YXkgd2l0aCB0aGUgdXNlcnNwYWNlX3Ni aSBwYXRjaCBJIHBvc3RlZCwKPiBiZWNhdXNlIHVzZXJzcGFjZSB3b3VsZCBhdCBsZWFzdCBiZSBp biBjb250cm9sIG9mIHRoZSBTQkkgdmVyc2lvbiwgYnV0Cj4gaXQgd291bGQgc3RpbGwgYmUgaW5j b3JyZWN0IHdpdGhvdXQgYSBLVk0gZW5mb3JjZW1lbnQsIGJlY2F1c2UgYQo+IG1pc2JlaGF2aW5n IGd1ZXN0IGNvdWxkIHVzZSBmZWF0dXJlcyB0aGF0IHNob3VsZCBub3QgYmUgc3VwcG9ydGVkLgoK LS0gCmt2bS1yaXNjdiBtYWlsaW5nIGxpc3QKa3ZtLXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcK aHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9rdm0tcmlzY3YK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-171.mta1.migadu.com (out-171.mta1.migadu.com [95.215.58.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2163E20C489 for ; Fri, 23 May 2025 17:16:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748020584; cv=none; b=rkGzwuLdHGuRaW2Bd9yd7VCxkRprmwmGcoA5jRFXZ7Wh9fAxNR8MVuOD6cpMzK0ekgPjsEWbYYs4aO6hwXEmjKGYsK4/pQDRSvsus5eEh2sneRTrhHGxqDoTe23NAzUH+g2FWpGdxPhKLcKkKsrWT/pPVtP6zh00vRKcYfE/CAI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748020584; c=relaxed/simple; bh=Drp5lZRk4LA7SqjWH3KK6QjUHA5tD8wxZElSKSZPax4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Z0Q7oAppbqDp3ZkHxH5hTcwai1VwvY6A/uUNF2E+07oXLxNeuxT9B2ppPYQIaxqtk5twzwuf2KxvWD781hQxWDeU7snfZne5Y97JQmJyvlXk9AmlXVRXRmAUr6s+loNULzid3bO85dXAa/2qD5oaONXSo5oVMTicz74GOdQ0QXY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=p4ygCmn0; arc=none smtp.client-ip=95.215.58.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="p4ygCmn0" Message-ID: <61627296-6f94-45ea-9410-ed0ea2251870@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1748020578; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NwSnBgPFez8PLTovNHh7DO/HqAHVQL0w4mtppSLYja0=; b=p4ygCmn0/SgSUw/j+FUlcInOw5bcP3qQpAP+WTRtVHCq8zqDVxfsG3vreS7WCBAJhRjcTY CNS0wuI2Zor/NqLA6i4HP+ByVNwTy/KZWyPRvH4hhejZLNvTG/9jo7xnLQXl37V2+/wL9Q eok6kr9D3cEhlTaruAu9Wmz5VZIJWYI= Date: Fri, 23 May 2025 10:16:11 -0700 Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v3 9/9] RISC-V: KVM: Upgrade the supported SBI version to 3.0 To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Anup Patel , Will Deacon , Mark Rutland , Paul Walmsley , Palmer Dabbelt , Mayuresh Chitale Cc: linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Palmer Dabbelt , kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv References: <20250522-pmu_event_info-v3-0-f7bba7fd9cfe@rivosinc.com> <20250522-pmu_event_info-v3-9-f7bba7fd9cfe@rivosinc.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Atish Patra In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT On 5/23/25 6:31 AM, Radim Krčmář wrote: > 2025-05-22T12:03:43-07:00, Atish Patra : >> Upgrade the SBI version to v3.0 so that corresponding features >> can be enabled in the guest. >> >> Signed-off-by: Atish Patra >> --- >> diff --git a/arch/riscv/include/asm/kvm_vcpu_sbi.h b/arch/riscv/include/asm/kvm_vcpu_sbi.h >> -#define KVM_SBI_VERSION_MAJOR 2 >> +#define KVM_SBI_VERSION_MAJOR 3 > I think it's time to add versioning to KVM SBI implementation. > Userspace should be able to select the desired SBI version and KVM would > tell the guest that newer features are not supported. We can achieve that through onereg interface by disabling individual SBI extensions. We can extend the existing onereg interface to disable a specific SBI version directly instead of individual ones to save those IOCTL as well. > We could somewhat get away with the userspace_sbi patch I posted, > because userspace would at least be in control of the SBI version, but > it would still be incorrect without a KVM enforcement, because a > misbehaving guest could use features that should not be supported. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1DE4C54EDA for ; Fri, 23 May 2025 17:23:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=D4jkGN56xuLykfqLpx1pF1PMYsmcxT1qcjq5gjGvsE4=; b=2Ei2KFav2r9bO3 Rgd6AJlgxzhlFLy75iMO4l1a54rWghY7SvILy5fHgYTQbvWi2ePp/HvpfO1aoqiZqXSBxHt+4GEp+ skznMUtrk8HODLwgnxED4NAg8EYTJG+QcuNiPgj0B/pAtZkwAnuv92CZeZirz098CJYhE72sV9WfK CvV+RrZV3tc9uWJ1fDCp2lWxfmpRMfEL2YIcpj1DQSyjUrOyusnQtra98uWVqzaSKS3Alhmfgue9u Y3bijY15qqWPhI19HWPljG4XEHQucobV+SULrr9qWA7WbDoOGmQ1diguTHJLpZ5KxgOjzZx0/Nzot 2EN28bwbYndhaJc7tF4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uIW7X-00000004WyO-0DZj; Fri, 23 May 2025 17:23:47 +0000 Received: from out-172.mta1.migadu.com ([95.215.58.172]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uIW0L-00000004Vke-1OaI for linux-riscv@lists.infradead.org; Fri, 23 May 2025 17:16:22 +0000 Message-ID: <61627296-6f94-45ea-9410-ed0ea2251870@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1748020578; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NwSnBgPFez8PLTovNHh7DO/HqAHVQL0w4mtppSLYja0=; b=p4ygCmn0/SgSUw/j+FUlcInOw5bcP3qQpAP+WTRtVHCq8zqDVxfsG3vreS7WCBAJhRjcTY CNS0wuI2Zor/NqLA6i4HP+ByVNwTy/KZWyPRvH4hhejZLNvTG/9jo7xnLQXl37V2+/wL9Q eok6kr9D3cEhlTaruAu9Wmz5VZIJWYI= Date: Fri, 23 May 2025 10:16:11 -0700 MIME-Version: 1.0 Subject: Re: [PATCH v3 9/9] RISC-V: KVM: Upgrade the supported SBI version to 3.0 To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Anup Patel , Will Deacon , Mark Rutland , Paul Walmsley , Palmer Dabbelt , Mayuresh Chitale Cc: linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Palmer Dabbelt , kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv References: <20250522-pmu_event_info-v3-0-f7bba7fd9cfe@rivosinc.com> <20250522-pmu_event_info-v3-9-f7bba7fd9cfe@rivosinc.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Atish Patra In-Reply-To: X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250523_101621_514100_6D542A78 X-CRM114-Status: GOOD ( 12.45 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Ck9uIDUvMjMvMjUgNjozMSBBTSwgUmFkaW0gS3LEjW3DocWZIHdyb3RlOgo+IDIwMjUtMDUtMjJU MTI6MDM6NDMtMDc6MDAsIEF0aXNoIFBhdHJhIDxhdGlzaHBAcml2b3NpbmMuY29tPjoKPj4gVXBn cmFkZSB0aGUgU0JJIHZlcnNpb24gdG8gdjMuMCBzbyB0aGF0IGNvcnJlc3BvbmRpbmcgZmVhdHVy ZXMKPj4gY2FuIGJlIGVuYWJsZWQgaW4gdGhlIGd1ZXN0Lgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBB dGlzaCBQYXRyYSA8YXRpc2hwQHJpdm9zaW5jLmNvbT4KPj4gLS0tCj4+IGRpZmYgLS1naXQgYS9h cmNoL3Jpc2N2L2luY2x1ZGUvYXNtL2t2bV92Y3B1X3NiaS5oIGIvYXJjaC9yaXNjdi9pbmNsdWRl L2FzbS9rdm1fdmNwdV9zYmkuaAo+PiAtI2RlZmluZSBLVk1fU0JJX1ZFUlNJT05fTUFKT1IgMgo+ PiArI2RlZmluZSBLVk1fU0JJX1ZFUlNJT05fTUFKT1IgMwo+IEkgdGhpbmsgaXQncyB0aW1lIHRv IGFkZCB2ZXJzaW9uaW5nIHRvIEtWTSBTQkkgaW1wbGVtZW50YXRpb24uCj4gVXNlcnNwYWNlIHNo b3VsZCBiZSBhYmxlIHRvIHNlbGVjdCB0aGUgZGVzaXJlZCBTQkkgdmVyc2lvbiBhbmQgS1ZNIHdv dWxkCj4gdGVsbCB0aGUgZ3Vlc3QgdGhhdCBuZXdlciBmZWF0dXJlcyBhcmUgbm90IHN1cHBvcnRl ZC4KCldlIGNhbiBhY2hpZXZlIHRoYXQgdGhyb3VnaCBvbmVyZWcgaW50ZXJmYWNlIGJ5IGRpc2Fi bGluZyBpbmRpdmlkdWFsIFNCSSAKZXh0ZW5zaW9ucy4KV2UgY2FuIGV4dGVuZCB0aGUgZXhpc3Rp bmcgb25lcmVnIGludGVyZmFjZSB0byBkaXNhYmxlIGEgc3BlY2lmaWMgU0JJIAp2ZXJzaW9uIGRp cmVjdGx5Cmluc3RlYWQgb2YgaW5kaXZpZHVhbCBvbmVzIHRvIHNhdmUgdGhvc2UgSU9DVEwgYXMg d2VsbC4KCj4gV2UgY291bGQgc29tZXdoYXQgZ2V0IGF3YXkgd2l0aCB0aGUgdXNlcnNwYWNlX3Ni aSBwYXRjaCBJIHBvc3RlZCwKPiBiZWNhdXNlIHVzZXJzcGFjZSB3b3VsZCBhdCBsZWFzdCBiZSBp biBjb250cm9sIG9mIHRoZSBTQkkgdmVyc2lvbiwgYnV0Cj4gaXQgd291bGQgc3RpbGwgYmUgaW5j b3JyZWN0IHdpdGhvdXQgYSBLVk0gZW5mb3JjZW1lbnQsIGJlY2F1c2UgYQo+IG1pc2JlaGF2aW5n IGd1ZXN0IGNvdWxkIHVzZSBmZWF0dXJlcyB0aGF0IHNob3VsZCBub3QgYmUgc3VwcG9ydGVkLgoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtcmlz Y3YgbWFpbGluZyBsaXN0CmxpbnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yaXNjdgo=