All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Qi.Chen@windriver.com
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-webserver][PATCH] webmin: fix failures in do_install task
Date: Tue, 03 Dec 2013 10:19:50 +0000	[thread overview]
Message-ID: <6163089.YiV9QuLgku@helios> (raw)
In-Reply-To: <1385087849-30272-1-git-send-email-Qi.Chen@windriver.com>

Hi Qi,

On Friday 22 November 2013 10:37:29 Qi.Chen@windriver.com wrote:
> -    export perl=perl
> +    export perl=${OECMAKE_PERLNATIVE_DIR}/perl

I'm afraid I don't like the look of this - OECMAKE_PERLNATIVE_DIR is set for 
use by cmake, and perlnative.bbclass should be putting our perl binary into 
PATH so it should be run anyway. Is this change actually necessary?

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre


  reply	other threads:[~2013-12-03 10:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-22  2:37 [meta-webserver][PATCH] webmin: fix failures in do_install task Qi.Chen
2013-12-03 10:19 ` Paul Eggleton [this message]
2013-12-03 10:45   ` ChenQi
2013-12-03 11:02     ` Paul Eggleton
2013-12-05  6:51       ` ChenQi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6163089.YiV9QuLgku@helios \
    --to=paul.eggleton@linux.intel.com \
    --cc=Qi.Chen@windriver.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.