From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0602DC25B79 for ; Thu, 16 May 2024 06:51:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 18A2F10E5F8; Thu, 16 May 2024 06:51:33 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=tq-group.com header.i=@tq-group.com header.b="hKs+tOtl"; dkim=fail reason="key not found in DNS" (0-bit key; unprotected) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b="Vh7qsaG3"; dkim-atps=neutral Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3F53310E528 for ; Thu, 16 May 2024 06:51:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1715842290; x=1747378290; h=from:to:cc:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding:subject; bh=wypPkETSMzloynFY9QRrO7afEaLRn3kz2/FH+zTewd0=; b=hKs+tOtlpNbCHHWeBhiMMwEzIdX4NoswbcPdTh/otK1ckr7jPBd5u6Pj KlZOGfqXPXleeND/Z2rlS1LLezoCnrLWa/HBOCeyPWwXOan4ufzcsvoVM vAuZOtdeWFx7m3gHecWel9YHkkgE4BnmupslacGDSUMy4W0h1ygcIHI1x Idg0oIGFnD4eP+6rXewXGsmO+1uqr0EU4RyXJocJqIQD6YeVbuSz41ljC a7o09XdbFTSSAc0OLNcwu7KrakFHEm8j7WjHBPi1Ilw4qZJEccmDAoufh z+Ztn4N8v5DbXSdi9tGiCCxUQaQHVxnoiKCD3PuBj3FAz7GZuiHX82TCi Q==; X-CSE-ConnectionGUID: Fi16EZj4R4eOFvjGa0vOJQ== X-CSE-MsgGUID: jddtXH5uTIWpvNSoBfMcjA== X-IronPort-AV: E=Sophos;i="6.08,163,1712613600"; d="scan'208";a="36927601" Subject: Re: [PATCH 1/2] drm: bridge: samsung-dsim: Initialize bridge on attach Received: from vmailcow01.tq-net.de ([10.150.86.48]) by mx1.tq-group.com with ESMTP; 16 May 2024 08:51:28 +0200 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 476E4170900; Thu, 16 May 2024 08:51:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ew.tq-group.com; s=dkim; t=1715842284; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=wypPkETSMzloynFY9QRrO7afEaLRn3kz2/FH+zTewd0=; b=Vh7qsaG3hPsU+NgwCis83thPoH3lZKaQBLXXN64a+T9S8NTDcVVc2fVwSFuWuTcGiMJll5 1BkxKskkDNHuHZHQcRDylLaF1MWmtzeie28CGtaQbq2Ncmttsnl00Dsu88tTyaXoC6qKuu afS1WEEprMKOV2rrz146lFh0lqABH5qJyCComaZgBfPGq0tLbC6vrSbgVh62trTo4dFPJD Cr5S1aZTFWEiKw78wqiEP8zMIYeIXKWgCsv1QTFpidmPE9imzBvw3IH2/NUlLqn75i8ZW6 Tm2ueGRpH4Fo34wcuKmt1s5u0HUWJCTocPz+aVZtuDFjKnLSikt4defwXjVVMA== From: Alexander Stein To: dri-devel@lists.freedesktop.org, Marek Vasut Cc: Marek Vasut , Adam Ford , Andrzej Hajda , Daniel Vetter , David Airlie , Frieder Schrempf , Inki Dae , Jagan Teki , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Lucas Stach , Maarten Lankhorst , Marek Szyprowski , Maxime Ripard , Michael Walle , Neil Armstrong , Robert Foss , Thomas Zimmermann , kernel@dh-electronics.com Date: Thu, 16 May 2024 08:51:25 +0200 Message-ID: <6163202.ElGaqSPkdT@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20240513021849.129136-1-marex@denx.de> References: <20240513021849.129136-1-marex@denx.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-Last-TLS-Session-Version: TLSv1.3 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Marek, thanks for the patch. Am Montag, 13. Mai 2024, 04:16:27 CEST schrieb Marek Vasut: > Initialize the bridge on attach already, to force lanes into LP11 > state, since attach does trigger attach of downstream bridges which > may trigger (e)DP AUX channel mode read. >=20 > This fixes a corner case where DSIM with TC9595 attached to it fails > to operate the DP AUX channel, because the TC9595 enters some debug > mode when it is released from reset without lanes in LP11 mode. By > ensuring the DSIM lanes are in LP11, the TC9595 (tc358767.c driver) > can be reset in its attach callback called from DSIM attach callback, > and recovered out of the debug mode just before TC9595 performs first > AUX channel access later in its attach callback. >=20 > Signed-off-by: Marek Vasut > --- > Cc: Adam Ford > Cc: Alexander Stein > Cc: Andrzej Hajda > Cc: Daniel Vetter > Cc: David Airlie > Cc: Frieder Schrempf > Cc: Inki Dae > Cc: Jagan Teki > Cc: Jernej Skrabec > Cc: Jonas Karlman > Cc: Laurent Pinchart > Cc: Lucas Stach > Cc: Maarten Lankhorst > Cc: Marek Szyprowski > Cc: Maxime Ripard > Cc: Michael Walle > Cc: Neil Armstrong > Cc: Robert Foss > Cc: Thomas Zimmermann > Cc: dri-devel@lists.freedesktop.org > Cc: kernel@dh-electronics.com > --- > drivers/gpu/drm/bridge/samsung-dsim.c | 16 ++++++++++++++-- > 1 file changed, 14 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/brid= ge/samsung-dsim.c > index 95fedc68b0ae5..56093fc3d62cc 100644 > --- a/drivers/gpu/drm/bridge/samsung-dsim.c > +++ b/drivers/gpu/drm/bridge/samsung-dsim.c > @@ -1622,9 +1622,21 @@ static int samsung_dsim_attach(struct drm_bridge *= bridge, > enum drm_bridge_attach_flags flags) > { > struct samsung_dsim *dsi =3D bridge_to_dsi(bridge); > + int ret; > + > + ret =3D pm_runtime_resume_and_get(dsi->dev); > + if (ret < 0) > + return ret; > =20 > - return drm_bridge_attach(bridge->encoder, dsi->out_bridge, bridge, > - flags); > + ret =3D samsung_dsim_init(dsi); > + if (ret < 0) > + goto err; > + > + ret =3D drm_bridge_attach(bridge->encoder, dsi->out_bridge, bridge, > + flags); > +err: > + pm_runtime_put_sync(dsi->dev); > + return ret; > } > =20 > static const struct drm_bridge_funcs samsung_dsim_bridge_funcs =3D { >=20 It seems the right thing to do. But if 'samsung,burst-clock-frequency' is not specified for DSIM I get a DSI PLL configuration failure. There is no mode yet, thus samsung_dsim_enable_clock() tries to configure the PLL for 0Hz. There is another reconfiguration while pre_enabling the chain targeting the correct clock (891000000Hz for 1920x1080), so this seems fine. But I'm not sure if the 1st config error has any negative side effects. Best regards, Alexander =2D-=20 TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/