Re: [PATCH v4 03/10] lib/igt_drm_netlink: Introduce DRM RAS Netlink interface library

["Tauro, Riana" <riana.tauro@intel.com>]

On 10-09-2026 11:47, Purkait, Soham wrote:
> Hi Ravi,
>
> On 03-09-2026 13:03, Ravi Kishore Koppuravuri wrote:
>> Introduce an IGT library for communicating with DRM RAS Generic Netlink
>> interface. Add helpers for Generic Netlink socket initialization and
>> cleanup.
>>
>> Cc: Purkait Soham <soham.purkait@intel.com>
>> Cc: Riana Tauro <riana.tauro@intel.com>
>> Cc: Gupta Anshuman <anshuman.gupta@intel.com>
>> Cc: Jadav Raag <raag.jadav@intel.com>
>> Cc: Nilawar Badal <badal.nilawar@intel.com>
>> Cc: Koujalagi Mallesh <mallesh.koujalagi@intel.com>
>> Cc: Harish Chegondi <harish.chegondi@intel.com>
>> Signed-off-by: Ravi Kishore Koppuravuri 
>> <ravi.kishore.koppuravuri@intel.com>
>> ---
>> v4:Renamed library function names prefixed with igt_drm_netlink_*
>>     (Nikula Jani and Kamil)
>>     Moved the headers to other commits which are not necessary in this
>>     commit (Nikula Jani)
>> ---
>>   lib/igt_drm_netlink.c | 54 +++++++++++++++++++++++++++++++++++++++++++
>>   lib/igt_drm_netlink.h | 20 ++++++++++++++++
>>   lib/meson.build       |  1 +
>>   3 files changed, 75 insertions(+)
>>   create mode 100644 lib/igt_drm_netlink.c
>>   create mode 100644 lib/igt_drm_netlink.h
>>
>> diff --git a/lib/igt_drm_netlink.c b/lib/igt_drm_netlink.c
>> new file mode 100644
>> index 000000000..709c01987
>> --- /dev/null
>> +++ b/lib/igt_drm_netlink.c
Use drm_ras_nl. Would be clearer if any other netlink in drm subsystem 
is added.
>> @@ -0,0 +1,54 @@
>> +// SPDX-License-Identifier: MIT
>> +/*
>> + * Copyright © 2026 Intel Corporation
>> + */
>> +
>> +#include <stdint.h>
>> +
>> +#include <netlink/genl/ctrl.h>
>> +#include <netlink/genl/genl.h>
>> +
>> +#include "igt_core.h"
>> +#include "igt_drm_netlink.h"
>> +
>> +void igt_drm_netlink_cleanup(struct app_context *ctx)

Same as above

>> +{
>> +    if (!ctx || !ctx->sock)
>> +        return;
>> +
>> +    nl_close(ctx->sock);
>> +    nl_socket_free(ctx->sock);
>> +    ctx->sock = NULL;
>> +    ctx->family_id = -1;
>> +
>> +    igt_debug("Cleaned up netlink socket.\n");
>> +}
>> +
>> +int igt_drm_netlink_init(struct app_context *ctx)
>> +{
>> +    ctx->sock = nl_socket_alloc();
>> +    if (!ctx->sock)
>> +        return -1;
>> +
>> +    igt_debug("Socket allocation successful. Connecting to Generic 
>> Netlink...\n");

Not required. Even if needed use drm_ras netlink.

>> +    if (genl_connect(ctx->sock) < 0) {
>> +        igt_drm_netlink_cleanup(ctx);
>> +        return -1;
>> +    }
>> +
>> +    igt_debug("Resolving Generic Netlink family '%s'...\n", 
>> DRM_RAS_FAMILY_NAME);
>> +    ctx->family_id = genl_ctrl_resolve(ctx->sock, DRM_RAS_FAMILY_NAME);
>> +    if (ctx->family_id < 0) {
>> +        fprintf(stderr,
>> +            "Failed to resolve Generic Netlink family '%s': %s. "
>> +            "This may mean the running kernel does not expose DRM 
>> RAS support.\n", 
"(%s) not supported, DRM_RAS_FAMILY_NAME"

Use short sentences.

Thanks
Riana

>> +            DRM_RAS_FAMILY_NAME,
>> +            nl_geterror(ctx->family_id));
>> +        igt_drm_netlink_cleanup(ctx);
>> +        return -1;
>> +    }
>> +
>> +    igt_debug("Resolved Generic Netlink family '%s' with id %d.\n",
>> +          DRM_RAS_FAMILY_NAME, ctx->family_id);
>> +    return 0;
>> +}
>> diff --git a/lib/igt_drm_netlink.h b/lib/igt_drm_netlink.h
>> new file mode 100644
>> index 000000000..0e563e55f
>> --- /dev/null
>> +++ b/lib/igt_drm_netlink.h
>> @@ -0,0 +1,20 @@
>> +/* SPDX-License-Identifier: MIT */
>> +/*
>> + * Copyright © 2026 Intel Corporation
>> + */
>> +
>> +#ifndef IGT_DRM_NETLINK_H
>> +#define IGT_DRM_NETLINK_H
>> +
>> +#include <drm-uapi/drm_ras.h>
>> +
>> +struct app_context {
>
> app_context is too generic for a non-local type in a public header. 
> Please prefix it with "igt_drm_netlink_". e.g. struct 
> igt_drm_netlink_context.
>
> Thanks,
> Soham
>> +    struct nl_sock *sock;
>> +    int family_id;
>> +};
>> +
>> +void igt_drm_netlink_cleanup(struct app_context *ctx);
>> +int igt_drm_netlink_init(struct app_context *ctx);
>> +
>> +#endif /* IGT_DRM_NETLINK_H */
>> +
>> diff --git a/lib/meson.build b/lib/meson.build
>> index 7248bbc2d..70da9a4a0 100644
>> --- a/lib/meson.build
>> +++ b/lib/meson.build
>> @@ -27,6 +27,7 @@ lib_sources = [
>>       'igt_device_scan.c',
>>       'igt_drm_clients.h',
>>       'igt_drm_fdinfo.c',
>> +    'igt_drm_netlink.c',
>>           'igt_fs.c',
>>       'igt_aux.c',
>>       'igt_dp.c',