From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 612B9C64E8A for ; Wed, 2 Dec 2020 12:24:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F153A221FE for ; Wed, 2 Dec 2020 12:24:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F153A221FE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jYYrmn5LXi9N0Wb6VFJEjF6a8CnBBo8zz4KJJ4p1kgE=; b=ZagcC2AgO24yi2isQ0AfjbHvq cIAoQ9ONE08fQUovzP6YLWdlF44CIHCMLw54WTcYhaLtQxG7VmpZlZTuaYDyBawPIFl6zU3J72GLa uc7zscBAzF5+Ovg5XKb3OirG1FIaLw/ImF3gqUaPOPksMQBDKPCZ6qirf1INWTqcViMgJWn46WSlB ayVMhQ1Mv1tYDsnv9rL9UNwMhVRCASBWtKjfQmR/E47aWKmXNv5nezfYzLmgt8AnN/QwQV2tGh4YX uzewmdhiqhuYJxUUUJ3qRIbNKoAyVmx1YgNPal1hhfRoyGFtoYBKixS8E9Ah09Soo4rkaUK0zaSeF Ragw5o5eg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkRAG-0005um-4v; Wed, 02 Dec 2020 12:23:20 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkRAC-0005u4-RT for linux-arm-kernel@lists.infradead.org; Wed, 02 Dec 2020 12:23:17 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5B2C6221FE; Wed, 2 Dec 2020 12:23:14 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kkRA8-00FKbJ-2J; Wed, 02 Dec 2020 12:23:12 +0000 MIME-Version: 1.0 Date: Wed, 02 Dec 2020 12:23:11 +0000 From: Marc Zyngier To: "wangyanan (Y)" Subject: Re: [PATCH v2 0/3] Fix several bugs in KVM stage 2 translation In-Reply-To: <74540986-6197-34bc-cd53-850472091ee3@huawei.com> References: <20201201201034.116760-1-wangyanan55@huawei.com> <20201201205948.GA28178@willie-the-truck> <74540986-6197-34bc-cd53-850472091ee3@huawei.com> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <616980dcddd5c7e832c1068f6fa91449@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: wangyanan55@huawei.com, will@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, gshan@redhat.com, qperret@google.com, wanghaibin.wang@huawei.com, yezengruan@huawei.com, zhukeqian1@huawei.com, yuzenghui@huawei.com, jiangkunkun@huawei.com, wangjingyi11@huawei.com, lushenming@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201202_072317_301044_61DD2523 X-CRM114-Status: GOOD ( 21.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jiangkunkun@huawei.com, Gavin Shan , lushenming@huawei.com, Suzuki K Poulose , Catalin Marinas , zhukeqian1@huawei.com, Quentin Perret , wangjingyi11@huawei.com, linux-kernel@vger.kernel.org, yezengruan@huawei.com, James Morse , linux-arm-kernel@lists.infradead.org, yuzenghui@huawei.com, wanghaibin.wang@huawei.com, Will Deacon , Julien Thierry Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgWWFuYW4sCgpbLi4uXQoKPiBCVFc6IHRoZXJlIGFyZSB0d28gbW9yZSB0aGluZ3MgYmVsb3cg dGhhdCBJIHdhbnQgdG8gdGFsayBhYm91dC4KPiAKPiAxLsKgIFJlY2VudGx5LCBJIGhhdmUgYmVl biBmb2N1c2luZyBvbiB0aGUgQVJNdjguNC1UVFJlbSBmZWF0dXJlIHdoaWNoCj4gaXMgYWltZWQg YXQgY2hhbmdpbmcgYmxvY2sgc2l6ZSBpbiBzdGFnZSAyIG1hcHBpbmcuCj4gCj4gSSBoYXZlIGEg cGxhbiB0byBpbXBsZW1lbnQgdGhpcyBmZWF0dXJlIGZvciBzdGFnZSAyIHRyYW5zbGF0aW9uIHdo ZW4KPiBzcGxpdHRpbmcgYSBibG9jayBpbnRvIHRhYmxlcyBvciBtZXJnaW5nIHRhYmxlcyBpbnRv IGEgYmxvY2suCj4gCj4gVGhpcyBmZWF0dXJlIHN1cHBvcnRzIGNoYW5naW5nIGJsb2NrIHNpemUg d2l0aG91dCBwZXJmb3JtaW5nCj4gKmJyZWFrLWJlZm9yZS1tYWtlKiwgd2hpY2ggbWlnaHQgaGF2 ZSBzb21lIGltcHJvdmVtZW50IG9uIHBlcmZvcm1hbmNlLgo+IAo+IFdoYXQgZG8geW91IHRoaW5r IGFib3V0IHRoaXM/CgpJdCB3b3VsZCBiZSBpbnRlcmVzdGluZyBpZiB5b3UgY2FuIGRlbW9uc3Ry YXRlIHNvbWUgc2lnbmlmaWNhbnQKcGVyZm9ybWFuY2UgaW1wcm92ZW1lbnRzIGNvbXBhcmVkIHRv IHRoZSBzYW1lIHdvcmtsb2FkIHdpdGggQkJNLgoKSSdtIG5vdCBjb21wbGV0ZWx5IGNvbnZpbmNl ZCB0aGlzIHdvdWxkIGNoYW5nZSBtdWNoLCBnaXZlbiB0aGF0Cml0IGlzIG9ubHkgd2hlbiBtb3Zp bmcgZnJvbSBhIHRhYmxlIHRvIGEgYmxvY2sgbWFwcGluZyB0aGF0IHlvdQpjYW4gZWxpZGUgQkJN IHdoZW4gdGhlIHN1cHBvcnQgbGV2ZWwgaXMgMSBvciAyLiBBcyBmYXIgYXMgSSBjYW4KdGVsbCwg dGhpcyBvbmx5IGhhcHBlbnMgaW4gdGhlICJzdG9wIGxvZ2dpbmciIGNhc2UuCgpJcyB0aGF0IHNv bWV0aGluZyB0aGF0IGhhcHBlbnMgb2Z0ZW4gZW5vdWdoIHRvIGp1c3RpZnkgdGhlIGFkZGVkCmNv bXBsZXhpdHk/IEhhdmluZyB0byBoYW5kbGUgVExCIENvbmZsaWN0IEFib3J0IGlzIGFubm95aW5n LCBmb3IKZXhhbXBsZS4KCj4gMi4gR2l2ZW4gdGhhdCB0aGUgaXNzdWVzIHdlIGRpc2N1c3NlZCBi ZWZvcmUgd2VyZSBmb3VuZCBpbiBwcmFjdGljZQo+IHdoZW4gZ3Vlc3Qgc3RhdGUgY2hhbmdlcyBm cm9tIGRpcnR5IGxvZ2dpbmcgdG8gZGlydHkgbG9nZ2luZyBjYW5jZWxlZC4KPiAKPiBJIGNvdWxk IGFkZCBhIHRlc3QgZmlsZSB0ZXN0aW5nIG9uIHRoaXMgY2FzZSB0byBzZWxmdGVzdHMvIG9yIGt2 bSB1bml0Cj4gdGVzdHMvLCBpZiBpdCdzIG5lY2Vzc2FyeS4KClRoYXQgd291bGQgYmUgYXdlc29t ZSwgYW5kIEknZCBiZSB2ZXJ5IGdyYXRlZnVsIGlmIHlvdSBkaWQuIEl0IGlzIHRoZQpzZWNvbmQg dGltZSB3ZSBicmVhayB0aGlzIGV4YWN0IGNhc2UsIGFuZCBoYXZpbmcgYSByZWxpYWJsZSB3YXkg dG8KdmVyaWZ5IGl0IHdvdWxkIGRlZmluaXRlbHkgaGVscC4KClRoYW5rcywKCiAgICAgICAgIE0u Ci0tIApKYXp6IGlzIG5vdCBkZWFkLiBJdCBqdXN0IHNtZWxscyBmdW5ueS4uLgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBt YWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12FA8C64E90 for ; Wed, 2 Dec 2020 12:23:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B8D8E221FE for ; Wed, 2 Dec 2020 12:23:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729916AbgLBMX4 (ORCPT ); Wed, 2 Dec 2020 07:23:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:52294 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726066AbgLBMXz (ORCPT ); Wed, 2 Dec 2020 07:23:55 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5B2C6221FE; Wed, 2 Dec 2020 12:23:14 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kkRA8-00FKbJ-2J; Wed, 02 Dec 2020 12:23:12 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Wed, 02 Dec 2020 12:23:11 +0000 From: Marc Zyngier To: "wangyanan (Y)" Cc: Will Deacon , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Catalin Marinas , James Morse , Julien Thierry , Suzuki K Poulose , Gavin Shan , Quentin Perret , wanghaibin.wang@huawei.com, yezengruan@huawei.com, zhukeqian1@huawei.com, yuzenghui@huawei.com, jiangkunkun@huawei.com, wangjingyi11@huawei.com, lushenming@huawei.com Subject: Re: [PATCH v2 0/3] Fix several bugs in KVM stage 2 translation In-Reply-To: <74540986-6197-34bc-cd53-850472091ee3@huawei.com> References: <20201201201034.116760-1-wangyanan55@huawei.com> <20201201205948.GA28178@willie-the-truck> <74540986-6197-34bc-cd53-850472091ee3@huawei.com> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <616980dcddd5c7e832c1068f6fa91449@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: wangyanan55@huawei.com, will@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, gshan@redhat.com, qperret@google.com, wanghaibin.wang@huawei.com, yezengruan@huawei.com, zhukeqian1@huawei.com, yuzenghui@huawei.com, jiangkunkun@huawei.com, wangjingyi11@huawei.com, lushenming@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Yanan, [...] > BTW: there are two more things below that I want to talk about. > > 1.  Recently, I have been focusing on the ARMv8.4-TTRem feature which > is aimed at changing block size in stage 2 mapping. > > I have a plan to implement this feature for stage 2 translation when > splitting a block into tables or merging tables into a block. > > This feature supports changing block size without performing > *break-before-make*, which might have some improvement on performance. > > What do you think about this? It would be interesting if you can demonstrate some significant performance improvements compared to the same workload with BBM. I'm not completely convinced this would change much, given that it is only when moving from a table to a block mapping that you can elide BBM when the support level is 1 or 2. As far as I can tell, this only happens in the "stop logging" case. Is that something that happens often enough to justify the added complexity? Having to handle TLB Conflict Abort is annoying, for example. > 2. Given that the issues we discussed before were found in practice > when guest state changes from dirty logging to dirty logging canceled. > > I could add a test file testing on this case to selftests/ or kvm unit > tests/, if it's necessary. That would be awesome, and I'd be very grateful if you did. It is the second time we break this exact case, and having a reliable way to verify it would definitely help. Thanks, M. -- Jazz is not dead. It just smells funny...