From: Sven Eckelmann <sven@narfation.org>
To: netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: batman-adv: Fix double-hold of meshif when getting enabled
Date: Wed, 09 Apr 2025 09:30:52 +0200 [thread overview]
Message-ID: <6178198.MhkbZ0Pkbq@ripper> (raw)
In-Reply-To: <20250409073000.556263-1-sven@narfation.org>
[-- Attachment #1: Type: text/plain, Size: 812 bytes --]
On Wednesday, 9 April 2025 09:30:00 CEST Sven Eckelmann wrote:
> Fixes: 00b35530811f ("batman-adv: adopt netdev_hold() / netdev_put()")
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
>
> diff --git a/net/batman-adv/hard-interface.c b/net/batman-adv/hard-interface.c
> index f145f96626531053bbf8f58a31f28f625a9d80f9..7cd4bdcee43935b9e5fb7d1696430909b7af67b4 100644
> --- a/net/batman-adv/hard-interface.c
> +++ b/net/batman-adv/hard-interface.c
> @@ -725,7 +725,6 @@ int batadv_hardif_enable_interface(struct batadv_hard_iface *hard_iface,
>
> kref_get(&hard_iface->refcount);
>
> - dev_hold(mesh_iface);
> netdev_hold(mesh_iface, &hard_iface->meshif_dev_tracker, GFP_ATOMIC);
> hard_iface->mesh_iface = mesh_iface;
> bat_priv = netdev_priv(hard_iface->mesh_iface);
>
Sorry, from wrong folder
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2025-04-09 7:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 7:30 batman-adv: Fix double-hold of meshif when getting enabled Sven Eckelmann
2025-04-09 7:30 ` Sven Eckelmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6178198.MhkbZ0Pkbq@ripper \
--to=sven@narfation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.