From: Markus Elfring <Markus.Elfring@web.de>
To: Andrew Davis <afd@ti.com>, Bartosz Golaszewski <brgl@bgdev.pl>,
Wolfram Sang <wsa@kernel.org>,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kernel-janitors@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] i2c: davinci: Use struct name not type with devm_kzalloc()
Date: Thu, 8 Jun 2023 11:42:23 +0200 [thread overview]
Message-ID: <61846ef5-26fb-52bf-11a3-b1c0b3b53b94@web.de> (raw)
In-Reply-To: <20230515175042.495377-2-afd@ti.com>
> This reduces chance of error if the type of "dev" changes. While here
> remove extra error print out, this is not usually done for memory
> allocation failures.
https://lore.kernel.org/linux-i2c/20230515175042.495377-2-afd@ti.com/
http://patchwork.ozlabs.org/project/linux-i2c/patch/20230515175042.495377-2-afd@ti.com/
I find that this change approach does not fit to the known requirement
“Solve only one problem per patch.”.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.4-rc5#n81
Should desirable changes be split into better update steps?
See also:
[PATCH 0/2] I2C-DaVinci: Adjustments for davinci_i2c_probe()
https://lore.kernel.org/linux-i2c/4e668c87-65f5-8a00-132a-0184779faa08@users.sourceforge.net/
https://lkml.org/lkml/2018/2/2/541
* [1/2] i2c-davinci: Delete an error message for a failed memory allocation in davinci_i2c_probe()
https://patchwork.ozlabs.org/project/linux-i2c/patch/f890924b-ca68-253b-a7c8-fce269393867@users.sourceforge.net/
* [2/2] i2c-davinci: Improve a size determination in davinci_i2c_probe()
https://patchwork.ozlabs.org/project/linux-i2c/patch/e16ba754-078a-097a-7333-076f43718645@users.sourceforge.net/
Regards,
Markus
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-06-08 9:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 17:50 [PATCH v2 1/2] i2c: davinci: Use platform table macro over module_alias Andrew Davis
2023-05-15 17:50 ` Andrew Davis
2023-05-15 17:50 ` [PATCH v2 2/2] i2c: davinci: Use struct name not type with devm_kzalloc() Andrew Davis
2023-05-15 17:50 ` Andrew Davis
2023-05-16 14:45 ` Bartosz Golaszewski
2023-05-16 14:45 ` Bartosz Golaszewski
2023-06-07 9:29 ` Wolfram Sang
2023-06-07 9:29 ` Wolfram Sang
2023-06-08 9:42 ` Markus Elfring [this message]
2023-06-08 11:24 ` Wolfram Sang
2023-06-08 11:24 ` Wolfram Sang
2023-06-08 11:30 ` [v2 " Markus Elfring
2023-06-08 13:37 ` Wolfram Sang
2023-06-08 13:37 ` Wolfram Sang
2023-06-08 18:46 ` Markus Elfring
2023-05-16 14:46 ` [PATCH v2 1/2] i2c: davinci: Use platform table macro over module_alias Bartosz Golaszewski
2023-05-16 14:46 ` Bartosz Golaszewski
2023-06-07 9:32 ` Wolfram Sang
2023-06-07 9:32 ` Wolfram Sang
2023-06-23 8:27 ` Wolfram Sang
2023-06-23 8:27 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61846ef5-26fb-52bf-11a3-b1c0b3b53b94@web.de \
--to=markus.elfring@web.de \
--cc=afd@ti.com \
--cc=brgl@bgdev.pl \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.