From: "xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>
To: Jan Kara <jack@suse.cz>
Cc: "Alejandro Colomar (man-pages)" <alx.manpages@gmail.com>,
"Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>,
"linux-man@vger.kernel.org" <linux-man@vger.kernel.org>,
Eugene Syromyatnikov <evgsyr@gmail.com>
Subject: Re: [PATCH] quotactl.2: Remove kernel version for Q_XQUOTARM ioctl
Date: Mon, 8 Nov 2021 02:37:41 +0000 [thread overview]
Message-ID: <61888D90.5080205@fujitsu.com> (raw)
In-Reply-To: <20211105113414.GB26497@quack2.suse.cz>
on 2021/11/5 19:34, Jan Kara wrote:
> On Fri 05-11-21 03:05:44, xuyang2018.jy@fujitsu.com wrote:
>> ps:I also increase ltp quotactl coverage to cover quotactl_fd syscall. I
>> would appreciate it if you could review my ltp quotactl/quotactl_fd patchset
>> https://patchwork.ozlabs.org/project/ltp/list/?series=269166
>
> From a quick look the patches look fine. Just one thing I've noticed - you
> seem to open "mntpoint/testfile" so that you have 'fd' to pass to
> quotactl_fd(). Why don't you just open "mntpoint" directly?
Oh, yes.
At the beginning, I try it but open fails with EISDIR because I use RW
mode for the file.
mnt_want_write(f.file->f_path.mnt) just need we can write something into
superblock instead of a rw file. So I can use read-only fd directly.
Will use mntpoint directly.
Thanks.
>
> Honza
next prev parent reply other threads:[~2021-11-08 2:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 1:46 [PATCH] quotactl.2: Remove kernel version for Q_XQUOTARM ioctl Yang Xu
2021-11-01 3:38 ` xuyang2018.jy
2021-11-03 9:19 ` xuyang2018.jy
2021-11-03 9:29 ` xuyang2018.jy
2021-11-03 14:29 ` Alejandro Colomar (man-pages)
2021-11-04 0:58 ` xuyang2018.jy
2021-11-04 10:43 ` Eugene Syromyatnikov
2021-11-04 11:02 ` Eugene Syromyatnikov
2021-11-04 10:53 ` Jan Kara
2021-11-04 20:10 ` Alejandro Colomar (man-pages)
2021-11-05 3:05 ` xuyang2018.jy
2021-11-05 11:34 ` Jan Kara
2021-11-08 2:37 ` xuyang2018.jy [this message]
2021-11-05 11:20 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61888D90.5080205@fujitsu.com \
--to=xuyang2018.jy@fujitsu.com \
--cc=alx.manpages@gmail.com \
--cc=evgsyr@gmail.com \
--cc=jack@suse.cz \
--cc=linux-man@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.