Re: [Intel-gfx] [PATCH RESEND 3/7] drm/i915/mst: debug log 4 bytes of ESI right after reading

["Shankar, Uma" <uma.shankar@intel.com>]

> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Jani Nikula
> Sent: Wednesday, January 12, 2022 4:33 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: Nikula, Jani <jani.nikula@intel.com>
> Subject: [Intel-gfx] [PATCH RESEND 3/7] drm/i915/mst: debug log 4 bytes of ESI right
> after reading
> 
> For whatever reason, the ESI link service irq vector was missing from the debug
> output. Add the missing byte, clean up the debug message, and do the logging right
> after reading the data.

Looks Good to me.
Reviewed-by: Uma Shankar <uma.shankar@intel.com>

> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_dp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
> b/drivers/gpu/drm/i915/display/intel_dp.c
> index a301220ce2ad..6de39056e2f8 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -3683,6 +3683,8 @@ intel_dp_check_mst_status(struct intel_dp *intel_dp)
>  			break;
>  		}
> 
> +		drm_dbg_kms(&i915->drm, "DPRX ESI: %4ph\n", esi);
> +
>  		/* check link status - esi[10] = 0x200c */
>  		if (intel_dp->active_mst_links > 0 && link_ok &&
>  		    !drm_dp_channel_eq_ok(&esi[10], intel_dp->lane_count)) { @@ -
> 3691,8 +3693,6 @@ intel_dp_check_mst_status(struct intel_dp *intel_dp)
>  			link_ok = false;
>  		}
> 
> -		drm_dbg_kms(&i915->drm, "got esi %3ph\n", esi);
> -
>  		intel_dp_mst_hpd_irq(intel_dp, esi, &handled);
> 
>  		if (!handled)
> --
> 2.30.2