Re: [PATCH net] net/sched: flower: Add lock protection when remove filter handle

[Jianbo Liu <jianbol@nvidia.com>]

On Tue, 2024-02-20 at 09:53 -0500, Jamal Hadi Salim wrote:
> On Tue, Feb 20, 2024 at 4:17 AM Jiri Pirko <jiri@resnulli.us> wrote:
> > 
> > Tue, Feb 20, 2024 at 09:59:28AM CET, jianbol@nvidia.com wrote:
> > > As IDR can't protect itself from the concurrent modification,
> > > place
> > > idr_remove() under the protection of tp->lock.
> > > 
> > > Fixes: 08a0063df3ae ("net/sched: flower: Move filter handle
> > > initialization earlier")
> > > Signed-off-by: Jianbo Liu <jianbol@nvidia.com>
> > > Reviewed-by: Cosmin Ratiu <cratiu@nvidia.com>
> > > Reviewed-by: Gal Pressman <gal@nvidia.com>
> > 
> > Reviewed-by: Jiri Pirko <jiri@nvidia.com>
> 
> Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
> 
> Jianbo,  do you have a new test case that caught this that we can
> use?
> Just curious why it hasnt been caught earlier (it's been there for
> about a year).

I don't have the test case, sorry.
The issue was caught when we stressed performance on BlueField-3.

Thanks!
Jianbo

> 
> cheers,
> jamal