Re: NRMK build break

[Jeff Venable <jeff-UWzLy5XGHPAX2WXlbB3fKg@public.gmane.org>]

  Make clean outside of NRMK would have caught it.

Sent from my Windows Phone
 ------------------------------
From: Ryan Prenger <ryan-UWzLy5XGHPAX2WXlbB3fKg@public.gmane.org>
Sent: 2/9/2014 2:08 PM
To: Jeff Venable, Sr. <jeff-UWzLy5XGHPAX2WXlbB3fKg@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: NRMK build break

Thanks for fixing it.  In my defense, it did build from a clean build for
me before I left and Himanshu also checked the build for me in case I
forgot to git add any files. The only ways I could see this happening is if
environment variables were different on our machines or if doing a "make
clean" leaves something behind from previous makes in lower directories so
doing "make clean; make appD" could work or not work based on previous
builds.  This is something we should track down (maybe you already have)
lest Jenkins starts clearing builds that break from a fresh install.

Cheers,

Ryan


On Fri, Feb 7, 2014 at 4:46 PM, Jeff Venable, Sr. <jeff-UWzLy5XGHPAX2WXlbB3fKg@public.gmane.org>wrote:

> For those who leave the office before verifying they didn't break the
> build, a public flogging! :)
>
> /usr/bin/ld: cannot find -lipinfo
>
> collect2: error: ld returned 1 exit status
>
> make: *** [/home/jeff/Colossus/nrmk/dataplane/P2P/obj/debug/libP2P.so]
> Error 1
>
> make: *** Waiting for unfinished jobs....
>
> You marked libipinfo.so as an *external* dependency.  You need to make it
> a *makefile* dependency.  The fix:
>
> (*jeff**@**colossus** ~/Colossus/nrmk**)**$ *git diff
> dataplane/P2P/Rules.mk
>
> diff --git a/nrmk/dataplane/P2P/Rules.mk b/nrmk/dataplane/P2P/Rules.mk
>
> index 2ecc396..093b7ac 100644
>
> --- a/nrmk/dataplane/P2P/Rules.mk
>
> +++ b/nrmk/dataplane/P2P/Rules.mk
>
> @@ -34,6 +34,7 @@ libP2P.so_DEPS := \
>
>      P2PConfig.o \
>
>      $(TARGETS_$(TOP)/lib/json) \
>
>      $(TARGETS_$(TOP)/lib/notes) \
>
> +    $(TARGETS_$(TOP)/lib/ipinfo)
>
>
>
>  LIBDIRS_$(d) = $(TOP)/../lib
>
>
>
> @@ -41,5 +42,4 @@ libP2P.so_LIBS = \
>
>      -lcolossuscommon \
>
>      -lcolossuscommand \
>
>      -lcolossustrace \
>
> -    -lcolossusutilities \
>
> -    -lipinfo
>
> +    -lcolossusutilities
>
> Pushing the fix.
>
> Thanks for moving all your algorithms into NRMK! :)
>
> Jeff
>