From: "xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: "ltp@lists.linux.it" <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH] syscalls/statx05, 07: Move e4crypt, exportfs to tst_test structure
Date: Tue, 7 Dec 2021 01:44:26 +0000 [thread overview]
Message-ID: <61AEBC9B.7070300@fujitsu.com> (raw)
In-Reply-To: <Ya4Fa01xi7/iKaC0@yuki>
Hi Cyril
> Hi!
>> --- a/testcases/kernel/syscalls/statx/statx05.c
>> +++ b/testcases/kernel/syscalls/statx/statx05.c
>> @@ -10,8 +10,6 @@
>> * Test statx syscall with STATX_ATTR_ENCRYPTED flag, setting a key is required
>> * for the file to be encrypted by the filesystem.
>> *
>> - * e4crypt is used to set the encrypt flag (currently supported only by ext4).
>
> Maybe we should keep the info that it's currently supported on ext4 only
> with something as:
>
> * Encrypted files are currently supported by ext4 only.
It seems this message refers to e4crypt tools(like xfs filesystem
xfs_io/xfs_quota command supports foreign mode that can support other
filesystem.).
e4crypt tools may supports foreign mode in the feature. So I prefer to use
"Using e4crypt to encrypt files are currently supported by ext4 only"
message.
Best Regards
Yang Xu
>
>
> Other than this it's obviously fine:
>
> Reviewed-by: Cyril Hrubis<chrubis@suse.cz>
>
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-12-07 1:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 3:15 [LTP] [PATCH] syscalls/statx05, 07: Move e4crypt, exportfs to tst_test structure Yang Xu
2021-12-06 12:43 ` Cyril Hrubis
2021-12-07 1:44 ` xuyang2018.jy [this message]
2021-12-07 7:56 ` [LTP] [PATCH v2] " Yang Xu
2021-12-08 5:44 ` xuyang2018.jy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61AEBC9B.7070300@fujitsu.com \
--to=xuyang2018.jy@fujitsu.com \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.