From: "xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>
To: Li Wang <liwang@redhat.com>
Cc: "ltp@lists.linux.it" <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v3] lib: Do not fail a test if oom score cannot be adjusted.
Date: Thu, 23 Dec 2021 03:03:19 +0000 [thread overview]
Message-ID: <61C3E707.9040805@fujitsu.com> (raw)
In-Reply-To: <20211223024841.801160-1-liwang@redhat.com>
Hi Li
> From: Petr Vorel<pvorel@suse.cz>
>
> Setting value< 0 in/proc/<pid>/oom_score_adj requires CAP_SYS_RESOURCE.
> However setting the library process score is a best effort operation,
> so let's skip it silently when the user is not privileged to do so.
>
> Fixes: 8a0827766d ("lib: add functions to adjust oom score")
> Signed-off-by: Petr Vorel<pvorel@suse.cz>
> Signed-off-by: Cyril Hrubis<chrubis@suse.cz>
> Signed-off-by: Li Wang<liwang@redhat.com>
Now, LGTM,
Reviewed-by: Yang Xu <xuyang2018.jy@fujitsu.com>
ps: ubuntun:groxy fails because of other thing..., it is another problem.
Best Regards
Yang Xu
> ---
>
> Notes:
> v2 --> v3
> * drop the useless CAP_SYS_ADMIN
> * add some new commments
> CI job:https://github.com/wangli5665/ltp/actions/runs/1613852940
>
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-12-23 3:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-22 13:52 [LTP] [PATCH v2] lib: Do not fail a test if oom score cannot be adjusted Cyril Hrubis
2021-12-22 14:03 ` Petr Vorel
2021-12-23 1:17 ` xuyang2018.jy
2021-12-23 2:13 ` Li Wang
2021-12-23 2:48 ` [LTP] [PATCH v3] " Li Wang
2021-12-23 3:03 ` xuyang2018.jy [this message]
2021-12-23 7:57 ` Petr Vorel
2021-12-23 8:29 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61C3E707.9040805@fujitsu.com \
--to=xuyang2018.jy@fujitsu.com \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.