From: Nikolai Zhubr <zhubr.2@gmail.com>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>, Arnd Bergmann <arnd@kernel.org>,
x86@kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] x86/PCI: SiS PIRQ router updates
Date: Mon, 03 Jan 2022 14:10:45 +0300 [thread overview]
Message-ID: <61D2D9B5.7080401@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2201022040130.56863@angie.orcam.me.uk>
Hello Maciej,
Apparently, my previous replies (of 11-sep-2021 to 16-sep-2021) with
some observations somehow went to spam box or whatever. I was going to
retry but got too busy with unrelated stuff at that time. I can re-send
them if necessary.
Anyway. Yes, your patch is very usefull. I've tested it quite thoroughly
back then, including sharing IRQs for 2 unrelated PCI devices etc. I
have it always automatically applied in my private trees since then.
One peculiarity with my specific board is that I had to also patch ROM
BIOS because it included some non-standard $IRT table instead of $PIR
table. With that in place, it now Just Works.
Thank you again for your effort,
Regards,
Nikolai
03.01.2022 2:24, Maciej W. Rozycki:
> Hi,
>
> Reposting as this has gone nowhere. Regenerated for line changes and
> with Nikolai's Tested-by annotation for 2/2, which now have been verified
> in combination with generic PIRQ router updates posted separately (there's
> no ordering dependency between the two patch series).
>
> Nikolai has observed the trigger mode not being fixed up once it has been
> incorrectly set by the BIOS for PCI devices, causing all kinds of usual
> issues. As it turns out we don't have a PIRQ router defined for the
> SiS85C497 southbridge, which Nikolai's system uses, and which is different
> from the SiS85C503 southbridge we have support for.
>
> As we use the generic `sis' infix (capitalised or not) for the SiS85C503
> southbridge I have prepared this small patch series to first make the
> existing SiS program entities use a more specific `sis503' infix, and then
> provide a suitable PIRQ router for the SiS85C497 device.
>
> See individual change descriptions for further details.
>
> Please apply.
>
> Maciej
>
next prev parent reply other threads:[~2022-01-03 11:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-02 23:24 [PATCH v2 0/2] x86/PCI: SiS PIRQ router updates Maciej W. Rozycki
2022-01-02 23:25 ` [PATCH v2 1/2] x86/PCI: Disambiguate SiS85C503 PIRQ router code entities Maciej W. Rozycki
2022-02-02 20:30 ` [tip: x86/irq] " tip-bot2 for Maciej W. Rozycki
2022-01-02 23:25 ` [PATCH v2 2/2] x86/PCI: Add support for the SiS85C497 PIRQ router Maciej W. Rozycki
2022-02-02 20:30 ` [tip: x86/irq] " tip-bot2 for Maciej W. Rozycki
2022-01-03 11:10 ` Nikolai Zhubr [this message]
2022-01-03 13:47 ` [PATCH v2 0/2] x86/PCI: SiS PIRQ router updates Maciej W. Rozycki
2022-01-06 23:25 ` Bjorn Helgaas
2022-02-01 10:50 ` [PING][PATCH " Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61D2D9B5.7080401@gmail.com \
--to=zhubr.2@gmail.com \
--cc=arnd@kernel.org \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.