From: "yangx.jy@fujitsu.com" <yangx.jy@fujitsu.com>
To: Tom Talpey <tom@talpey.com>
Cc: "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"yanjun.zhu@linux.dev" <yanjun.zhu@linux.dev>,
"rpearsonhpe@gmail.com" <rpearsonhpe@gmail.com>,
"jgg@nvidia.com" <jgg@nvidia.com>,
"y-goto@fujitsu.com" <y-goto@fujitsu.com>,
"lizhijian@fujitsu.com" <lizhijian@fujitsu.com>,
"tomasz.gromadzki@intel.com" <tomasz.gromadzki@intel.com>
Subject: Re: [RFC PATCH 2/2] RDMA/rxe: Add RDMA Atomic Write operation
Date: Wed, 12 Jan 2022 09:24:17 +0000 [thread overview]
Message-ID: <61DE9E3F.4020202@fujitsu.com> (raw)
In-Reply-To: <130d8b4d-3565-eba1-c56a-58155d3303b2@talpey.com>
On 2022/1/7 23:50, Tom Talpey wrote:
> Alignment is only part of the issue. The instruction set, type of
> mapping, and the width of the bus are also important to determine if
> a torn write might occur.
>
> Off the top of my head, an uncached mapping would be a problem on an
> architecture which did not support 64-bit stores. A cache will merge
> 32-bit writes, which won't happen if it's disabled. I guess it could
> be argued this is uninteresting, in a modern platform, but...
>
> A second might be MMIO space, or a similar dedicated memory block such
> as a GPU. It's completely a platform question whether these can provide
> an untorn 64-bit write semantic.
Hi Tom,
These issues come from differnet arches or devices.
Either atomic64_set() or smp_store_release() returns void so how to
check these issues in SoftRoCE driver?
Sorry, it's not clear for me to add which stricter checks.
Best Regards,
Xiao Yang
next prev parent reply other threads:[~2022-01-12 9:24 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-30 12:14 [RFC PATCH 0/2] RDMA/rxe: Add RDMA Atomic Write operation Xiao Yang
2021-12-30 12:14 ` [RFC PATCH 1/2] RDMA/rxe: Rename send_atomic_ack() and atomic member of struct resp_res Xiao Yang
2021-12-30 12:14 ` [RFC PATCH 2/2] RDMA/rxe: Add RDMA Atomic Write operation Xiao Yang
2021-12-30 21:39 ` Tom Talpey
2021-12-31 8:29 ` yangx.jy
2021-12-31 15:09 ` Tom Talpey
[not found] ` <61D563B4.2070106@fujitsu.com>
2022-01-07 15:50 ` Tom Talpey
2022-01-07 17:11 ` Jason Gunthorpe
2022-01-12 9:24 ` yangx.jy [this message]
2022-01-05 23:53 ` Jason Gunthorpe
2022-01-06 10:52 ` yangx.jy
2022-01-06 13:00 ` Jason Gunthorpe
2022-01-07 2:15 ` yangx.jy
2022-01-07 12:22 ` Jason Gunthorpe
2022-01-07 15:38 ` Tom Talpey
2022-01-07 19:28 ` Jason Gunthorpe
2022-01-07 20:11 ` Tom Talpey
2021-12-31 3:01 ` lizhijian
2021-12-31 6:02 ` yangx.jy
2021-12-30 19:21 ` [RFC PATCH 0/2] " Gromadzki, Tomasz
2021-12-30 21:42 ` Tom Talpey
2021-12-31 6:30 ` yangx.jy
2022-01-04 9:28 ` yangx.jy
2022-01-04 15:17 ` Tom Talpey
2022-01-05 1:00 ` yangx.jy
2022-01-06 0:01 ` Jason Gunthorpe
2022-01-06 1:54 ` yangx.jy
2022-01-10 15:42 ` Jason Gunthorpe
2022-01-11 2:34 ` yangx.jy
2022-01-11 23:29 ` Jason Gunthorpe
2022-02-11 13:18 ` Gromadzki, Tomasz
2022-02-17 3:50 ` yangx.jy
2022-02-19 10:37 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61DE9E3F.4020202@fujitsu.com \
--to=yangx.jy@fujitsu.com \
--cc=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=lizhijian@fujitsu.com \
--cc=rpearsonhpe@gmail.com \
--cc=tom@talpey.com \
--cc=tomasz.gromadzki@intel.com \
--cc=y-goto@fujitsu.com \
--cc=yanjun.zhu@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.