Re: [PATCH net v2] net: dsa: microchip: fix KSZ8765 fiber detection

[Nicolai Buchwitz <nb@tipi-net.de>]

Hi Sébastien

On 7.10.2026 10:05, Sebastien Royen wrote:
> The KSZ8765 is similar to the KSZ8795 but has two fiber ports.
> 
> KSZ8_PORT_STATUS_0 is used to detect fiber mode. It is currently
> defined as 0x08, which is the Global Control 6 MIB Control register
> and has bit 7 defined as Flush Counter.
> 
> Set KSZ8_PORT_STATUS_0 to 0x18, which is the Port 1 Status 0 register
> where bit 7 is the Fiber Mode bit.
> 
> Fixes: 91a98917a883 ("net: dsa: microchip: move switch chip_id 
> detection to ksz_common")
> Reviewed-by: Nicolai Buchwitz <nb@tipi-net.de>
> Signed-off-by: Sebastien Royen <sebastien.royen@armadeus.com>
> ---
>  drivers/net/dsa/microchip/ksz_common.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/dsa/microchip/ksz_common.h 
> b/drivers/net/dsa/microchip/ksz_common.h
> index cbe98494578c..f6104f714a8d 100644
> --- a/drivers/net/dsa/microchip/ksz_common.h
> +++ b/drivers/net/dsa/microchip/ksz_common.h
> @@ -853,7 +853,7 @@ static inline bool ksz_is_sgmii_port(struct 
> ksz_device *dev, int port)
>  #define KSZ88_FAMILY_ID			0x88
>  #define KSZ8895_FAMILY_ID		0x95
> 
> -#define KSZ8_PORT_STATUS_0		0x08
> +#define KSZ8_PORT_STATUS_0		0x18
>  #define KSZ8_PORT_FIBER_MODE		BIT(7)
> 
>  #define SW_CHIP_ID_M			GENMASK(7, 4)

Please do not send new versions in response to the earlier version, but 
send it
like you would send a new patch (with the usual v2 ... prefix).

For more details please have a look at the netdev contribution docs [1]

[1] 
https://docs.kernel.org/process/maintainer-netdev.html#resending-after-review

Thanks,
Nicolai