From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "Julien Grall" <julien@xen.org>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Anthony PERARD" <anthony.perard@vates.tech>,
"Michal Orzel" <michal.orzel@amd.com>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Bertrand Marquis" <bertrand.marquis@arm.com>,
"Volodymyr Babchuk" <volodymyr_babchuk@epam.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] trace: convert init_trace_bufs() to constructor
Date: Thu, 13 Mar 2025 17:37:12 +0100 [thread overview]
Message-ID: <61b762d0-d513-4d02-80ac-50fa12a725f3@suse.com> (raw)
In-Reply-To: <d597523c-aa3a-4682-824f-e6e2f8ce753a@citrix.com>
On 13.03.2025 17:28, Andrew Cooper wrote:
> On 13/03/2025 2:19 pm, Jan Beulich wrote:
>> On 13.03.2025 14:58, Andrew Cooper wrote:
>>> On 13/03/2025 1:38 pm, Jan Beulich wrote:
>>> I'm tempted to ack this on the basis that it is an improvement, but a /*
>>> TODO this is all mad, please fix */ wouldn't go amiss either.
>> I understand you like adding such comments; I, however, at least
>> sometimes (e.g.) don't. Especially without at least outlining what
>> would need doing. Just saying "this is all mad" doesn't really help
>> very much.
>
> I was being somewhat flippant. But a /* TODO, try and make this a
> presmp_initcall() to improve alloc_trace_bufs() */ would be fine.
Okay, added (to the existing comment).
Jan
next prev parent reply other threads:[~2025-03-13 16:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 13:38 [PATCH] trace: convert init_trace_bufs() to constructor Jan Beulich
2025-03-13 13:58 ` Andrew Cooper
2025-03-13 14:19 ` Jan Beulich
2025-03-13 16:28 ` Andrew Cooper
2025-03-13 16:37 ` Jan Beulich [this message]
2025-03-13 17:03 ` Andrew Cooper
2025-03-14 6:49 ` Jan Beulich
2025-03-14 11:35 ` Andrew Cooper
2025-03-27 14:49 ` Julien Grall
2025-03-27 15:08 ` Jan Beulich
2025-03-27 15:49 ` Julien Grall
2025-03-27 16:10 ` Jan Beulich
2025-03-27 21:48 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61b762d0-d513-4d02-80ac-50fa12a725f3@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@vates.tech \
--cc=bertrand.marquis@arm.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=volodymyr_babchuk@epam.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.