From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Jon Maloy <jmaloy@redhat.com>,
qemu-devel@nongnu.org, Jason Wang <jasowang@redhat.com>,
Alexander Bulekov <alxndr@redhat.com>
Subject: Re: [PATCH] e1000: fix tx re-entrancy problem
Date: Thu, 16 Dec 2021 10:36:18 +0100 [thread overview]
Message-ID: <61ba1305-321a-1de2-a399-e7b608e4dad4@redhat.com> (raw)
In-Reply-To: <20211021161047.578751-1-jmaloy@redhat.com>
Hi Jon,
On 10/21/21 18:10, Jon Maloy wrote:
> The fact that the MMIO handler is not re-entrant causes an infinite
> loop under certain conditions:
>
> Guest write to TDT -> Loopback -> RX (DMA to TDT) -> TX
>
> We now eliminate the effect of this problem locally in e1000, by adding
> a boolean in struct E1000State indicating when the TX side is busy. This
> will cause any entering new call to return early instead of interfering
> with the ongoing work, and eliminates any risk of looping.
>
> This is intended to address CVE-2021-20257.
>
> Signed-off-by: Jon Maloy <jmaloy@redhat.com>
> ---
> hw/net/e1000.c | 7 +++++++
> 1 file changed, 7 insertions(+)
I can not find the reproducer in the repository, have you sent one?
next prev parent reply other threads:[~2021-12-16 9:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 16:10 [PATCH] e1000: fix tx re-entrancy problem Jon Maloy
2021-10-27 4:40 ` Jason Wang
2021-12-16 9:36 ` Philippe Mathieu-Daudé [this message]
2021-12-16 15:51 ` Jon Maloy
2021-12-16 18:35 ` Philippe Mathieu-Daudé
2021-12-16 19:01 ` Alexander Bulekov
2021-12-16 20:22 ` Jon Maloy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61ba1305-321a-1de2-a399-e7b608e4dad4@redhat.com \
--to=philmd@redhat.com \
--cc=alxndr@redhat.com \
--cc=jasowang@redhat.com \
--cc=jmaloy@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.