From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 611DE366 for ; Thu, 12 Jan 2023 04:34:56 +0000 (UTC) Received: by mail-lf1-f47.google.com with SMTP id f34so26657888lfv.10 for ; Wed, 11 Jan 2023 20:34:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0JjWYRu/kVfVhVMQzk2HzUkqzGw62vTtAvDUcCRIg2Q=; b=xnCH+90vro8HMqVxbQWy0+QpP1RoJllaC7vgNWkMXosA1sjMcQG3WXug2Xm3w1gWDc 54BbU2npxmYPjPpuB4OM00Jqjm+OGTqeM4yH6GTJgMDjBtfiZ2anhtAcR8WL+USGjN+w oPt5/OL1Gu24THz9dqppSYQ8wW3dkFnerIrZezOK87RIIyA89U29icART7QawzY+TyZr n6DFmUYUR3I4xTs3LtU+5DS3R4zrE/XEbY4kzSa99C8m7Z/mUBkxtJwOmYs/mB1ssces AyCzScDZf/LHR/rSv3T4+gedsPtapZ1b3DyzjV2bUO8zKXEAjMA2ikUhwkB4+PDLshed W5sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0JjWYRu/kVfVhVMQzk2HzUkqzGw62vTtAvDUcCRIg2Q=; b=Dcb3+w5Buw8qs+zL4JSZIrjDyiMskyCM/uKqIsfuioI0CqrUbPws+Q4Y3Uuw/kRRJz byY9jJ/4RSlzURzNoYZogmBX6VrXE9VHVn3dSRO+Ffl3VFcp7SsUskc2DBiWDS4yG1WE m5JqT6qNDVM4yC0DQ14hE8Nw64QMKH0W9PDUUq1i3n/5ZTBvZp4uIgE219m7VM/vkMV0 +RAsstLrtpUM/sirMHPDGcLwMePivSbvipqOoE5FLNaSwxS4Ewtu6CLhiU/mvc42yln4 pZDK8bdjfcFqigdsyuRmPn/+++ecUW1mJmr6fZnnNrvozWtHgQxEGJlVKfhC9xcdLFv3 Ik0w== X-Gm-Message-State: AFqh2kquavGhKbxQ/J80Szw8HgseSCSKM45mG9iNV6uTiNQYe4ulIy13 BPtxf3rYIGMzUrironWDHfrZbA== X-Google-Smtp-Source: AMrXdXvswYjzkwcjW1IFhBRPRCljQyY1mVGS2bVSnl2yzozkT8fVqnMJ/f+zrekqCZdDq6TGM/o/JA== X-Received: by 2002:a05:6512:c03:b0:4b5:a4ef:fca3 with SMTP id z3-20020a0565120c0300b004b5a4effca3mr24625783lfu.38.1673498094415; Wed, 11 Jan 2023 20:34:54 -0800 (PST) Received: from ?IPV6:2001:14ba:a085:4d00::8a5? (dzccz6yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a085:4d00::8a5]) by smtp.gmail.com with ESMTPSA id x22-20020a0565123f9600b004b52aed44besm3078302lfa.25.2023.01.11.20.34.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Jan 2023 20:34:53 -0800 (PST) Message-ID: <61ba2880-6784-1014-a7a2-a1eecc4e810e@linaro.org> Date: Thu, 12 Jan 2023 06:34:52 +0200 Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v10 0/9] Register Type-C mode-switch in DP bridge endpoints Content-Language: en-GB To: Pin-yen Lin , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J . Wysocki" , Prashant Malani , Benson Leung , Guenter Roeck Cc: Stephen Boyd , =?UTF-8?Q?N=c3=adcolas_F_=2e_R_=2e_A_=2e_Prado?= , Marek Vasut , AngeloGioacchino Del Regno , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, Javier Martinez Canillas , Lyude Paul , chrome-platform@lists.linux.dev, Xin Ji , Thomas Zimmermann , linux-kernel@vger.kernel.org, Allen Chen , linux-acpi@vger.kernel.org, Hsin-Yi Wang , Douglas Anderson , Imre Deak , Jani Nikula , =?UTF-8?B?Sm9zw6kgRXhww7NzaXRv?= , Kees Cook , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , shaomin Deng References: <20230112042104.4107253-1-treapking@chromium.org> From: Dmitry Baryshkov In-Reply-To: <20230112042104.4107253-1-treapking@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/01/2023 06:20, Pin-yen Lin wrote: > > This series introduces bindings for anx7625/it6505 to register Type-C > mode-switch in their output endpoints, and use data-lanes property to > describe the pin connections. Please cc everybody on all patches. Having received just a single patch made me spend time on having to look them up on lore. > > The first two patch modifies fwnode_graph_devcon_matches and > cros_typec_init_ports to enable the registration of the switches. > > Patch 4~6 introduce the bindings for anx7625 and the corresponding driver > modifications. > > Patch 7~9 add similar bindings and driver changes for it6505. > > v9: https://lore.kernel.org/all/20230109084101.265664-1-treapking@chromium.org/ > v8: https://lore.kernel.org/all/20230107102231.23682-1-treapking@chromium.org/ > v7: https://lore.kernel.org/all/20230105132457.4125372-1-treapking@chromium.org/ > v6: https://lore.kernel.org/all/20221124102056.393220-1-treapking@chromium.org/ > v5: https://lore.kernel.org/linux-usb/20220622173605.1168416-1-pmalani@chromium.org/ > > Changes in v10: > - Collected Reviewed-by and Tested-by tags > - Replaced "void *" with "typec_mux_set_fn_t" for mux_set callbacks > - Print out the node name when errors on parsing DT > - Use dev_dbg instead of dev_warn when no Type-C switch nodes available > - Made the return path of drm_dp_register_mode_switch clearer > - Added a TODO for implementing orientation switch for anx7625 > - Updated the commit message for the absence of orientation switch > - Fixed typo in the commit message > > Changes in v9: > - Collected Reviewed-by tag > - Fixed subject prefix again > - Changed the naming of the example node for it6505 > > Changes in v8: > - Fixed the build issue when CONFIG_TYPEC=m > - Fixed some style issues > - Fixed the subject prefixes for the bindings patch > - Fixed the bindings for data-lanes properties > > Changes in v7: > - Fix the long comment lines > - Extracted the common codes to a helper function > - Fixed style issues in anx7625 driver > - Removed DT property validation in anx7625 driver. > - Fixed style issues in it6505 driver > - Removed the redundant sleep in it6505 driver > - Removed DT property validation in it6505 driver > - Rebased to drm-misc-next > - Fixed indentations in bindings patches > - Added a new patch to fix indentations in Kconfig > > Changes in v6: > - Changed it6505_typec_mux_set callback function to accommodate with > the latest drm-misc patches > - Changed the driver implementation to accommodate with the new binding > - Dropped typec-switch binding and use endpoints and data-lanes properties > to describe the pin connections > - Added new patches (patch 1,2,4) to fix probing issues > - Changed the bindings of it6505/anx7625 and modified the drivers > accordingly > - Merged it6505/anx7625 driver changes into a single patch > > Pin-yen Lin (7): > drm/display: Add Type-C switch helpers > dt-bindings: display: bridge: anx7625: Add mode-switch support > drm/bridge: anx7625: Check for Type-C during panel registration > drm/bridge: anx7625: Register Type C mode switches > dt-bindings: display: bridge: it6505: Add mode-switch support > drm/bridge: it6505: Fix Kconfig indentation > drm/bridge: it6505: Register Type C mode switches > > Prashant Malani (2): > device property: Add remote endpoint to devcon matcher > platform/chrome: cros_ec_typec: Purge blocking switch devlinks > > .../display/bridge/analogix,anx7625.yaml | 99 ++++++++++++- > .../bindings/display/bridge/ite,it6505.yaml | 93 ++++++++++-- > drivers/base/property.c | 15 ++ > drivers/gpu/drm/bridge/Kconfig | 21 +-- > drivers/gpu/drm/bridge/analogix/Kconfig | 1 + > drivers/gpu/drm/bridge/analogix/anx7625.c | 105 +++++++++++++- > drivers/gpu/drm/bridge/analogix/anx7625.h | 13 ++ > drivers/gpu/drm/bridge/ite-it6505.c | 119 +++++++++++++++- > drivers/gpu/drm/display/drm_dp_helper.c | 134 ++++++++++++++++++ > drivers/platform/chrome/cros_ec_typec.c | 10 ++ > include/drm/display/drm_dp_helper.h | 17 +++ > 11 files changed, 598 insertions(+), 29 deletions(-) > -- With best wishes Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8AF38C54EBC for ; Thu, 12 Jan 2023 04:34:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7E79510E86F; Thu, 12 Jan 2023 04:34:57 +0000 (UTC) Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1693710E86F for ; Thu, 12 Jan 2023 04:34:56 +0000 (UTC) Received: by mail-lf1-x131.google.com with SMTP id j17so26714475lfr.3 for ; Wed, 11 Jan 2023 20:34:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0JjWYRu/kVfVhVMQzk2HzUkqzGw62vTtAvDUcCRIg2Q=; b=xnCH+90vro8HMqVxbQWy0+QpP1RoJllaC7vgNWkMXosA1sjMcQG3WXug2Xm3w1gWDc 54BbU2npxmYPjPpuB4OM00Jqjm+OGTqeM4yH6GTJgMDjBtfiZ2anhtAcR8WL+USGjN+w oPt5/OL1Gu24THz9dqppSYQ8wW3dkFnerIrZezOK87RIIyA89U29icART7QawzY+TyZr n6DFmUYUR3I4xTs3LtU+5DS3R4zrE/XEbY4kzSa99C8m7Z/mUBkxtJwOmYs/mB1ssces AyCzScDZf/LHR/rSv3T4+gedsPtapZ1b3DyzjV2bUO8zKXEAjMA2ikUhwkB4+PDLshed W5sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0JjWYRu/kVfVhVMQzk2HzUkqzGw62vTtAvDUcCRIg2Q=; b=hkmSbwM1kBdODrCBVQy3HblVK6mzoUBQG5co8M7pVMbf6xGO8m3dORJeyWPOpQ+T2e nMu0JpPYLqqundyc6zpQfwfVxMBYQt02+dfM7yKdlDEE1A6rM4GQXoGyEFSyqXqqUlDO gET08uRPQ1XkxnexbIGQ+8xbpvNwED9ujjbSPGBlSnyIR572CB+ZdT+WtJqbQrYg717X QL2W381ZHmOkwTXJzSG+GsRKe2ZMS0ZJVyALOIotS6F6wfcozcwWMvyAHJkDrA1iOlOf mYlAq5jWxLhqds3YbNQKymd+FC8fWVRIV0pvsgIr/FB58u0awg1GxKXNV0u8sa7loeAr LxqQ== X-Gm-Message-State: AFqh2krhEL4yR5xvRkiqwJkoBGpMYIdYZ1WMiVoTTvBUG4wJy3usqpaz ++4s1cS+t0lcG/pfa9YDOIabwg== X-Google-Smtp-Source: AMrXdXvswYjzkwcjW1IFhBRPRCljQyY1mVGS2bVSnl2yzozkT8fVqnMJ/f+zrekqCZdDq6TGM/o/JA== X-Received: by 2002:a05:6512:c03:b0:4b5:a4ef:fca3 with SMTP id z3-20020a0565120c0300b004b5a4effca3mr24625783lfu.38.1673498094415; Wed, 11 Jan 2023 20:34:54 -0800 (PST) Received: from ?IPV6:2001:14ba:a085:4d00::8a5? (dzccz6yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a085:4d00::8a5]) by smtp.gmail.com with ESMTPSA id x22-20020a0565123f9600b004b52aed44besm3078302lfa.25.2023.01.11.20.34.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Jan 2023 20:34:53 -0800 (PST) Message-ID: <61ba2880-6784-1014-a7a2-a1eecc4e810e@linaro.org> Date: Thu, 12 Jan 2023 06:34:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v10 0/9] Register Type-C mode-switch in DP bridge endpoints Content-Language: en-GB To: Pin-yen Lin , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J . Wysocki" , Prashant Malani , Benson Leung , Guenter Roeck References: <20230112042104.4107253-1-treapking@chromium.org> From: Dmitry Baryshkov In-Reply-To: <20230112042104.4107253-1-treapking@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Marek Vasut , chrome-platform@lists.linux.dev, Javier Martinez Canillas , linux-acpi@vger.kernel.org, =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , devicetree@vger.kernel.org, Kees Cook , =?UTF-8?Q?N=c3=adcolas_F_=2e_R_=2e_A_=2e_Prado?= , Jani Nikula , Allen Chen , Stephen Boyd , Hsin-Yi Wang , Xin Ji , AngeloGioacchino Del Regno , shaomin Deng , Douglas Anderson , Thomas Zimmermann , =?UTF-8?B?Sm9zw6kgRXhww7NzaXRv?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 12/01/2023 06:20, Pin-yen Lin wrote: > > This series introduces bindings for anx7625/it6505 to register Type-C > mode-switch in their output endpoints, and use data-lanes property to > describe the pin connections. Please cc everybody on all patches. Having received just a single patch made me spend time on having to look them up on lore. > > The first two patch modifies fwnode_graph_devcon_matches and > cros_typec_init_ports to enable the registration of the switches. > > Patch 4~6 introduce the bindings for anx7625 and the corresponding driver > modifications. > > Patch 7~9 add similar bindings and driver changes for it6505. > > v9: https://lore.kernel.org/all/20230109084101.265664-1-treapking@chromium.org/ > v8: https://lore.kernel.org/all/20230107102231.23682-1-treapking@chromium.org/ > v7: https://lore.kernel.org/all/20230105132457.4125372-1-treapking@chromium.org/ > v6: https://lore.kernel.org/all/20221124102056.393220-1-treapking@chromium.org/ > v5: https://lore.kernel.org/linux-usb/20220622173605.1168416-1-pmalani@chromium.org/ > > Changes in v10: > - Collected Reviewed-by and Tested-by tags > - Replaced "void *" with "typec_mux_set_fn_t" for mux_set callbacks > - Print out the node name when errors on parsing DT > - Use dev_dbg instead of dev_warn when no Type-C switch nodes available > - Made the return path of drm_dp_register_mode_switch clearer > - Added a TODO for implementing orientation switch for anx7625 > - Updated the commit message for the absence of orientation switch > - Fixed typo in the commit message > > Changes in v9: > - Collected Reviewed-by tag > - Fixed subject prefix again > - Changed the naming of the example node for it6505 > > Changes in v8: > - Fixed the build issue when CONFIG_TYPEC=m > - Fixed some style issues > - Fixed the subject prefixes for the bindings patch > - Fixed the bindings for data-lanes properties > > Changes in v7: > - Fix the long comment lines > - Extracted the common codes to a helper function > - Fixed style issues in anx7625 driver > - Removed DT property validation in anx7625 driver. > - Fixed style issues in it6505 driver > - Removed the redundant sleep in it6505 driver > - Removed DT property validation in it6505 driver > - Rebased to drm-misc-next > - Fixed indentations in bindings patches > - Added a new patch to fix indentations in Kconfig > > Changes in v6: > - Changed it6505_typec_mux_set callback function to accommodate with > the latest drm-misc patches > - Changed the driver implementation to accommodate with the new binding > - Dropped typec-switch binding and use endpoints and data-lanes properties > to describe the pin connections > - Added new patches (patch 1,2,4) to fix probing issues > - Changed the bindings of it6505/anx7625 and modified the drivers > accordingly > - Merged it6505/anx7625 driver changes into a single patch > > Pin-yen Lin (7): > drm/display: Add Type-C switch helpers > dt-bindings: display: bridge: anx7625: Add mode-switch support > drm/bridge: anx7625: Check for Type-C during panel registration > drm/bridge: anx7625: Register Type C mode switches > dt-bindings: display: bridge: it6505: Add mode-switch support > drm/bridge: it6505: Fix Kconfig indentation > drm/bridge: it6505: Register Type C mode switches > > Prashant Malani (2): > device property: Add remote endpoint to devcon matcher > platform/chrome: cros_ec_typec: Purge blocking switch devlinks > > .../display/bridge/analogix,anx7625.yaml | 99 ++++++++++++- > .../bindings/display/bridge/ite,it6505.yaml | 93 ++++++++++-- > drivers/base/property.c | 15 ++ > drivers/gpu/drm/bridge/Kconfig | 21 +-- > drivers/gpu/drm/bridge/analogix/Kconfig | 1 + > drivers/gpu/drm/bridge/analogix/anx7625.c | 105 +++++++++++++- > drivers/gpu/drm/bridge/analogix/anx7625.h | 13 ++ > drivers/gpu/drm/bridge/ite-it6505.c | 119 +++++++++++++++- > drivers/gpu/drm/display/drm_dp_helper.c | 134 ++++++++++++++++++ > drivers/platform/chrome/cros_ec_typec.c | 10 ++ > include/drm/display/drm_dp_helper.h | 17 +++ > 11 files changed, 598 insertions(+), 29 deletions(-) > -- With best wishes Dmitry