From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 06/37] drm/i915: Move rate-limiting request retire to after submission Date: Fri, 29 Jun 2018 11:00:30 +0100 Message-ID: <61bf56cc-08c3-5014-c822-f20cd8d3f0f2@linux.intel.com> References: <20180629075348.27358-1-chris@chris-wilson.co.uk> <20180629075348.27358-6-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9F97D6EF8B for ; Fri, 29 Jun 2018 10:00:33 +0000 (UTC) In-Reply-To: <20180629075348.27358-6-chris@chris-wilson.co.uk> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDI5LzA2LzIwMTggMDg6NTMsIENocmlzIFdpbHNvbiB3cm90ZToKPiBPdXIgbG9uZyBzdGFu ZGluZyBkZWZlbnNlIGFnYWluc3QgYSBzaW5nbGUgY2xpZW50IGZyb20gZmxvb2RpbmcgdGhlCj4g c3lzdGVtIHdpdGggcmVxdWVzdHMgKGNhdXNpbmcgbWVtcHJlc3N1cmUgYW5kIHN0YWxscyBhY3Jv c3MgdGhlIHdob2xlCj4gc3lzdGVtKSBpcyB0byByZXRpcmUgdGhlIG9sZCByZXF1ZXN0IG9uIGV2 ZXJ5IGFsbG9jYXRpb24uIChCeSByZXRpcmluZwo+IHRoZSBvbGRlc3QsIHdlIHRyeSB0byBrZWVw IHJldHVybmluZyByZXF1ZXN0cyBiYWNrIHRvIHRoZSBzeXN0ZW0gaW4gYQo+IHN0ZWFkeSBmbG93 LikgVGhpcyBhZGRzIGFuIGV4dHJhIHN0ZXAgaW50byB0aGUgc3VibWlzc2lvbiBwYXRoIHRoYXQg d2UKPiBjYW4gcmVkdWNlIHNpbXBseSBieSBtb3ZpbmcgaXQgdG8gYWZ0ZXIgdGhlIHN1Ym1pc3Np b24gaXRzZWxmLgo+IAo+IFdlIGFscmVhZHkgZG8gdHJ5IHRvIGNsZWFuIHVwIGEgc3RhbGUgcmVx dWVzdCBsaXN0IGFmdGVyIHN1Ym1pc3Npb24sIHNvCj4gYWx3YXlzIHJldGlyaW5nIGFsbCBjb21w bGV0ZWQgcmVxdWVzdHMgZml0cyBpbiBhcyBhIG5hdHVyYWwgZXh0ZW5zaW9uLgoKUGxlYXNlIGFk ZCB0byB0aGUgY29tbWl0IG1lc3NhZ2Ugd2hhdCBtb3RpdmF0ZWQgeW91IHRvIGRvIHRoaXMuIExp a2UgCnRoaXMgYmVuY2htYXJrLCBvciBzb21ldGhpbmcsIGlzIG5vdyBiZXR0ZXIgaW4gdGhpcyBv ciB0aGF0IHJlc3BlY3QuIE9yIApzb21ldGhpbmcuCgpSZWdhcmRzLAoKVHZydGtvCgo+IAo+IFNp Z25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENj OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+IC0tLQo+ICAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZXF1ZXN0LmMgfCAyNiArKysrKysrKysrKysrKysrKyst LS0tLS0tLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDE4IGluc2VydGlvbnMoKyksIDggZGVsZXRpb25z KC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVxdWVzdC5j IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZXF1ZXN0LmMKPiBpbmRleCBhMmY3ZTkzNTg0 NTAuLjRlZWE3YTI3MjkxZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X3JlcXVlc3QuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVxdWVzdC5jCj4g QEAgLTY5NCwxMiArNjk0LDYgQEAgaTkxNV9yZXF1ZXN0X2FsbG9jKHN0cnVjdCBpbnRlbF9lbmdp bmVfY3MgKmVuZ2luZSwgc3RydWN0IGk5MTVfZ2VtX2NvbnRleHQgKmN0eCkKPiAgIAlpZiAocmV0 KQo+ICAgCQlnb3RvIGVycl91bnJlc2VydmU7Cj4gICAKPiAtCS8qIE1vdmUgb3VyIG9sZGVzdCBy ZXF1ZXN0IHRvIHRoZSBzbGFiLWNhY2hlIChpZiBub3QgaW4gdXNlISkgKi8KPiAtCXJxID0gbGlz dF9maXJzdF9lbnRyeSgmY2UtPnJpbmctPnJlcXVlc3RfbGlzdCwgdHlwZW9mKCpycSksIHJpbmdf bGluayk7Cj4gLQlpZiAoIWxpc3RfaXNfbGFzdCgmcnEtPnJpbmdfbGluaywgJmNlLT5yaW5nLT5y ZXF1ZXN0X2xpc3QpICYmCj4gLQkgICAgaTkxNV9yZXF1ZXN0X2NvbXBsZXRlZChycSkpCj4gLQkJ aTkxNV9yZXF1ZXN0X3JldGlyZShycSk7Cj4gLQo+ICAgCS8qCj4gICAJICogQmV3YXJlOiBEcmFn b25zIGJlIGZseWluZyBvdmVyaGVhZC4KPiAgIAkgKgo+IEBAIC0xMTEwLDYgKzExMDQsOCBAQCB2 b2lkIGk5MTVfcmVxdWVzdF9hZGQoc3RydWN0IGk5MTVfcmVxdWVzdCAqcmVxdWVzdCkKPiAgIAls b2NhbF9iaF9lbmFibGUoKTsgLyogS2ljayB0aGUgZXhlY2xpc3RzIHRhc2tsZXQgaWYganVzdCBz Y2hlZHVsZWQgKi8KPiAgIAo+ICAgCS8qCj4gKwkgKiBNb3ZlIG91ciBvbGRlc3QgcmVxdWVzdHMg dG8gdGhlIHNsYWItY2FjaGUgKGlmIG5vdCBpbiB1c2UhKQo+ICsJICoKPiAgIAkgKiBJbiB0eXBp Y2FsIHNjZW5hcmlvcywgd2UgZG8gbm90IGV4cGVjdCB0aGUgcHJldmlvdXMgcmVxdWVzdCBvbgo+ ICAgCSAqIHRoZSB0aW1lbGluZSB0byBiZSBzdGlsbCB0cmFja2VkIGJ5IHRpbWVsaW5lLT5sYXN0 X3JlcXVlc3QgaWYgaXQKPiAgIAkgKiBoYXMgYmVlbiBjb21wbGV0ZWQuIElmIHRoZSBjb21wbGV0 ZWQgcmVxdWVzdCBpcyBzdGlsbCBoZXJlLCB0aGF0Cj4gQEAgLTExMjYsOCArMTEyMiwyMiBAQCB2 b2lkIGk5MTVfcmVxdWVzdF9hZGQoc3RydWN0IGk5MTVfcmVxdWVzdCAqcmVxdWVzdCkKPiAgIAkg KiB3b3JrIG9uIGJlaGFsZiBvZiBvdGhlcnMgLS0gYnV0IGluc3RlYWQgd2Ugc2hvdWxkIGJlbmVm aXQgZnJvbQo+ICAgCSAqIGltcHJvdmVkIHJlc291cmNlIG1hbmFnZW1lbnQuIChXZWxsLCB0aGF0 J3MgdGhlIHRoZW9yeSBhdCBsZWFzdC4pCj4gICAJICovCj4gLQlpZiAocHJldiAmJiBpOTE1X3Jl cXVlc3RfY29tcGxldGVkKHByZXYpKQo+IC0JCWk5MTVfcmVxdWVzdF9yZXRpcmVfdXB0byhwcmV2 KTsKPiArCWRvIHsKPiArCQlwcmV2ID0gbGlzdF9maXJzdF9lbnRyeSgmcmluZy0+cmVxdWVzdF9s aXN0LAo+ICsJCQkJCXR5cGVvZigqcHJldiksIHJpbmdfbGluayk7Cj4gKwo+ICsJCS8qCj4gKwkJ ICogS2VlcCB0aGUgY3VycmVudCByZXF1ZXN0LCB0aGUgY2FsbGVyIG1heSBub3QgYmUKPiArCQkg KiBleHBlY3RpbmcgaXQgdG8gYmUgcmV0aXJlZCAoYW5kIGZyZWVkISkgaW1tZWRpYXRlbHksCj4g KwkJICogYW5kIHByZXNlcnZpbmcgb25lIHJlcXVlc3QgZnJvbSB0aGUgY2xpZW50IGFsbG93cyB1 cyB0bwo+ICsJCSAqIGNhcnJ5IGZvcndhcmQgZnJlcXVlbnRseSByZXVzZWQgc3RhdGUgb250byB0 aGUgbmV4dAo+ICsJCSAqIHN1Ym1pc3Npb24uCj4gKwkJICovCj4gKwkJaWYgKHByZXYgPT0gcmVx dWVzdCB8fCAhaTkxNV9yZXF1ZXN0X2NvbXBsZXRlZChwcmV2KSkKPiArCQkJYnJlYWs7Cj4gKwo+ ICsJCWk5MTVfcmVxdWVzdF9yZXRpcmUocHJldik7Cj4gKwl9IHdoaWxlICgxKTsKPiAgIH0KPiAg IAo+ICAgc3RhdGljIHVuc2lnbmVkIGxvbmcgbG9jYWxfY2xvY2tfdXModW5zaWduZWQgaW50ICpj cHUpCj4gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCklu dGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=