From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D34137A84F for ; Tue, 11 Aug 2026 13:30:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786455023; cv=none; b=L1IlMAnyzybX0vwVB+/hAe2QZy59plc9d3dgZW/D1OmO+gbkR/QZwn08ft+D3NWSAH9RWPcbXSnQmAD0V4kDoCImzKGD6xPYJB9yWExP03tBAhNO1e/5PSyGH1XIPFzcsC/kBTAmkP3YdHSvj20U+3/keebqaFQRfGI6Wu1mDCM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786455023; c=relaxed/simple; bh=SYnOgk4fjAS1DNyJ76z0EyhamP/1F1KRjfEg70VPxio=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eZuZzGA9xuhTad6xD5usst7E8/SpxH2lhn+lxu9GsgtD4QHeQRbo4YqbXNxSlq8dF1xdVb1a39Ku/liS0WFOYn18NYrjOGc8877UG6geYuh3DH2cvENrpJKJ/URyumgdTOgeELJZdmkfC/zxHtJrzwzBYky8OVEOYvUOrmvaNy8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=IHEeUV/+; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=SFjz+Z4N; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IHEeUV/+"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="SFjz+Z4N" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1786455018; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=343Vv4nwV5gIHpPMrByAKq2+ZRg+6KdX8JoUQb2ghhk=; b=IHEeUV/+9mt0/icWBNZeeuLlbMuxXdrKrh88qBCLO02vjuh+vYbTPpCGYfCV14wVaLnXAY XMHlEJcCGkIHcBtT47qrLZ8uROVIJ1xH0WwWwQ2sXKb5E1Q2BvBBrgNG7ALFBJHFpMohje FSBrRcqcHgXW8EANZA2dAy0yx9rh7xM= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-628-erWdedVQOMG7ABnYDAILeg-1; Tue, 11 Aug 2026 09:30:17 -0400 X-MC-Unique: erWdedVQOMG7ABnYDAILeg-1 X-Mimecast-MFC-AGG-ID: erWdedVQOMG7ABnYDAILeg_1786455016 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4994cf6cdb9so20327805e9.3 for ; Tue, 11 Aug 2026 06:30:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1786455016; x=1787059816; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=343Vv4nwV5gIHpPMrByAKq2+ZRg+6KdX8JoUQb2ghhk=; b=SFjz+Z4Ni/BZhQ0Emw9wfXz4/SPv5q2jEfB/WSh+gr8NTnDMh4KNnKVvFf9JSfWBe2 pzv5eSNSxaa1INT1i8+yzExorjK4nEbnINGUZoZuWzN6cQO4hqX6rZ9F7R01jSptboWT /9MUVmUr3ZtVVKK9AfFJMDLze38Ml734tFw1BoJfKbUhn9tIB6Rk7vitb3NpEiifan7E zGDt4621cAIjpBrFnJXJ9SvatztRTHA7fJMMeKrSwAjdHOtIy3OH6IHEwxJ6M6YaknGb a564vpRRUDRA1KFZUyL71C5+DcgcVRkXOOLWPQtOY7TbDEcrYbTTy3Dht9g+sbKagfAl 3g5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786455016; x=1787059816; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=343Vv4nwV5gIHpPMrByAKq2+ZRg+6KdX8JoUQb2ghhk=; b=LzE4EPVzi+8eJ2hngkPk/W3WXaCloLLq1RS+5+L2zLbXeRAdmrjjz2D4LRHYvmcX+y 1j8aHo01VLDZ1zIHEslMHoNKa/IV2PJ6PtXxLG+l+ecyNZlg+gRg/nwcgq7kvEFVy7Tu vaPQunF04xDEdMCS0JgdbGm9/BKMruwrI4y68zu/jKkAov30kPOctUrylkSQloshF7OY EBGnXEdv7lExGam71fxcmgjnB8IUfPc2tnb7A7Y/lTX55N6tGBq2PBdkuGCr6PTVQcZL 2uiaCX9S4VVpmI+JaEkftNWWd/XLAAi2n4EsScI5Bq7GuQ1kb3H2R3LCZSeH/WIZjNUQ uhXQ== X-Forwarded-Encrypted: i=1; AHgh+Rqs7IMSVYK1Fhmg/1ieE/+d962LpjWz35QKbbhhT/tmGTP3t+bgB8C99I2SOo9FXmGjKoGuqSZ6QEpGQ/k=@vger.kernel.org X-Gm-Message-State: AOJu0YwrKUQe0xXCw3bNfmUY143AYNl/2HW/4UeBrUfZ7XUDHOLi3Wz/ Kj0Sf2H9M8GhymwQ4b6gNNVeCEwkWDfg+Ig+75mmyHjMErl6ILftcuRDPgLs1PpmZNs/+xskPH9 +5tj2Zt2iC75hzRD+Q5DQIDdhURQThuXgiLc/VMuMAFPJwR0K9mlQxhiyY/Vr74tz7g== X-Gm-Gg: AR+sD13w0BGgBDjU5SN8n3nIsjzA20fyle6Ko04GpJ5AeX5ebHagnOf2bSN1cmpnASW uDUnZ5kYGXXzjLrEajikUpXuXy7ivgZjAgR0+bE/P8ObD4TmbrRq0bQnOKp5H29IuRrqe5FW/8z PyabdeY/Eq4bxiGPJGNKxm14EkGB+iaDIms+9sys6m/L8VtRlaSQ6+/kwmAwxvN3R24l6uJLkT9 U0eC78YhuqggKY6V2DZsc2Hp6Sx6H4uD99ik+rVfgXJiOlilEiXN8FaDzmJmkNOVo91cE3lWIOi QzV2F6fUyX0FazUvHzvb6YL63q6V8/2vg63/0BpqP+hPetU1RLWEIYJEYjv3XcJjaXjniMxygK1 3vC7lepLrzg57wyq5J+vJgCoG2GAumTs+CB8O6GrZMbpijKJAM2ZE/yjUIc0KpPqtz0U2m29Uk/ o= X-Received: by 2002:a05:600c:b93:b0:495:4811:d71c with SMTP id 5b1f17b1804b1-4997846a4e8mr49723235e9.13.1786455015576; Tue, 11 Aug 2026 06:30:15 -0700 (PDT) X-Received: by 2002:a05:600c:b93:b0:495:4811:d71c with SMTP id 5b1f17b1804b1-4997846a4e8mr49721555e9.13.1786455014743; Tue, 11 Aug 2026 06:30:14 -0700 (PDT) Received: from [192.168.188.103] (ip239-44-231-195.pool-bba.aruba.it. [195.231.44.239]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499788f11b8sm53354975e9.10.2026.08.11.06.30.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Aug 2026 06:30:13 -0700 (PDT) Message-ID: <61dd4a2e-ef14-46b6-bfc5-c5b6463deb38@redhat.com> Date: Tue, 11 Aug 2026 15:30:12 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v3] net: phylink: treat PSGMII as an inband capable interface To: Sandeep Sondagar , Andrew Lunn Cc: Russell King , Heiner Kallweit , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Gabor Juhos , Robert Marko , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260809-phylink-psgmii-v3-1-908dcd3a9e3d@gmail.com> From: Paolo Abeni Content-Language: en-US In-Reply-To: <20260809-phylink-psgmii-v3-1-908dcd3a9e3d@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/9/26 6:01 PM, Sandeep Sondagar wrote: > PSGMII (the Qualcomm 5-port SGMII) conveys the link negotiation result > from the PHY back to the MAC through per-channel in-band SGMII words, > exactly like SGMII and QSGMII. > > However, PHY_INTERFACE_MODE_PSGMII is missing from > phylink_get_inband_type(), so phylink reports INBAND_NONE for it and > phylink_pcs_neg_mode() falls back to PHYLINK_PCS_NEG_NONE. The PCS is > then programmed in force mode and its control-register speed bits (which > default to 1000base) are used, so a slower copper link - e.g. 100base-T > - is reported as 1Gbps and cannot pass traffic. > > Classify PSGMII alongside SGMII and QSGMII as INBAND_CISCO_SGMII so the > PCS negotiates in-band and the resolved link speed comes from the PHY > in-band word. > > Also add PSGMII to the generic clause 22 PCS helper functions which > handle the SGMII in-band word. Without this, a PCS using these helpers > would still fall through to the default handling and force the link > state to false in phylink_mii_c22_pcs_decode_state(), fail to encode > the SGMII advertisement, and get rejected by phylink_get_link_timer_ns(). > > Fixes: 83b5f0253b1e ("net: phy: Introduce PSGMII PHY interface mode") > Signed-off-by: Sandeep Sondagar Sashiko noted no in-tree driver is affected. At very least, this should go via the net-next tree without any fixes tag, but I'm wondering if we want it at all? @Andrew: WDYT? Thanks, Paolo