From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Subject: Re: [PATCH 09/23] drm/i915: Use b->irq_enable() as
 predicate for mock engine
Date: Thu, 17 Jan 2019 16:44:54 +0000
Message-ID: <61de849d-be78-bcee-a653-ef7ba68e7974@linux.intel.com>
References: <20190117143519.16086-1-chris@chris-wilson.co.uk>
 <20190117143519.16086-10-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 59D6E6E3DC
 for <intel-gfx@lists.freedesktop.org>; Thu, 17 Jan 2019 16:44:54 +0000 (UTC)
In-Reply-To: <20190117143519.16086-10-chris@chris-wilson.co.uk>
Content-Language: en-US
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

Ck9uIDE3LzAxLzIwMTkgMTQ6MzQsIENocmlzIFdpbHNvbiB3cm90ZToKPiBTaW5jZSBjb21taXQg
IGQ0Y2NjZWIwNTU5MSAoImRybS9pOTE1L2ljbDogUmluZ2J1ZmZlciBpbnRlcnJ1cHQgaGFuZGxp
bmciKQo+IHdlIGhhdmUgcmVxdWlyZWQgYSBtZWNoYW5pc20gdG8gYXZvaWQgdG91Y2hpbmcgdGhl
IGludGVycnVwdCBoYXJkd2FyZQo+IGZvciBicmVhZGNydW1icywgc3VwZXJzZWRpbmcgb3VyIG1v
Y2sgaW50ZXJmYWNlIGZvciBzZWxmdGVzdHMuCj4gCj4gUmVmZXJlbmNlczogZDRjY2NlYjA1NTkx
ICgiZHJtL2k5MTUvaWNsOiBSaW5nYnVmZmVyIGludGVycnVwdCBoYW5kbGluZyIpCj4gU2lnbmVk
LW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gLS0tCj4g
ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9icmVhZGNydW1icy5jICAgICB8IDM5ICsrKysr
KysrLS0tLS0tLS0tLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9lbmdpbmVfY3Mu
YyAgICAgICB8IDExICsrLS0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1
ZmZlci5oICAgICAgfCAgMSAtCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9zZWxmdGVzdHMvbW9j
a19lbmdpbmUuYyB8ICAxIC0KPiAgIDQgZmlsZXMgY2hhbmdlZCwgMjAgaW5zZXJ0aW9ucygrKSwg
MzIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu
dGVsX2JyZWFkY3J1bWJzLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9icmVhZGNydW1i
cy5jCj4gaW5kZXggNGVkNzEwNWQ3ZmY1Li43YjUxN2JmODM1MDcgMTAwNjQ0Cj4gLS0tIGEvZHJp
dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYnJlYWRjcnVtYnMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1
L2RybS9pOTE1L2ludGVsX2JyZWFkY3J1bWJzLmMKPiBAQCAtMTU4LDYgKzE1OCw5IEBAIHN0YXRp
YyB2b2lkIGludGVsX2JyZWFkY3J1bWJzX2Zha2VfaXJxKHN0cnVjdCB0aW1lcl9saXN0ICp0KQo+
ICAgCj4gICBzdGF0aWMgdm9pZCBpcnFfZW5hYmxlKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVu
Z2luZSkKPiAgIHsKPiArCWlmICghZW5naW5lLT5pcnFfZW5hYmxlKQo+ICsJCXJldHVybjsKPiAr
Cj4gICAJLyoKPiAgIAkgKiBGSVhNRTogSWRlYWxseSB3ZSB3YW50IHRoaXMgb24gdGhlIEFQSSBi
b3VuZGFyeSwgYnV0IGZvciB0aGUKPiAgIAkgKiBzYWtlIG9mIHRlc3Rpbmcgd2l0aCBtb2NrIGJy
ZWFkY3J1bWJzIChubyBIVyBzbyB1bmFibGUgdG8KCk9rYXkgSSB0aGluayBJIG1pc3VuZGVyc3Rv
b2QgdGhpcyBwYXRjaCBpbiB0aGUgbGFzdCByb3VuZC4gU28geW91IHdhbnQgCnRvIGF2b2lkIHRo
ZSBHRU1fQlVHX09OIGJlbG93IF9hbmRfIGEgZGVkaWNhdGVkIGJvb2xlYW4gb25seSBmb3IgdGhl
IAptb2NrIGVuZ2luZS4KCkkgb25seSB3b25kZXIgb24gdGhlIHJlbWFpbmluZyBtZXJpdCBvZiB0
aGlzIGNvbW1lbnQgYW5kIGFjdHVhbGx5IGEgCkdFTV9CVUdfT04sIHdoaWNoIHdpbGwgYmUgaGl0
IGFuZCBtaXNzIGRlcGVuZGluZyBvbiB0aGUgcGxhdGZvcm0gbm93LiAKR3V0IGZlZWxpbmcgc2F5
cyBzb21ldGhpbmcgaXMgc3RpbGwgbm90IGlkZWFsIGhlcmUuIFNlbGZ0ZXN0cyB2YXJpYWJsZSAK
ZG9lcyBhY3R1YWxseSBmZWVsIGJldHRlciBpbiB0aGlzIHNlbnNlLgoKbW9ja19lbmdpbmUgc2Vl
bXMgb25seSB1c2VkIGZyb20gbW9ja19nZW1fZGV2aWNlLCBzbyBjb3VsZCBhbiAKYWx0ZXJuYXRp
dmUgYmUgdG8gc2V0IGk5MTUtPnJ1bnRpbWVfcG0uaXJxc19lbmFibGVkIHRoZXJlIGFuZCBrZWVw
IHRoZSAKR0VNX0JVR19PTiBpbiBpcnFfZW5hYmxlIGFib3ZlIHRoZSAhZW5naW5lLT5pcnFfZW5h
YmxlIGVhcmx5IHJldHVybj8gClRoYXQgd291bGQgc3RpbGwgcHJvdmlkZSB0aGUgdW5jb25kaXRp
b25hbCBhc3NlcnQgb24gdGhlIHN0YXRlIG9mIHRoZSAKZHJpdmVyIG91dHNpZGUgc2VsZnRlc3Rz
LgoKUmVnYXJkcywKClR2cnRrbwoKPiBAQCAtMTY3LDIxICsxNzAsMjAgQEAgc3RhdGljIHZvaWQg
aXJxX2VuYWJsZShzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gICAJR0VNX0JVR19P
TighaW50ZWxfaXJxc19lbmFibGVkKGVuZ2luZS0+aTkxNSkpOwo+ICAgCj4gICAJLyogQ2FsbGVy
IGRpc2FibGVzIGludGVycnVwdHMgKi8KPiAtCWlmIChlbmdpbmUtPmlycV9lbmFibGUpIHsKPiAt
CQlzcGluX2xvY2soJmVuZ2luZS0+aTkxNS0+aXJxX2xvY2spOwo+IC0JCWVuZ2luZS0+aXJxX2Vu
YWJsZShlbmdpbmUpOwo+IC0JCXNwaW5fdW5sb2NrKCZlbmdpbmUtPmk5MTUtPmlycV9sb2NrKTsK
PiAtCX0KPiArCXNwaW5fbG9jaygmZW5naW5lLT5pOTE1LT5pcnFfbG9jayk7Cj4gKwllbmdpbmUt
PmlycV9lbmFibGUoZW5naW5lKTsKPiArCXNwaW5fdW5sb2NrKCZlbmdpbmUtPmk5MTUtPmlycV9s
b2NrKTsKPiAgIH0KPiAgIAo+ICAgc3RhdGljIHZvaWQgaXJxX2Rpc2FibGUoc3RydWN0IGludGVs
X2VuZ2luZV9jcyAqZW5naW5lKQo+ICAgewo+ICsJaWYgKCFlbmdpbmUtPmlycV9kaXNhYmxlKQo+
ICsJCXJldHVybjsKPiArCj4gICAJLyogQ2FsbGVyIGRpc2FibGVzIGludGVycnVwdHMgKi8KPiAt
CWlmIChlbmdpbmUtPmlycV9kaXNhYmxlKSB7Cj4gLQkJc3Bpbl9sb2NrKCZlbmdpbmUtPmk5MTUt
PmlycV9sb2NrKTsKPiAtCQllbmdpbmUtPmlycV9kaXNhYmxlKGVuZ2luZSk7Cj4gLQkJc3Bpbl91
bmxvY2soJmVuZ2luZS0+aTkxNS0+aXJxX2xvY2spOwo+IC0JfQo+ICsJc3Bpbl9sb2NrKCZlbmdp
bmUtPmk5MTUtPmlycV9sb2NrKTsKPiArCWVuZ2luZS0+aXJxX2Rpc2FibGUoZW5naW5lKTsKPiAr
CXNwaW5fdW5sb2NrKCZlbmdpbmUtPmk5MTUtPmlycV9sb2NrKTsKPiAgIH0KPiAgIAo+ICAgdm9p
ZCBfX2ludGVsX2VuZ2luZV9kaXNhcm1fYnJlYWRjcnVtYnMoc3RydWN0IGludGVsX2VuZ2luZV9j
cyAqZW5naW5lKQo+IEBAIC0yOTMsMjUgKzI5NSwxNiBAQCBzdGF0aWMgYm9vbCBfX2ludGVsX2Jy
ZWFkY3J1bWJzX2VuYWJsZV9pcnEoc3RydWN0IGludGVsX2JyZWFkY3J1bWJzICpiKQo+ICAgCWlm
IChiLT5pcnFfYXJtZWQpCj4gICAJCXJldHVybiBmYWxzZTsKPiAgIAo+IC0JLyogVGhlIGJyZWFk
Y3J1bWIgaXJxIHdpbGwgYmUgZGlzYXJtZWQgb24gdGhlIGludGVycnVwdCBhZnRlciB0aGUKPiAr
CS8qCj4gKwkgKiBUaGUgYnJlYWRjcnVtYiBpcnEgd2lsbCBiZSBkaXNhcm1lZCBvbiB0aGUgaW50
ZXJydXB0IGFmdGVyIHRoZQo+ICAgCSAqIHdhaXRlcnMgYXJlIHNpZ25hbGVkLiBUaGlzIGdpdmVz
IHVzIGEgc2luZ2xlIGludGVycnVwdCB3aW5kb3cgaW4KPiAgIAkgKiB3aGljaCB3ZSBjYW4gYWRk
IGEgbmV3IHdhaXRlciBhbmQgYXZvaWQgdGhlIGNvc3Qgb2YgcmUtZW5hYmxpbmcKPiAgIAkgKiB0
aGUgaXJxLgo+ICAgCSAqLwo+ICAgCWItPmlycV9hcm1lZCA9IHRydWU7Cj4gICAKPiAtCWlmIChJ
OTE1X1NFTEZURVNUX09OTFkoYi0+bW9jaykpIHsKPiAtCQkvKiBGb3Igb3VyIG1vY2sgb2JqZWN0
cyB3ZSB3YW50IHRvIGF2b2lkIGludGVyYWN0aW9uCj4gLQkJICogd2l0aCB0aGUgcmVhbCBoYXJk
d2FyZSAod2hpY2ggaXMgbm90IHNldCB1cCkuIFNvCj4gLQkJICogd2Ugc2ltcGx5IHByZXRlbmQg
d2UgaGF2ZSBlbmFibGVkIHRoZSBwb3dlcndlbGwKPiAtCQkgKiBhbmQgdGhlIGlycSwgYW5kIGxl
YXZlIGl0IHVwIHRvIHRoZSBtb2NrCj4gLQkJICogaW1wbGVtZW50YXRpb24gdG8gY2FsbCBpbnRl
bF9lbmdpbmVfd2FrZXVwKCkKPiAtCQkgKiBpdHNlbGYgd2hlbiBpdCB3YW50cyB0byBzaW11bGF0
ZSBhIHVzZXIgaW50ZXJydXB0LAo+IC0JCSAqLwo+IC0JCXJldHVybiB0cnVlOwo+IC0JfQo+IC0K
PiAtCS8qIFNpbmNlIHdlIGFyZSB3YWl0aW5nIG9uIGEgcmVxdWVzdCwgdGhlIEdQVSBzaG91bGQg
YmUgYnVzeQo+ICsJLyoKPiArCSAqIFNpbmNlIHdlIGFyZSB3YWl0aW5nIG9uIGEgcmVxdWVzdCwg
dGhlIEdQVSBzaG91bGQgYmUgYnVzeQo+ICAgCSAqIGFuZCBzaG91bGQgaGF2ZSBpdHMgb3duIHJw
bSByZWZlcmVuY2UuIFRoaXMgaXMgdHJhY2tlZAo+ICAgCSAqIGJ5IGk5MTUtPmd0LmF3YWtlLCB3
ZSBjYW4gZm9yZ28gaG9sZGluZyBvdXIgb3duIHdha3JlZgo+ICAgCSAqIGZvciB0aGUgaW50ZXJy
dXB0IGFzIGJlZm9yZSBpOTE1LT5ndC5hd2FrZSBpcyByZWxlYXNlZCAod2hlbgo+IGRpZmYgLS1n
aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9lbmdpbmVfY3MuYyBiL2RyaXZlcnMvZ3B1
L2RybS9pOTE1L2ludGVsX2VuZ2luZV9jcy5jCj4gaW5kZXggZTJmNjVjNTlkNmU4Li5mYzUyNzM3
NzUxZTcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX2Nz
LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9lbmdpbmVfY3MuYwo+IEBAIC05
MTcsNiArOTE3LDkgQEAgc3RhdGljIGJvb2wgcmluZ19pc19pZGxlKHN0cnVjdCBpbnRlbF9lbmdp
bmVfY3MgKmVuZ2luZSkKPiAgIAlpbnRlbF93YWtlcmVmX3Qgd2FrZXJlZjsKPiAgIAlib29sIGlk
bGUgPSB0cnVlOwo+ICAgCj4gKwlpZiAoSTkxNV9TRUxGVEVTVF9PTkxZKCFlbmdpbmUtPm1taW9f
YmFzZSkpCj4gKwkJcmV0dXJuIHRydWU7Cj4gKwo+ICAgCS8qIElmIHRoZSB3aG9sZSBkZXZpY2Ug
aXMgYXNsZWVwLCB0aGUgZW5naW5lIG11c3QgYmUgaWRsZSAqLwo+ICAgCXdha2VyZWYgPSBpbnRl
bF9ydW50aW1lX3BtX2dldF9pZl9pbl91c2UoZGV2X3ByaXYpOwo+ICAgCWlmICghd2FrZXJlZikK
PiBAQCAtOTU1LDkgKzk1OCw2IEBAIGJvb2wgaW50ZWxfZW5naW5lX2lzX2lkbGUoc3RydWN0IGlu
dGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAgCWlmICghaW50ZWxfZW5naW5lX3NpZ25hbGVkKGVu
Z2luZSwgaW50ZWxfZW5naW5lX2xhc3Rfc3VibWl0KGVuZ2luZSkpKQo+ICAgCQlyZXR1cm4gZmFs
c2U7Cj4gICAKPiAtCWlmIChJOTE1X1NFTEZURVNUX09OTFkoZW5naW5lLT5icmVhZGNydW1icy5t
b2NrKSkKPiAtCQlyZXR1cm4gdHJ1ZTsKPiAtCj4gICAJLyogV2FpdGluZyB0byBkcmFpbiBFTFNQ
PyAqLwo+ICAgCWlmIChSRUFEX09OQ0UoZW5naW5lLT5leGVjbGlzdHMuYWN0aXZlKSkgewo+ICAg
CQlzdHJ1Y3QgdGFza2xldF9zdHJ1Y3QgKnQgPSAmZW5naW5lLT5leGVjbGlzdHMudGFza2xldDsK
PiBAQCAtOTgzLDEwICs5ODMsNyBAQCBib29sIGludGVsX2VuZ2luZV9pc19pZGxlKHN0cnVjdCBp
bnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAgIAkJcmV0dXJuIGZhbHNlOwo+ICAgCj4gICAJLyog
UmluZyBzdG9wcGVkPyAqLwo+IC0JaWYgKCFyaW5nX2lzX2lkbGUoZW5naW5lKSkKPiAtCQlyZXR1
cm4gZmFsc2U7Cj4gLQo+IC0JcmV0dXJuIHRydWU7Cj4gKwlyZXR1cm4gcmluZ19pc19pZGxlKGVu
Z2luZSk7Cj4gICB9Cj4gICAKPiAgIGJvb2wgaW50ZWxfZW5naW5lc19hcmVfaWRsZShzdHJ1Y3Qg
ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Jp
bmdidWZmZXIuaAo+IGluZGV4IDFhZGY5ODQ1NzEwYy4uMTdlMDVkMTFlZTM0IDEwMDY0NAo+IC0t
LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaAo+ICsrKyBiL2RyaXZl
cnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaAo+IEBAIC0zOTcsNyArMzk3LDYgQEAg
c3RydWN0IGludGVsX2VuZ2luZV9jcyB7Cj4gICAJCXVuc2lnbmVkIGludCBpcnFfY291bnQ7Cj4g
ICAKPiAgIAkJYm9vbCBpcnFfYXJtZWQgOiAxOwo+IC0JCUk5MTVfU0VMRlRFU1RfREVDTEFSRShi
b29sIG1vY2sgOiAxKTsKPiAgIAl9IGJyZWFkY3J1bWJzOwo+ICAgCj4gICAJc3RydWN0IHsKPiBk
aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvc2VsZnRlc3RzL21vY2tfZW5naW5lLmMg
Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9zZWxmdGVzdHMvbW9ja19lbmdpbmUuYwo+IGluZGV4IDUw
ZTFhMGIxYWY3ZS4uOWZlNWIyYzhmOGQ0IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L3NlbGZ0ZXN0cy9tb2NrX2VuZ2luZS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv
c2VsZnRlc3RzL21vY2tfZW5naW5lLmMKPiBAQCAtMjAxLDcgKzIwMSw2IEBAIHN0cnVjdCBpbnRl
bF9lbmdpbmVfY3MgKm1vY2tfZW5naW5lKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1LAo+
ICAgCWk5MTVfdGltZWxpbmVfc2V0X3N1YmNsYXNzKCZlbmdpbmUtPmJhc2UudGltZWxpbmUsIFRJ
TUVMSU5FX0VOR0lORSk7Cj4gICAKPiAgIAlpbnRlbF9lbmdpbmVfaW5pdF9icmVhZGNydW1icygm
ZW5naW5lLT5iYXNlKTsKPiAtCWVuZ2luZS0+YmFzZS5icmVhZGNydW1icy5tb2NrID0gdHJ1ZTsg
LyogcHJldmVudCB0b3VjaGluZyBIVyBmb3IgaXJxcyAqLwo+ICAgCj4gICAJLyogZmFrZSBodyBx
dWV1ZSAqLwo+ICAgCXNwaW5fbG9ja19pbml0KCZlbmdpbmUtPmh3X2xvY2spOwo+IApfX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGlu
ZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl
ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK