From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Benoît Monin" <benoit.monin@bootlin.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Jan Dabros <jsd@semihalf.com>, Andi Shyti <andi.shyti@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Vladimir Kondratiev <vladimir.kondratiev@mobileye.com>,
Tawfik Bayouk <tawfik.bayouk@mobileye.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] i2c: designware: use dev_err_probe() when probing platform device
Date: Fri, 5 Sep 2025 11:04:32 +0300 [thread overview]
Message-ID: <61ecd626-1081-4bf0-8db7-a68980f31e45@linux.intel.com> (raw)
In-Reply-To: <aLmqfQm2w3y1MM_2@smile.fi.intel.com>
On 9/4/25 6:04 PM, Andy Shevchenko wrote:
> On Thu, Sep 04, 2025 at 04:31:07PM +0200, Benoît Monin wrote:
>> Add calls to dev_err_probe() on error paths that can return
>> -EPROBE_DEFER when probing platform device. Namely when requesting the
>> reset controller, when probing for lock support and when requesting the
>> clocks.
>>
>> PCI device probing already use dev_err_probe().
>
> Makes sense by at least two aspects:
> 1) less log spamming for deferred probes;
> 2) easier to debug an issue (I assume it's your case).
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
next prev parent reply other threads:[~2025-09-05 8:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 14:31 [PATCH v2 0/2] Add dev_err_probe() to i2c designware platform probing Benoît Monin
2025-09-04 14:31 ` [PATCH v2 1/2] i2c: designware: convert to dev_err_probe() on request IRQ error Benoît Monin
2025-09-04 15:02 ` Andy Shevchenko
2025-09-05 8:04 ` Jarkko Nikula
2025-09-25 21:35 ` Wolfram Sang
2025-09-04 14:31 ` [PATCH v2 2/2] i2c: designware: use dev_err_probe() when probing platform device Benoît Monin
2025-09-04 15:04 ` Andy Shevchenko
2025-09-05 8:04 ` Jarkko Nikula [this message]
2025-09-25 21:35 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61ecd626-1081-4bf0-8db7-a68980f31e45@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=benoit.monin@bootlin.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=tawfik.bayouk@mobileye.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.kondratiev@mobileye.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.