From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm/omap: remove -Werror from Makefile
Date: Sun, 06 Mar 2016 17:22:35 +0200 [thread overview]
Message-ID: <6203413.JMFhXnae3H@avalon> (raw)
In-Reply-To: <56D88863.7060402@ti.com>
Hi Tomi,
On Thursday 03 March 2016 20:54:27 Tomi Valkeinen wrote:
> On 03/03/16 20:44, Laurent Pinchart wrote:
> > On Thursday 03 March 2016 16:01:16 Tomi Valkeinen wrote:
> >> Having -Werror in the omapdrm Makefile makes development and debugging a
> >> PITA. Let's remove it.
> >
> > Well, shouldn't we target having no warning ? :-)
>
> Yes, but we don't need to make errors of warnings to do that.
>
> I'm just too tired of trying to avoid warnings when doing new
> development or debugging or testing something.
>
> Too often I have wanted to comment out a line to test something, only to
> find out I need to comment out lots of other things too, just to get rid
> of "unused variable" warning.
>
> Or developing a new feature, knowing it's not ready but want to test it
> anyway, but even a single warning stops compilation.
Fair enough. It could still be interesting to treat warnings as errors by
default, but not specifically for the omapdrm driver, so I'm fine with this
patch.
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-03-06 15:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 14:01 [PATCH 0/3] drm/omap: patches for v4.6 part 3 Tomi Valkeinen
2016-03-03 14:01 ` [PATCH 1/3] drm/omap: remove -Werror from Makefile Tomi Valkeinen
2016-03-03 18:44 ` Laurent Pinchart
2016-03-03 18:54 ` Tomi Valkeinen
2016-03-06 15:22 ` Laurent Pinchart [this message]
2016-03-03 14:01 ` [PATCH 2/3] drm/omap: gem: Fix omap_gem_new() error path Tomi Valkeinen
2016-03-03 14:01 ` [PATCH 3/3] drm/omap: no need to select OMAP2_DSS Tomi Valkeinen
2016-03-06 15:24 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6203413.JMFhXnae3H@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.