From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-180.mta1.migadu.com (out-180.mta1.migadu.com [95.215.58.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7B2E27814F for ; Tue, 1 Jul 2025 15:37:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751384254; cv=none; b=uzcAVVg43YnoXCcI0H4Htn7O365YoIqUL+L7BxgT4tl98l3hVQLJj8qq3LvEcoihYRiQRSNENezjvVfMB08LuDnI10YaoVEJOQqvdx/SgmJaexdcKEySR8M6Tt1ugGVK3wo+JoIZw74ySmArLShOpp4qEmOZvWas65M/2PrIF3g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751384254; c=relaxed/simple; bh=ovi6ehXHRg2OXhTGZqfDtxC1wNJZkJuNbs9Djf+CFco=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BrLpK+2774SrijxqQjYmFixA34cFg27qsqsLRS2vAaf1z3AspTCnPpLAT0Wh74JbXCYr+PDJzZsQBR96PYU+qg2hnJuEGfa52busW9aWgrFPhoamtEK0kTy4GUwRtmB4E+yIASjnkqy4yaBW7D4k/pjctTcP3J1THUYc5gqRT/M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=ENigJ1dn; arc=none smtp.client-ip=95.215.58.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="ENigJ1dn" Message-ID: <62111125-c1f5-41ff-ba32-75ec41508906@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1751384250; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E82KrJwgWkOW+NmsBbXPBqs/aYg5/5kQ8qZzeEJKY/I=; b=ENigJ1dn2PFqbh4WbpieVYCLw8kAqUSRORgmHFVwvcLzQUCmm37tmyM9RCqNIwY3042XND lRqt4HEbDBXfxS0seaC8MGUTWpORbZ8HArRvGGuENOgfaMmJHs9hx9XFlaHZIAXJFXEMqQ mcU+JKqCuk7RbxuM6eF/9c9xBvWQikM= Date: Tue, 1 Jul 2025 11:37:21 -0400 Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net-next v2 07/18] net: macb: drop macb_config NULL checking To: =?UTF-8?Q?Th=C3=A9o_Lebrun?= , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Nicolas Ferre , Claudiu Beznea , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Samuel Holland , Richard Cochran , Russell King , Thomas Bogendoerfer , Vladimir Kondratiev , Gregory CLEMENT , Cyrille Pitchen , Harini Katakam , Rafal Ozieblo , Haavard Skinnemoen , Jeff Garzik Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-mips@vger.kernel.org, Thomas Petazzoni , Tawfik Bayouk References: <20250627-macb-v2-0-ff8207d0bb77@bootlin.com> <20250627-macb-v2-7-ff8207d0bb77@bootlin.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson In-Reply-To: <20250627-macb-v2-7-ff8207d0bb77@bootlin.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT On 6/27/25 05:08, Théo Lebrun wrote: > Remove NULL checks on macb_config as it is always valid: > - either it is its default value &default_gem_config, > - or it got overridden using match data. > > Signed-off-by: Théo Lebrun > --- > drivers/net/ethernet/cadence/macb_main.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c > index 6c8a34e40b77ea37ed25c2b0414440cd3f6962c3..6926ea11d71adae7a25d5ee329c148f5882d4184 100644 > --- a/drivers/net/ethernet/cadence/macb_main.c > +++ b/drivers/net/ethernet/cadence/macb_main.c > @@ -5227,15 +5227,13 @@ static int macb_probe(struct platform_device *pdev) > } > bp->num_queues = num_queues; > bp->queue_mask = queue_mask; > - if (macb_config) > - bp->dma_burst_length = macb_config->dma_burst_length; > + bp->dma_burst_length = macb_config->dma_burst_length; > bp->pclk = pclk; > bp->hclk = hclk; > bp->tx_clk = tx_clk; > bp->rx_clk = rx_clk; > bp->tsu_clk = tsu_clk; > - if (macb_config) > - bp->jumbo_max_len = macb_config->jumbo_max_len; > + bp->jumbo_max_len = macb_config->jumbo_max_len; > > if (!hw_is_gem(bp->regs, bp->native_io)) > bp->max_tx_length = MACB_MAX_TX_LEN; > Reviewed-by: Sean Anderson From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7233C7EE30 for ; Tue, 1 Jul 2025 18:31:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/iJZO7hb8ITOeTZPBKR3dsG08GiE0FVy+rBr0bZxHw4=; b=TYBHhW6Q8IocUf OIvUa4Nbe55iNovThy03m2ssY4z5LvipQ346JBIeiWNQ3GnV9jgJgBFe+PzjRrcKq3im5R4PW4p/o Tb+5j9n7vzGxuw52q+GuqKtSy+YJnW8MWw8W/8p4qLn9KxPG8YdY+kuBzRn9FNnYoHDmE/oLtvA9N ujuXISbbPNeodfwEimb2etw2sS4Eo669PK1iP684XpYoatnYr2DzUqfyNhopzUAjAzxQQO2VH966u WwIskarw7HVRUEHYJRbZLbGrTmY/HnrAWQ0V/Ay02mSV8Ul1rtralTEgREW2+yOCadwCMSXDYayBa I0qEMS9D1dO5IdZaO9SA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uWflN-00000006KpS-29dC; Tue, 01 Jul 2025 18:31:25 +0000 Received: from out-189.mta1.migadu.com ([2001:41d0:203:375::bd]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uWd36-00000005ueK-36rE for linux-riscv@lists.infradead.org; Tue, 01 Jul 2025 15:37:34 +0000 Message-ID: <62111125-c1f5-41ff-ba32-75ec41508906@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1751384250; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E82KrJwgWkOW+NmsBbXPBqs/aYg5/5kQ8qZzeEJKY/I=; b=ENigJ1dn2PFqbh4WbpieVYCLw8kAqUSRORgmHFVwvcLzQUCmm37tmyM9RCqNIwY3042XND lRqt4HEbDBXfxS0seaC8MGUTWpORbZ8HArRvGGuENOgfaMmJHs9hx9XFlaHZIAXJFXEMqQ mcU+JKqCuk7RbxuM6eF/9c9xBvWQikM= Date: Tue, 1 Jul 2025 11:37:21 -0400 MIME-Version: 1.0 Subject: Re: [PATCH net-next v2 07/18] net: macb: drop macb_config NULL checking To: =?UTF-8?Q?Th=C3=A9o_Lebrun?= , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Nicolas Ferre , Claudiu Beznea , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Samuel Holland , Richard Cochran , Russell King , Thomas Bogendoerfer , Vladimir Kondratiev , Gregory CLEMENT , Cyrille Pitchen , Harini Katakam , Rafal Ozieblo , Haavard Skinnemoen , Jeff Garzik Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-mips@vger.kernel.org, Thomas Petazzoni , Tawfik Bayouk References: <20250627-macb-v2-0-ff8207d0bb77@bootlin.com> <20250627-macb-v2-7-ff8207d0bb77@bootlin.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson In-Reply-To: <20250627-macb-v2-7-ff8207d0bb77@bootlin.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250701_083732_927677_58B032AC X-CRM114-Status: GOOD ( 13.51 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gNi8yNy8yNSAwNTowOCwgVGjDqW8gTGVicnVuIHdyb3RlOgo+IFJlbW92ZSBOVUxMIGNoZWNr cyBvbiBtYWNiX2NvbmZpZyBhcyBpdCBpcyBhbHdheXMgdmFsaWQ6Cj4gIC0gZWl0aGVyIGl0IGlz IGl0cyBkZWZhdWx0IHZhbHVlICZkZWZhdWx0X2dlbV9jb25maWcsCj4gIC0gb3IgaXQgZ290IG92 ZXJyaWRkZW4gdXNpbmcgbWF0Y2ggZGF0YS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBUaMOpbyBMZWJy dW4gPHRoZW8ubGVicnVuQGJvb3RsaW4uY29tPgo+IC0tLQo+ICBkcml2ZXJzL25ldC9ldGhlcm5l dC9jYWRlbmNlL21hY2JfbWFpbi5jIHwgNiArKy0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDIgaW5z ZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQv ZXRoZXJuZXQvY2FkZW5jZS9tYWNiX21haW4uYyBiL2RyaXZlcnMvbmV0L2V0aGVybmV0L2NhZGVu Y2UvbWFjYl9tYWluLmMKPiBpbmRleCA2YzhhMzRlNDBiNzdlYTM3ZWQyNWMyYjA0MTQ0NDBjZDNm Njk2MmMzLi42OTI2ZWExMWQ3MWFkYWU3YTI1ZDVlZTMyOWMxNDhmNTg4MmQ0MTg0IDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvbmV0L2V0aGVybmV0L2NhZGVuY2UvbWFjYl9tYWluLmMKPiArKysgYi9k cml2ZXJzL25ldC9ldGhlcm5ldC9jYWRlbmNlL21hY2JfbWFpbi5jCj4gQEAgLTUyMjcsMTUgKzUy MjcsMTMgQEAgc3RhdGljIGludCBtYWNiX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBk ZXYpCj4gIAl9Cj4gIAlicC0+bnVtX3F1ZXVlcyA9IG51bV9xdWV1ZXM7Cj4gIAlicC0+cXVldWVf bWFzayA9IHF1ZXVlX21hc2s7Cj4gLQlpZiAobWFjYl9jb25maWcpCj4gLQkJYnAtPmRtYV9idXJz dF9sZW5ndGggPSBtYWNiX2NvbmZpZy0+ZG1hX2J1cnN0X2xlbmd0aDsKPiArCWJwLT5kbWFfYnVy c3RfbGVuZ3RoID0gbWFjYl9jb25maWctPmRtYV9idXJzdF9sZW5ndGg7Cj4gIAlicC0+cGNsayA9 IHBjbGs7Cj4gIAlicC0+aGNsayA9IGhjbGs7Cj4gIAlicC0+dHhfY2xrID0gdHhfY2xrOwo+ICAJ YnAtPnJ4X2NsayA9IHJ4X2NsazsKPiAgCWJwLT50c3VfY2xrID0gdHN1X2NsazsKPiAtCWlmICht YWNiX2NvbmZpZykKPiAtCQlicC0+anVtYm9fbWF4X2xlbiA9IG1hY2JfY29uZmlnLT5qdW1ib19t YXhfbGVuOwo+ICsJYnAtPmp1bWJvX21heF9sZW4gPSBtYWNiX2NvbmZpZy0+anVtYm9fbWF4X2xl bjsKPiAgCj4gIAlpZiAoIWh3X2lzX2dlbShicC0+cmVncywgYnAtPm5hdGl2ZV9pbykpCj4gIAkJ YnAtPm1heF90eF9sZW5ndGggPSBNQUNCX01BWF9UWF9MRU47Cj4gCgpSZXZpZXdlZC1ieTogU2Vh biBBbmRlcnNvbiA8c2Vhbi5hbmRlcnNvbkBsaW51eC5kZXY+CgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1yaXNjdiBtYWlsaW5nIGxpc3QKbGlu dXgtcmlzY3ZAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJpc2N2Cg==