From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E38FC433EF for ; Tue, 17 May 2022 09:01:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242296AbiEQJBS (ORCPT ); Tue, 17 May 2022 05:01:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244081AbiEQJBN (ORCPT ); Tue, 17 May 2022 05:01:13 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6DCA115700 for ; Tue, 17 May 2022 02:01:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652778071; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bTEAmJWDQjyVQdo/huPK56rWT/Ja3yG1ilQMT9ylP9I=; b=NSyzI8BabCzTkKCDHhVHhEYsNrmVS1e4GimBsNSheNU9XVHj5qeuPam7kiJwMiBMcWM9Ka XG5etJJtFdPf3SAawx+W4o7b37TRP+Y0drYs4yq0/IO2S679zQB4ctCs8Gx0l1UpnSdYM8 N2evnKU7wRxEtEMB03nYg5rwDTwbwHA= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-472-Al9SOTMZPL6VxrzzH2Eyrw-1; Tue, 17 May 2022 05:01:09 -0400 X-MC-Unique: Al9SOTMZPL6VxrzzH2Eyrw-1 Received: by mail-ed1-f71.google.com with SMTP id n9-20020aa7d049000000b0042aab725949so4327171edo.23 for ; Tue, 17 May 2022 02:01:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=bTEAmJWDQjyVQdo/huPK56rWT/Ja3yG1ilQMT9ylP9I=; b=qEU7PHtI6qsMsolsOepUkf2GcvvRcODIJ+Ta42itxXL6v1w1vL1l8IR0scLSJFKA/T P8TU2DTAbas63gf+SNTR+G4cDHnQwfq59t7HG+qQd9DpJLkX1aJp+qvh9p9LY0CulSOv Y3cspzsf8W63Nvbyq7G7T59aSlxTWh72aoTBUqpoOh0c77CBu+7EPnhcK4rT4GRFE76b FCM+bz28tlpx8cB6wJ2OwvLrZkELgzqslyzNx94VXJBgsdY3R9InhOvRwQlkmF/o7jm6 PavTbLQc6Sbqz+MtonJzjJNxH2WD2NJbazY+GPJdDXhTgpNEXxsJXWDfWSp/m+esnvBb QwuQ== X-Gm-Message-State: AOAM532ue8WoTT7Oyq8+uIoEovOcn8lZ7B02YRijpb2jP/OlaPdiSJdD A92DVN/+r6aZcXHZxUvuJLW5aHeuSUALcRM1M60iNP2EbFgEi6/DDui6VfoS1DkOq4Giz5nrpvr EzAKfNFXtUIrx X-Received: by 2002:a17:906:794b:b0:6f4:85e1:d7f with SMTP id l11-20020a170906794b00b006f485e10d7fmr18325320ejo.6.1652778068474; Tue, 17 May 2022 02:01:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw4gP1uuWDN9RinZ3jE+uPtasR1lITXJRIKhSDb4PAL2nI0R5KsUc7yfZZFeaD1hC0ZPdxBcQ== X-Received: by 2002:a17:906:794b:b0:6f4:85e1:d7f with SMTP id l11-20020a170906794b00b006f485e10d7fmr18325307ejo.6.1652778068277; Tue, 17 May 2022 02:01:08 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.googlemail.com with ESMTPSA id r9-20020a1709064d0900b006f3ef214dbcsm791988eju.34.2022.05.17.02.01.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 May 2022 02:01:07 -0700 (PDT) Message-ID: <6212bdfe-ecd2-3787-a2cb-b285318b102a@redhat.com> Date: Tue, 17 May 2022 11:01:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v11 14/16] KVM: x86/vmx: Flip Arch LBREn bit on guest state change Content-Language: en-US To: "Yang, Weijiang" Cc: "jmattson@google.com" , "seanjc@google.com" , "kan.liang@linux.intel.com" , "like.xu.linux@gmail.com" , "vkuznets@redhat.com" , "Wang, Wei W" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20220506033305.5135-1-weijiang.yang@intel.com> <20220506033305.5135-15-weijiang.yang@intel.com> <9f19a5eb-3eb0-58a2-e4ee-612f3298ba82@redhat.com> <9e2b5e9f-25a2-b724-c6d7-282dc987aa99@intel.com> <8a15c4b4-cabe-7bc3-bd98-bd669d586616@redhat.com> <5f264701-b6d5-8660-55ae-a5039d6a9d3a@intel.com> From: Paolo Bonzini In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 5/17/22 10:56, Yang, Weijiang wrote: >> I added more things to ease migration handling in SMM because: 1) qemu >> checks LBREn before transfer Arch LBR MSRs. I think it should always transfer them instead? There's time to post a fixup patch. >> 2) Perf event is created when >> LBREn is being set.  Two things are not certain: 1) IA32_LBR_CTL doesn't have >> corresponding slot in SMRAM,not sure if we need to rely on it to transfer the MSR. >> I chose 0x7f10 as the offset(CET takes 0x7f08) for storage, need you double check if >> it's free or used. 0x7f10 sounds good. > Hi, Paolo, > > I found there're some rebase conflicts between this series and your kvm > queue branch due to PEBS patches, I can re-post a new version based on > your queue branch if necessary. Yes, please. > Waiting for your comments on this patch... I already commented that using bit 63 is not good, didn't I? Paolo