From: "xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>
To: Cyril Hrubis <chrubis@suse.cz>, Petr Vorel <pvorel@suse.cz>
Cc: "ltp@lists.linux.it" <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v3 3/7] lib/tst_safe_pidfd: Add SAFE_PIDFD_OPEN macro
Date: Tue, 1 Mar 2022 05:59:15 +0000 [thread overview]
Message-ID: <621DB650.2020606@fujitsu.com> (raw)
In-Reply-To: <Yhj86k9U46vmGnm9@yuki>
Hi Cyril,Petr
I merged this patchset, thanks for your review.
Best Regards
Yang Xu
> Hi!
>> Just avoid a big tst_safe_macros.h like tst_safe_sysv_ipc.h does.
>> Also the pidfd related syscalls seems no libc wrapper.
>>
>> Based on the above two points, I started a new header. Also if you want
>> to merge it into tst_safe_macros.h, I will do(I don't have objection to
>> add this into tst_safe_macros.h ).
>
> I would have just added the definitions to the tst_safe_macros.h, but
> it's not a big deal.
>
> Otherwise the actuall code looks good, with the header merged to tst_safe_macros.h:
>
> Reviewed-by: Cyril Hrubis<chrubis@suse.cz>
>
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-03-01 5:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 8:41 [LTP] [PATCH v3 1/7] Merge multiple pidfd*.h into one header Yang Xu
2022-02-22 8:41 ` [LTP] [PATCH v3 2/7] syscalls/pidfd_send_signal: Add docparse formatting Yang Xu
2022-02-23 13:25 ` Cyril Hrubis
2022-02-22 8:41 ` [LTP] [PATCH v3 3/7] lib/tst_safe_pidfd: Add SAFE_PIDFD_OPEN macro Yang Xu
2022-02-23 13:28 ` Cyril Hrubis
2022-02-24 7:23 ` xuyang2018.jy
2022-02-25 15:59 ` Cyril Hrubis
2022-03-01 5:59 ` xuyang2018.jy [this message]
2022-02-22 8:41 ` [LTP] [PATCH v3 4/7] syscalls/fanotify21: Make use of SAFE_PIDFD_OPEN Yang Xu
2022-02-23 13:29 ` Cyril Hrubis
2022-02-22 8:41 ` [LTP] [PATCH v3 5/7] syscalls/pidfd_open01, 04: Make use of SAFE_FCNTL Yang Xu
2022-02-23 13:34 ` Cyril Hrubis
2022-02-23 13:22 ` [LTP] [PATCH v3 1/7] Merge multiple pidfd*.h into one header Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=621DB650.2020606@fujitsu.com \
--to=xuyang2018.jy@fujitsu.com \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.