From: "xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>
To: Martin Doucha <mdoucha@suse.cz>
Cc: "ltp@lists.linux.it" <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH 1/3] quotactl06: Replace tst_brk(TFAIL) with TBROK
Date: Fri, 4 Mar 2022 01:35:20 +0000 [thread overview]
Message-ID: <62216D10.9060409@fujitsu.com> (raw)
In-Reply-To: <20220303153131.3372-1-mdoucha@suse.cz>
Hi Martin
Looks good to me,
Reviewed-by: Yang Xu <xuyang2018.jy@fujitsu.com>
Also, quotactl01 also use this similar code, I guess we can also replace
it. It seems we miss SAFE_ACCESS macro, we can add this macro and use it
in all similar code.
Best Regards
Yang Xu
> Signed-off-by: Martin Doucha<mdoucha@suse.cz>
> ---
> testcases/kernel/syscalls/quotactl/quotactl06.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/testcases/kernel/syscalls/quotactl/quotactl06.c b/testcases/kernel/syscalls/quotactl/quotactl06.c
> index 4fb198268..ca81a742f 100644
> --- a/testcases/kernel/syscalls/quotactl/quotactl06.c
> +++ b/testcases/kernel/syscalls/quotactl/quotactl06.c
> @@ -178,7 +178,7 @@ static void setup(void)
> set_dqmax.dqb_bsoftlimit = tst_variant ? 0x20000000000000 : 0x100000000;
>
> if (access(USRPATH, F_OK) == -1)
> - tst_brk(TFAIL | TERRNO, "user quotafile didn't exist");
> + tst_brk(TBROK | TERRNO, "user quotafile didn't exist");
>
> tst_require_quota_support(tst_device->dev, fmt_id, usrpath);
>
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2022-03-04 1:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 15:31 [LTP] [PATCH 1/3] quotactl06: Replace tst_brk(TFAIL) with TBROK Martin Doucha
2022-03-03 15:31 ` [LTP] [PATCH 2/3] quotactl06: Code style fixes Martin Doucha
2022-03-04 1:36 ` xuyang2018.jy
2022-03-03 15:31 ` [LTP] [PATCH 3/3] quotactl06: Fix TESTDIR1 cleanup if setup() exits early Martin Doucha
2022-03-04 1:38 ` xuyang2018.jy
2022-03-04 9:24 ` Martin Doucha
2022-03-04 10:00 ` xuyang2018.jy
2022-03-04 1:35 ` xuyang2018.jy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62216D10.9060409@fujitsu.com \
--to=xuyang2018.jy@fujitsu.com \
--cc=ltp@lists.linux.it \
--cc=mdoucha@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.