From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v6 1/5] efd: new Elastic Flow Distributor
	library
Date: Tue, 17 Jan 2017 21:32:16 +0100
Message-ID: <6225531.lXhTr8K9SA@xps13>
References: <1484559804-133610-1-git-send-email-pablo.de.lara.guarch@intel.com>
 <1484594519-227376-1-git-send-email-pablo.de.lara.guarch@intel.com>
 <1484594519-227376-2-git-send-email-pablo.de.lara.guarch@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Byron Marohn <byron.marohn@intel.com>,
 Saikrishna Edupuganti <saikrishna.edupuganti@intel.com>
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id 943CB1094
 for <dev@dpdk.org>; Tue, 17 Jan 2017 21:32:18 +0100 (CET)
Received: by mail-wm0-f46.google.com with SMTP id c206so241888664wme.0
 for <dev@dpdk.org>; Tue, 17 Jan 2017 12:32:18 -0800 (PST)
In-Reply-To: <1484594519-227376-2-git-send-email-pablo.de.lara.guarch@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2017-01-16 19:21, Pablo de Lara:
> +#if defined(RTE_ARCH_X86)
> +       if (RTE_EFD_VALUE_NUM_BITS > 3 && rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2))

magic number spotted!
A comment would be probably helpful in this case.

> +               table->lookup_fn = EFD_LOOKUP_AVX2;
> +       else
> +#endif
> +               table->lookup_fn = EFD_LOOKUP_SCALAR;
>