From: Florian Achleitner <florian.achleitner.2.6.31@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Florian Achleitner <florian.achleitner.2.6.31@gmail.com>,
David Michael Barr <b@rr-dav.id.au>,
Jonathan Nieder <jrnieder@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH/RFC v4 01/16] GSOC remote-svn
Date: Mon, 20 Aug 2012 15:52:02 +0200 [thread overview]
Message-ID: <6231669.WggyDX4Xa3@flomedio> (raw)
In-Reply-To: <7vzk5srm9w.fsf@alter.siamese.dyndns.org>
On Saturday 18 August 2012 13:13:47 Junio C Hamano wrote:
> That indicates that one necessary patch to add logic to Makefile to
> go and build that subdirectory, at least before running the test,
> but possibly as part of the "all" target, is missing, isn't it?
>
> Or you can add, at the beginning of your tests files that require
> the contrib bit, to have something like
>
> if test -e "$GIT_BUILD_DIR/remote-svn"
> then
> test_set_prereq REMOTE_SVN
> fi
>
> and protect your tests with the prerequisite, e.g.
>
> test_expect_success REMOTE_SVN 'test svn:// URL' '
> ...
> '
>
> without changing the top-level Makefile.
What version would you prefer? Currently nothing in contrib/ is built by the
toplevel Makefile..
next prev parent reply other threads:[~2012-08-20 13:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-17 20:25 [PATCH/RFC v4 01/16] GSOC remote-svn Florian Achleitner
2012-08-17 20:25 ` [PATCH/RFC v4 01/16] Implement a remote helper for svn in C Florian Achleitner
2012-08-17 20:25 ` [PATCH/RFC v4 02/16] Integrate remote-svn into svn-fe/Makefile Florian Achleitner
2012-08-17 20:25 ` [PATCH/RFC v4 03/16] Add svndump_init_fd to allow reading dumps from arbitrary FDs Florian Achleitner
2012-08-17 20:25 ` [PATCH/RFC v4 04/16] Add argv_array_detach and argv_array_free_detached Florian Achleitner
2012-08-17 20:25 ` [PATCH/RFC v4 05/16] Connect fast-import to the remote-helper via pipe, adding 'bidi-import' capability Florian Achleitner
2012-08-17 20:25 ` [PATCH/RFC v4 06/16] Add documentation for the 'bidi-import' capability of remote-helpers Florian Achleitner
2012-08-17 20:25 ` [PATCH/RFC v4 07/16] When debug==1, start fast-import with "--stats" instead of "--quiet" Florian Achleitner
2012-08-17 20:25 ` [PATCH/RFC v4 08/16] remote-svn, vcs-svn: Enable fetching to private refs Florian Achleitner
2012-08-17 20:25 ` [PATCH/RFC v4 09/16] Allow reading svn dumps from files via file:// urls Florian Achleitner
2012-08-17 20:25 ` [PATCH/RFC v4 10/16] vcs-svn: add fast_export_note to create notes Florian Achleitner
2012-08-17 20:25 ` [PATCH/RFC v4 11/16] Create a note for every imported commit containing svn metadata Florian Achleitner
2012-08-17 20:25 ` [PATCH/RFC v4 12/16] remote-svn: Activate import/export-marks for fast-import Florian Achleitner
2012-08-17 20:25 ` [PATCH/RFC v4 13/16] remote-svn: add incremental import Florian Achleitner
2012-08-17 20:25 ` [PATCH/RFC v4 14/16] Add a svnrdump-simulator replaying a dump file for testing Florian Achleitner
2012-08-17 20:25 ` [PATCH/RFC v4 15/16] remote-svn: add marks-file regeneration Florian Achleitner
2012-08-17 20:25 ` [PATCH/RFC v4 16/16] Add a test script for remote-svn Florian Achleitner
2012-08-18 4:16 ` [PATCH/RFC v4 01/16] GSOC remote-svn Junio C Hamano
2012-08-18 18:06 ` Florian Achleitner
2012-08-18 20:13 ` Junio C Hamano
2012-08-19 6:35 ` Junio C Hamano
2012-08-20 6:21 ` Florian Achleitner
2012-08-20 6:51 ` Junio C Hamano
2012-08-20 13:52 ` Florian Achleitner [this message]
2012-08-20 16:23 ` Junio C Hamano
2012-08-20 16:43 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6231669.WggyDX4Xa3@flomedio \
--to=florian.achleitner.2.6.31@gmail.com \
--cc=b@rr-dav.id.au \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.