From: John Fastabend <john.fastabend@gmail.com>
To: fankaixi.li@bytedance.com, shuah@kernel.org, bpf@vger.kernel.org
Cc: "kaixi.fan" <fankaixi.li@bytedance.com>
Subject: RE: [PATCH] selftests/bpf: fix tunnel remote ip comments
Date: Wed, 16 Mar 2022 20:57:14 -0700 [thread overview]
Message-ID: <6232b19a306b2_3ed720828@john.notmuch> (raw)
In-Reply-To: <20220313164116.5889-1-fankaixi.li@bytedance.com>
fankaixi.li@ wrote:
> From: "kaixi.fan" <fankaixi.li@bytedance.com>
>
> In namespace at_ns0, the ip address of tnl dev is 10.1.1.100 which
> is the overlay ip, and the ip address of veth0 is 172.16.1.100
> which is the vtep ip.
> When doing 'ping 10.1.1.100' from root namespace, the
> remote_ip should be 172.16.1.100.
>
> Fixs: 933a741e ("selftests/bpf: bpf tunnel test.")
> Signed-off-by: kaixi.fan <fankaixi.li@bytedance.com>
> ---
> tools/testing/selftests/bpf/test_tunnel.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/test_tunnel.sh b/tools/testing/selftests/bpf/test_tunnel.sh
> index ca1372924023..2817d9948d59 100755
> --- a/tools/testing/selftests/bpf/test_tunnel.sh
> +++ b/tools/testing/selftests/bpf/test_tunnel.sh
> @@ -39,7 +39,7 @@
> # from root namespace, the following operations happen:
> # 1) Route lookup shows 10.1.1.100/24 belongs to tnl dev, fwd to tnl dev.
> # 2) Tnl device's egress BPF program is triggered and set the tunnel metadata,
> -# with remote_ip=172.16.1.200 and others.
> +# with remote_ip=172.16.1.100 and others.
> # 3) Outer tunnel header is prepended and route the packet to veth1's egress
> # 4) veth0's ingress queue receive the tunneled packet at namespace at_ns0
> # 5) Tunnel protocol handler, ex: vxlan_rcv, decap the packet
> --
> 2.24.3 (Apple Git-128)
>
checks out.
Acked-by: John Fastabend <john.fastabend@gmail.com>
next prev parent reply other threads:[~2022-03-17 5:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-13 16:41 [PATCH] selftests/bpf: fix tunnel remote ip comments fankaixi.li
2022-03-17 3:57 ` John Fastabend [this message]
2022-03-17 19:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6232b19a306b2_3ed720828@john.notmuch \
--to=john.fastabend@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=fankaixi.li@bytedance.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.