From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756593AbcE0V4O (ORCPT <rfc822;w@1wt.eu>);
	Fri, 27 May 2016 17:56:14 -0400
Received: from mout.kundenserver.de ([217.72.192.74]:56730 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750927AbcE0V4M (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 27 May 2016 17:56:12 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: David Vrabel <david.vrabel@citrix.com>
Cc: Juergen Gross <jgross@suse.com>,
        Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
        Daniel Kiper <daniel.kiper@oracle.com>,
        Paul Gortmaker <paul.gortmaker@windriver.com>,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Julien Grall <julien.grall@citrix.com>,
        Ross Lagerwall <ross.lagerwall@citrix.com>,
        xen-devel@lists.xenproject.org,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [Xen-devel] [PATCH] xen: remove incorrect forward declaration
Date: Fri, 27 May 2016 23:55:54 +0200
Message-ID: <6236240.bcXTAP1H4S@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <5746D0C8.7000801@citrix.com>
References: <1462972075-918938-1-git-send-email-arnd@arndb.de> <5746D0C8.7000801@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:/mujfLk+hV8LYHseiPzn1eNHqy8EIdScv8W9SMPbzVSeJl2iIgg
 DdI3JFXPHGgBkfMuUs0LfIKTgI/HOdq9vBW2dcWM3lNwPBxCFgXt7e40TQhQ1FqQBrYhQxI
 VUdiiT/I1VB04HPCT5xI6F39C2kBkgiJThV1F3Zluy4ppbebIyPxC+HoPgdvX9DWffg9eg+
 guvZQshHclL7jeNdUmp9Q==
X-UI-Out-Filterresults: notjunk:1;V01:K0:irn1jEtwYfE=:b1kcJ8yIQkQKUKGe2yOx+R
 hI6kBtbRkiyUL8Mn1KmOS8vPjVKH+UDn4pxLorPn4n0Hnlgiteujzdzx8nGEMQrAd0JEz3iL5
 7pn0JCgIy2tohLuvzx2mvtMOkTwzn4W7jkuaNOdwbxhCrFOv9RFL+9malJczRgoEwUBq3ofd7
 1K1CQ7I5NUkzRIYe2uPoij9stUgW4CrNNs3KW5T3dbzCCAWfLa3LX3qO1U3u9O2+d3uUstCOw
 NYa8yW/lgzH8H7fL7dn6VWFPXn7TuqCMBnv/X4HGImfqvH6H+Ga+GubOM97t1rtY550hl9h32
 tPDcLfwxCh0DhDq9j1uMGux25QyZ0BbHxti2H0hyEKbC9EHWTnxRLQlxQdScJh/IinPaIzYvq
 PX3makA6zSACs5AazsF0O05MLRjT/4T6ZH15WzQ6Tm0baDPUUYj0yVh5PvBLnRUu4ROWGD3zZ
 22Z6lGKZ448aZfGRpoaQhLZfEc+nF4R5n1xf+8hISWf5Tr4TWEp8PYEEQUsgiNQmxW6uP6ccA
 zHxqMdXx22sFgAaqZ/7On8DsNttHIbscFF9b88fxb785ufsoA4n1xOC/L76zxFC+7KmwYew3s
 HvkbxWNxZzVzCSJ+r/2PfH+eK3ciGwz/bpVPDkqYmz7aWKL+T98j2kle0wSVDsFMyK357iG7k
 wQ7VTNsXjA/7RmpnVMZ+/pS9qHf7j3R87pusU3e1Eo3yBTv2JMhShJwsUIN5dRfm+0b6fGOew
 BgGN/TMDKGYGOkCo
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thursday, May 26, 2016 11:32:40 AM CEST David Vrabel wrote:
> On 11/05/16 14:07, Arnd Bergmann wrote:
> > A bugfix patch for the xen balloon driver introduced a forward
> > declaration for a static function that is conditionally compiled,
> > causing a warning if only the declaration but not the definition
> > are there:
> > 
> > drivers/xen/balloon.c:154:13: error: 'release_memory_resource' declared 'static' but never defined [-Werror=unused-function]
> >  static void release_memory_resource(struct resource *resource);
> > 
> > This removes the declaration again and instead moves the function
> > definition to the right place, before its first caller and inside
> > of the #ifdef protecting both.
> 
> I've applied the equivalent patch from Ross, instead.

Ok, thanks.

> > The patch that introduced the warning is marked for stable
> > backports, so if that gets applied to 4.4, so should this one.
> 
> Fixes for compiler warnings are not sufficiently important to be
> backported to stable.

Sure, but this is not an existing warning but one that only gets
introduced after the other patch gets backported, which I'd consider
a different category.

	Arnd