Re: [PATCH] drm/i915/gtt: Pull global wc page stash under its own locking

From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/gtt: Pull global wc page stash under its own locking
Date: Wed, 4 Jul 2018 14:59:31 +0100	[thread overview]
Message-ID: <623a869a-5cc8-9de4-1ab6-7dcac4795a91@linux.intel.com> (raw)
In-Reply-To: <153071014592.15734.5810621176939397834@skylake.alporthouse.com>

On 04/07/2018 14:15, Chris Wilson wrote:
> Quoting Chris Wilson (2018-07-04 13:55:13)
>> Quoting Chris Wilson (2018-07-04 13:53:54)
>>> Quoting Tvrtko Ursulin (2018-07-04 13:48:18)
>>>>>    
>>>>> -     if (stash.nr) {
>>>>> -             int nr = min_t(int, stash.nr, pagevec_space(pvec));
>>>>> -             struct page **pages = stash.pages + stash.nr - nr;
>>>>> +     if (stash->nr && !set_pages_array_wc(stash->pages, stash->nr)) {
>>>>
>>>> Previously the test was for pages which obviously the local thread
>>>> owned. Now I am not sure if the condition says.
>>>
>>> Still owned by the local thread.
>>
>> Actually, no. I need to drop the mutex for the allocation. So back to
>> onstack stash.
> 
> Worse, I drop the mutex up one level around a few other kmallocs, looks
> like I need more locking down here.

Or revert and come back to it at more leisurely moment?

Regards,

Tvrtko

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx