From: "xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>
To: Christian Brauner <brauner@kernel.org>
Cc: "david@fromorbit.com" <david@fromorbit.com>,
"djwong@kernel.org" <djwong@kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"fstests@vger.kernel.org" <fstests@vger.kernel.org>
Subject: Re: [PATCH v1 2/2] idmapped-mounts: Add umask before test setgid_create
Date: Fri, 1 Apr 2022 06:08:58 +0000 [thread overview]
Message-ID: <62469728.4040904@fujitsu.com> (raw)
In-Reply-To: <20220331120239.uzliits77lfmn5m2@wittgenstein>
on 2022/3/31 20:02, Christian Brauner wrote:
> On Thu, Mar 31, 2022 at 05:28:22PM +0800, Yang Xu wrote:
>> Since stipping S_SIGID should check S_IXGRP, so umask it to check whether
>> works well.
>>
>> Signed-off-by: Yang Xu<xuyang2018.jy@fujitsu.com>
>> ---
>
> (Sidenote: I really need to rename the test binary to something other
> than idmapped-mounts.c as this tests a lot of generic vfs stuff that has
> nothing to do with them.)
>
> Tested-by: Christian Brauner (Microsoft)<brauner@kernel.org>
> Reviewed-by: Christian Brauner (Microsoft)<brauner@kernel.org>
>
>> If we enable acl on parent directory, then umask is useless, maybe we
>> also add setfacl on parent directory because we may change the order
>> about strip S_ISGID and posix_acl setup. Any idea?
>
> If acls figure into this then this should probably be a new test or
> subtest.
Will add it on v2
Best Regards
Yang Xu
next prev parent reply other threads:[~2022-04-01 6:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 9:28 [PATCH v1 1/2] idmapped-mounts: Add mknodat operation in setgid test Yang Xu
2022-03-31 9:28 ` [PATCH v1 2/2] idmapped-mounts: Add umask before test setgid_create Yang Xu
2022-03-31 12:02 ` Christian Brauner
2022-04-01 6:08 ` xuyang2018.jy [this message]
2022-04-01 10:16 ` xuyang2018.jy
2022-03-31 11:59 ` [PATCH v1 1/2] idmapped-mounts: Add mknodat operation in setgid test Christian Brauner
2022-03-31 12:10 ` Christian Brauner
2022-04-01 6:11 ` xuyang2018.jy
2022-04-01 6:08 ` xuyang2018.jy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62469728.4040904@fujitsu.com \
--to=xuyang2018.jy@fujitsu.com \
--cc=brauner@kernel.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.