RE: Fix bugs found by SVACE static analisys tool

[bluez.test.bot@gmail.com]

[-- Attachment #1: Type: text/plain, Size: 5273 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=628169

---Test result---

Test Summary:
CheckPatch                    PASS      9.84 seconds
GitLint                       PASS      6.66 seconds
Prep - Setup ELL              PASS      43.31 seconds
Build - Prep                  PASS      0.69 seconds
Build - Configure             PASS      8.81 seconds
Build - Make                  FAIL      79.44 seconds
Make Check                    FAIL      1.17 seconds
Make Check w/Valgrind         FAIL      65.80 seconds
Make Distcheck                PASS      231.36 seconds
Build w/ext ELL - Configure   PASS      8.78 seconds
Build w/ext ELL - Make        FAIL      79.82 seconds
Incremental Build with patchesFAIL      4376.50 seconds

Details
##############################
Test: Build - Make - FAIL
Desc: Build the BlueZ source tree
Output:
tools/bluemoon.c: In function ‘request_firmware’:
tools/bluemoon.c:495:17: error: comparison of integer expressions of different signedness: ‘__off_t’ {aka ‘long int’} and ‘long unsigned int’ [-Werror=sign-compare]
  495 |  if (st.st_size > (SIZE_MAX - 4)) {
      |                 ^
tools/bluemoon.c: In function ‘analyze_firmware’:
tools/bluemoon.c:884:17: error: comparison of integer expressions of different signedness: ‘__off_t’ {aka ‘long int’} and ‘long unsigned int’ [-Werror=sign-compare]
  884 |  if (st.st_size > (SIZE_MAX - 3)) {
      |                 ^
cc1: all warnings being treated as errors
make[1]: *** [Makefile:7277: tools/bluemoon.o] Error 1
make: *** [Makefile:4310: all] Error 2


##############################
Test: Make Check - FAIL
Desc: Run 'make check'
Output:
tools/bluemoon.c: In function ‘request_firmware’:
tools/bluemoon.c:495:17: error: comparison of integer expressions of different signedness: ‘__off_t’ {aka ‘long int’} and ‘long unsigned int’ [-Werror=sign-compare]
  495 |  if (st.st_size > (SIZE_MAX - 4)) {
      |                 ^
tools/bluemoon.c: In function ‘analyze_firmware’:
tools/bluemoon.c:884:17: error: comparison of integer expressions of different signedness: ‘__off_t’ {aka ‘long int’} and ‘long unsigned int’ [-Werror=sign-compare]
  884 |  if (st.st_size > (SIZE_MAX - 3)) {
      |                 ^
cc1: all warnings being treated as errors
make[1]: *** [Makefile:7277: tools/bluemoon.o] Error 1
make: *** [Makefile:11283: check] Error 2


##############################
Test: Make Check w/Valgrind - FAIL
Desc: Run 'make check' with Valgrind
Output:
tools/bluemoon.c: In function ‘request_firmware’:
tools/bluemoon.c:495:17: error: comparison of integer expressions of different signedness: ‘__off_t’ {aka ‘long int’} and ‘long unsigned int’ [-Werror=sign-compare]
  495 |  if (st.st_size > (SIZE_MAX - 4)) {
      |                 ^
tools/bluemoon.c: In function ‘analyze_firmware’:
tools/bluemoon.c:884:17: error: comparison of integer expressions of different signedness: ‘__off_t’ {aka ‘long int’} and ‘long unsigned int’ [-Werror=sign-compare]
  884 |  if (st.st_size > (SIZE_MAX - 3)) {
      |                 ^
cc1: all warnings being treated as errors
make[1]: *** [Makefile:7277: tools/bluemoon.o] Error 1
make: *** [Makefile:4310: all] Error 2


##############################
Test: Build w/ext ELL - Make - FAIL
Desc: Build BlueZ source with '--enable-external-ell' configuration
Output:
tools/bluemoon.c: In function ‘request_firmware’:
tools/bluemoon.c:495:17: error: comparison of integer expressions of different signedness: ‘__off_t’ {aka ‘long int’} and ‘long unsigned int’ [-Werror=sign-compare]
  495 |  if (st.st_size > (SIZE_MAX - 4)) {
      |                 ^
tools/bluemoon.c: In function ‘analyze_firmware’:
tools/bluemoon.c:884:17: error: comparison of integer expressions of different signedness: ‘__off_t’ {aka ‘long int’} and ‘long unsigned int’ [-Werror=sign-compare]
  884 |  if (st.st_size > (SIZE_MAX - 3)) {
      |                 ^
cc1: all warnings being treated as errors
make[1]: *** [Makefile:7277: tools/bluemoon.o] Error 1
make: *** [Makefile:4310: all] Error 2


##############################
Test: Incremental Build with patches - FAIL
Desc: Incremental build per patch in the series
Output:
tools/bluemoon.c: In function ‘request_firmware’:
tools/bluemoon.c:495:17: error: comparison of integer expressions of different signedness: ‘__off_t’ {aka ‘long int’} and ‘long unsigned int’ [-Werror=sign-compare]
  495 |  if (st.st_size > (SIZE_MAX - 4)) {
      |                 ^
tools/bluemoon.c: In function ‘analyze_firmware’:
tools/bluemoon.c:884:17: error: comparison of integer expressions of different signedness: ‘__off_t’ {aka ‘long int’} and ‘long unsigned int’ [-Werror=sign-compare]
  884 |  if (st.st_size > (SIZE_MAX - 3)) {
      |                 ^
cc1: all warnings being treated as errors
make[1]: *** [Makefile:7277: tools/bluemoon.o] Error 1
make: *** [Makefile:4310: all] Error 2




---
Regards,
Linux Bluetooth