From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ma Ke <make24@iscas.ac.cn>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org,
aloisio.almeida@openbossa.org, lauro.venancio@openbossa.org,
sameo@linux.intel.com, linville@tuxdriver.com,
johannes@sipsolutions.net
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, stable@vger.kernel.org
Subject: Re: [PATCH] NFC: Fix error handling in nfc_genl_dump_targets
Date: Mon, 15 Dec 2025 12:28:39 +0100 [thread overview]
Message-ID: <624c7965-54cd-4897-9883-c8f4e79d3ca7@kernel.org> (raw)
In-Reply-To: <20251214131726.5353-1-make24@iscas.ac.cn>
On 14/12/2025 14:17, Ma Ke wrote:
> nfc_genl_dump_targets() increments the device reference count via
> nfc_get_device() but fails to decrement it properly. nfc_get_device()
> calls class_find_device() which internally calls get_device() to
> increment the reference count. No corresponding put_device() is made
> to decrement the reference count.
>
> Add proper reference count decrementing using nfc_put_device() when
> the dump operation completes or encounters an error, ensuring balanced
> reference counting.
>
> Found by code review.
NAK, you completely ignore reviewers and send the same. That's not
acceptable.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-12-15 11:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-14 13:17 [PATCH] NFC: Fix error handling in nfc_genl_dump_targets Ma Ke
2025-12-14 13:54 ` David Laight
2025-12-15 8:39 ` Johannes Berg
2025-12-15 11:28 ` Krzysztof Kozlowski [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-11-21 2:27 Ma Ke
2025-11-24 8:24 ` Krzysztof Kozlowski
2025-11-24 8:30 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=624c7965-54cd-4897-9883-c8f4e79d3ca7@kernel.org \
--to=krzk@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=aloisio.almeida@openbossa.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=lauro.venancio@openbossa.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=make24@iscas.ac.cn \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sameo@linux.intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.